From: Lee Jones <lee@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Dan Murphy <dmurphy@ti.com>,
Pavel Machek <pavel@ucw.cz>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it
Date: Wed, 1 Mar 2023 14:21:11 +0000 [thread overview]
Message-ID: <Y/9fVzOO17TBgPnX@google.com> (raw)
In-Reply-To: <20230226053953.4681-5-rdunlap@infradead.org>
On Sat, 25 Feb 2023, Randy Dunlap wrote:
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dan Murphy <dmurphy@ti.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Lee Jones <lee@kernel.org>
> Cc: linux-leds@vger.kernel.org
> ---
> drivers/leds/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-03-01 14:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 5:39 [PATCH 0/8] drivers: select REGMAP instead of depending on it Randy Dunlap
2023-02-26 5:39 ` [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO " Randy Dunlap
2023-02-26 22:59 ` Corey Minyard
2023-02-26 23:49 ` Randy Dunlap
2023-02-26 5:39 ` [PATCH 2/8] clk: HI655X: select REGMAP " Randy Dunlap
2023-03-06 19:30 ` Stephen Boyd
2023-02-26 5:39 ` [PATCH 3/8] gpio: GPIO_REGMAP: " Randy Dunlap
2023-02-26 18:06 ` Michael Walle
2023-03-06 10:17 ` Bartosz Golaszewski
2023-02-26 5:39 ` [PATCH 4/8] leds: TI_LMU_COMMON: " Randy Dunlap
2023-02-27 11:37 ` Pavel Machek
2023-03-01 14:21 ` Lee Jones [this message]
2023-02-26 5:39 ` [PATCH 5/8] platform: mellanox: " Randy Dunlap
2023-02-26 6:37 ` Vadim Pasternak
2023-02-26 5:39 ` [PATCH 6/8] platform: x86: MLX_PLATFORM: " Randy Dunlap
2023-02-26 6:37 ` Vadim Pasternak
2023-02-26 5:39 ` [PATCH 7/8] thermal: intel: BXT_PMIC: " Randy Dunlap
2023-03-01 18:34 ` Rafael J. Wysocki
2023-02-26 5:39 ` [PATCH 8/8] serial: 8250: ASPEED_VUART: " Randy Dunlap
2023-02-27 9:31 ` [PATCH 0/8] drivers: " Hans de Goede
2023-02-27 16:07 ` Randy Dunlap
2023-03-01 12:47 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/9fVzOO17TBgPnX@google.com \
--to=lee@kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.