From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDDE4C64EC4 for ; Fri, 17 Feb 2023 14:03:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229818AbjBQOD4 (ORCPT ); Fri, 17 Feb 2023 09:03:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229673AbjBQODx (ORCPT ); Fri, 17 Feb 2023 09:03:53 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 186DE656B2; Fri, 17 Feb 2023 06:03:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A7F1061BA0; Fri, 17 Feb 2023 14:03:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1EF0C433EF; Fri, 17 Feb 2023 14:03:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676642632; bh=uohuAHrUCjnqA7irnaiWAtD+EmHIGiwseVTupadX5zo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k3x8ARgnp/EUpbuufgbLFiKFaCTeO5ylHTOPnWaNNXvVEQydhvaPGeKMZ7EnuUgEc pfM6+P8rROn+rVQi5HSc3fWZUT3iL6K38EFRg1pkOurXm7Kn7doFpDxnmeNMnJ3Xxu s09dUZyBU5up84KCnkvZcaZIEZtEFUHZEJJ2VMhhhuOeCYBDc4uBdqVSJzsn1EbuE0 HSv3AI+F7snKnu7ZGPrg8Q02tuZbcy5qScWnNlHTds8iP9GA2Y81DoIvV/c00daYju woUxAPP5QXJojPmNvkxByqqcM+Ocq6h+UQ1Lkd+IqgFTziNQL28Bq6WXtSEmUaWzfs MhFB+oltjckWg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 4B76140025; Fri, 17 Feb 2023 11:03:49 -0300 (-03) Date: Fri, 17 Feb 2023 11:03:49 -0300 From: Arnaldo Carvalho de Melo To: "Steinar H. Gunderson" Cc: Adrian Hunter , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] perf intel-pt: Synthesize cycle events Message-ID: References: <20220322082452.1429091-1-sesse@google.com> <52d31321-66e1-f189-2ffc-7c93239eea74@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Feb 17, 2023 at 12:02:21PM +0100, Steinar H. Gunderson escreveu: > On Fri, Mar 25, 2022 at 07:07:40PM -0300, Arnaldo Carvalho de Melo wrote: > >>> > >>> There are two issues in play: > >>> > >>> 1. PT event synth doesn't support reading inline information from DWARF > >>> yet, and my patch to add it runs into some problems. This is not > >>> relevant for this patch at all. > >>> 2. The results from v3 don't quite match the ones from v1, and neither > >>> of us are entirely sure why. My personal feeling is that the one > >>> from v1 are the wrong ones, but it's up to Adrian to say whether we > >>> want to try to investigate deeply here. > >> V3 is good. Please take that. > > Thanks, applied. > > Hi, > > I downloaded linux-6.1.12 now and built perf from that, and this patch > isn't included. Did it get somehow lost along the way? I must have committed some mistake when doing rebases, I'm sorry. I applied it now and will push it later today, after the usual set of tests with it and other patches I apply today. - Arnaldo