All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Rishit Bansal <rishitbansal0@gmail.com>,
	Mark Gross <markgross@kernel.org>,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	Linux LED Subsystem <linux-leds@vger.kernel.org>,
	Dan Murphy <dmurphy@ti.com>
Subject: Re: API for setting colors of RGB backlit keyboard zones (was [PATCH V3] platform/x86: hp-wmi: Support omen backlight control wmi-acpi methods)
Date: Tue, 7 Feb 2023 12:53:40 +0100	[thread overview]
Message-ID: <Y+I7xNqkq/X6Lag+@duo.ucw.cz> (raw)
In-Reply-To: <544484b9-c0ac-2fd0-1f41-8fa94cb94d4b@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 909 bytes --]

Hi!

> >> 2. Create 4 separate multi-color LED sysfs devices for each zone:
> >>
> >> /sys/class/leds/hp_omen::kbd_backlight-zone1/
> >> /sys/class/leds/hp_omen::kbd_backlight-zone2/
> >> /sys/class/leds/hp_omen::kbd_backlight-zone3/
> >> /sys/class/leds/hp_omen::kbd_backlight-zone4/

4 separate devices, please. And the naming should be consistent with
the rest, so

:rbg:kbd_backlight-zone1

would be closer to something consistent. Should be documented in

Documentation/leds/well-known-leds.txt

. And if you take a look there, you'll notice we already have N900
that has 6 zones with white backlight.

But I'd really like to see plan to go forward. AFAICT there are
keyboards with per-key backlight, and those start to look less like a
set of LEDs and more like a display...

Best regards,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  parent reply	other threads:[~2023-02-07 11:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31 23:50 [PATCH V3] platform/x86: hp-wmi: Support omen backlight control wmi-acpi methods Rishit Bansal
2023-02-01  8:17 ` Hans de Goede
2023-02-01 13:59   ` Rishit Bansal
2023-02-02 12:43     ` Hans de Goede
2023-02-02 19:59       ` Rishit Bansal
2023-02-06 14:32         ` API for setting colors of RGB backlit keyboard zones (was [PATCH V3] platform/x86: hp-wmi: Support omen backlight control wmi-acpi methods) Hans de Goede
2023-02-06 15:07           ` Rishit Bansal
2023-02-07 11:53           ` Pavel Machek [this message]
2023-02-07 13:05             ` Rishit Bansal
2023-02-13 12:49               ` Hans de Goede
2023-02-13 14:16                 ` Rishit Bansal
2023-02-18 11:48                   ` Pavel Machek
2023-02-19 13:20                     ` Hans de Goede
2023-02-19 18:46                       ` Rishit Bansal
2023-02-20  8:43                         ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+I7xNqkq/X6Lag+@duo.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=dmurphy@ti.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rishitbansal0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.