All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guru Mehar Rachaputi <gurumeharrachaputi@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] staging: vt6655: Macro with braces issue changed to inline function
Date: Tue, 7 Feb 2023 10:05:33 +0100	[thread overview]
Message-ID: <Y+IUXSO8LM53qHoJ@kroah.com> (raw)
In-Reply-To: <cover.1675753094.git.gurumeharrachaputi@gmail.com>

On Tue, Feb 07, 2023 at 09:40:37AM +0100, Guru Mehar Rachaputi wrote:
> This patch is to fix checkpatch warning: "Macro argument 'iobase' may be better
> as '(iobase)' to avoid precedence issues" changed to inline function. In
> relation to this, names of the callers of macro are also modified to call
> this function.
> 
> 
> Changes in v4:
> 	- Modified commit message to be clear
> 
> Changes in v3:
> 	1. Whitespace error from checkpatch fixed
> 	2. Should be applied together with changes in v2 for testing
> 
> Changes in v2:
> 	- Macros with one statement that is to call 'iowrite8' function changed
> 	to inline function as reviewed by gregkh@linuxfoundation.org.
> 	In relation to this, names of the callers of macro are also modified
> 	to call this function.
> 
> 
> Guru Mehar Rachaputi (4):
>   staging: vt6655: Add braces to macro parameter 'iobase'
>   staging: vt6655: Macro with braces issue change to inline function
>   staging: vt6655: Macro with braces issue change to inline function
>   staging: vt6655: Macro with braces issue changed to inline function
> 
>  drivers/staging/vt6655/card.c        |  4 ++--
>  drivers/staging/vt6655/channel.c     |  4 ++--
>  drivers/staging/vt6655/device_main.c | 12 ++++++------
>  drivers/staging/vt6655/mac.c         |  8 ++++----
>  drivers/staging/vt6655/mac.h         | 12 +++++++++---
>  5 files changed, 23 insertions(+), 17 deletions(-)
> 
> -- 
> 2.34.1
> 
> 
> -- 
> Thanks & Regards,
> Guru

> >From 447c10de599e3434fb6c012cdfc2cc8e4b5c839b Mon Sep 17 00:00:00 2001
> Message-Id: <447c10de599e3434fb6c012cdfc2cc8e4b5c839b.1675753094.git.gurumeharrachaputi@gmail.com>
> In-Reply-To: <cover.1675753094.git.gurumeharrachaputi@gmail.com>
> References: <cover.1675753094.git.gurumeharrachaputi@gmail.com>
> From: Guru Mehar Rachaputi <gurumeharrachaputi@gmail.com>
> Date: Sat, 4 Feb 2023 04:34:38 +0100
> Subject: [PATCH v2 1/4] staging: vt6655: Add braces to macro parameter
>  'iobase'

<snip>

Do you see other examples of people on the mailing list submitting
patches as multiple attachments?

Please do not do this.

I recommend taking a week or so and reviewing the other submissions that
are sent to the list first, to understand the processes involved, before
trying to submit your own changes.

Remember, you need to learn to read first, before you learn how to write :)

thanks,

greg k-h

  parent reply	other threads:[~2023-02-07  9:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07  7:14 [PATCH v2 0/4] staging: vt6655: Macro with braces issue changed to inline function Guru Mehar Rachaputi
2023-02-07  8:40 ` Guru Mehar Rachaputi
2023-02-07  7:40 ` Greg Kroah-Hartman
2023-02-07  8:42   ` Guru Mehar Rachaputi
2023-02-07  9:05 ` Greg Kroah-Hartman [this message]
2023-02-07  9:36   ` Guru Mehar Rachaputi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+IUXSO8LM53qHoJ@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=forest@alittletooquiet.net \
    --cc=gurumeharrachaputi@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.