From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB0502587 for ; Tue, 7 Feb 2023 12:25:32 +0000 (UTC) Received: by mail-wr1-f46.google.com with SMTP id o18so13382824wrj.3 for ; Tue, 07 Feb 2023 04:25:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LZAucNLzijzKQ21Q4plD1d78GkaeAHQGHHtmZwwWx5M=; b=vjxJteG2AEMkQG8SG05CW8sO/4P+xzJk2Vnh+rBKD69Ff/Oyfka4vwhhsZqhKRgws0 15epdVbZeytxecFYQENRy0JaR6NWBjj0Qo/lPnMvyNPXGX1tmkhykVGpQqAZ2Et9pzVj W0ToShnsMttJXXxEb12Wpkrn4Nju+WATfpg/1Lx7cNiD6nGkO8Ljb5FJxIEBge4t84BD jX6+9449Q6o80EhUImqQHqOC2gxWkbo4WnoWqyGnWkrH7P5APItItpLNbxRfmvL6ruUw FQIZWIJ1uvd/yw+WxuDIJ40Fp3uC7IS1K4cXMhuLDamgqsJctdyCwF2srRjG0QMjiXH3 ay0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LZAucNLzijzKQ21Q4plD1d78GkaeAHQGHHtmZwwWx5M=; b=cYPvBnDNaJGAhquaBBsinQcu7Gddff3VTuYNAIcOqs4qkuM8twbMw4iU9+DfzsIs9H HRZ9On2VFYmr5OQidjfDgnu79xpXVAQy0MoQAioVwRV887XN3lvwWYfPUkR0k/uLs0gJ WAolnytLVCDttL9soUf5bJYp4EF5aq/hxn/eyrpt8HbmH3C0FaemI98wDTN9A3avsMWz 8glkgA5qtokzSKjG641ZdR3mRWgGgAzLYHbgKd6QMbUOuDG1R6ucaLEaWHbUoCpp4Yvh sU8GMWJhXoAwUaBvTguy/zaDEYW8/JiDaQ3iyNf++qf8pxRW2Q2ThUkN1iWiy3glH6aV Gn/g== X-Gm-Message-State: AO0yUKU5nByfyh9JzaDBB6j/YSfMY/foYn/DNsh/6bV/sxb64oCO8o3m 9jVbyA+LL+pjRjlaCv0a6fnFgw== X-Google-Smtp-Source: AK7set8vgK5CfM858EiDxkXkMMgPk8OOvF3Hcy+IAl3YuF1Ka53mp4jCWqk6XtOI1TyvyC37K565Pw== X-Received: by 2002:a05:6000:104:b0:2bf:ae3c:e963 with SMTP id o4-20020a056000010400b002bfae3ce963mr2424172wrx.9.1675772731272; Tue, 07 Feb 2023 04:25:31 -0800 (PST) Received: from myrica (054592b0.skybroadband.com. [5.69.146.176]) by smtp.gmail.com with ESMTPSA id f6-20020a5d5686000000b002c3daaef051sm9949472wrv.82.2023.02.07.04.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 04:25:30 -0800 (PST) Date: Tue, 7 Feb 2023 12:25:26 +0000 From: Jean-Philippe Brucker To: Steven Price Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev Subject: Re: [RFC PATCH 06/28] arm64: RME: ioctls to create and configure realms Message-ID: References: <20230127112248.136810-1-suzuki.poulose@arm.com> <20230127112932.38045-1-steven.price@arm.com> <20230127112932.38045-7-steven.price@arm.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230127112932.38045-7-steven.price@arm.com> On Fri, Jan 27, 2023 at 11:29:10AM +0000, Steven Price wrote: > +static int kvm_rme_config_realm(struct kvm *kvm, struct kvm_enable_cap *cap) > +{ > + struct kvm_cap_arm_rme_config_item cfg; > + struct realm *realm = &kvm->arch.realm; > + int r = 0; > + > + if (kvm_realm_state(kvm) != REALM_STATE_NONE) > + return -EBUSY; This should also check kvm_is_realm() (otherwise we dereference a NULL realm). I was wondering about fuzzing the API to find more of this kind of issue, but don't know anything about it. Is there a recommended way to fuzz KVM? Thanks, Jean From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5EA0C636CC for ; Tue, 7 Feb 2023 12:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ukJrUkiSMdL60M8gG79Me5YAHw4mDCGzWMpx1BUi4y0=; b=Kuu6FeqUYPmv4r d3UalsJ6AUBk11i1nA8i0lv624SEz/mvJaQ8lRo41DApYto5HV3QUEF94/gxOyvsb3VlHyO6bTsm4 Dve91tY17hqGjPltB/vJpEtoG7ukof6hRIPdHDtszt6AZZut6LuRq/uGLVPXlZ0c3lds9XX0aPj5B llS7kqrDORtRwiiLQKR1ERwYmMnZZkmQli7/b95782njXotqwVlearTDdxy5QVK5YclRpmZkmOX4f bW1FulcJoO3BzDg+0vjBfsDZwPK+egTvAdLvuQlpFZlLRoPsdtlYmp/7OE8v+Tjeq9i6WsRmtKuNt vlGonP6zZrRrw8Iy1Cng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPN2a-00C5Hz-RS; Tue, 07 Feb 2023 12:25:40 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPN2V-00C5Gh-Ox for linux-arm-kernel@lists.infradead.org; Tue, 07 Feb 2023 12:25:38 +0000 Received: by mail-wr1-x42f.google.com with SMTP id g6so5392198wrv.1 for ; Tue, 07 Feb 2023 04:25:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LZAucNLzijzKQ21Q4plD1d78GkaeAHQGHHtmZwwWx5M=; b=vjxJteG2AEMkQG8SG05CW8sO/4P+xzJk2Vnh+rBKD69Ff/Oyfka4vwhhsZqhKRgws0 15epdVbZeytxecFYQENRy0JaR6NWBjj0Qo/lPnMvyNPXGX1tmkhykVGpQqAZ2Et9pzVj W0ToShnsMttJXXxEb12Wpkrn4Nju+WATfpg/1Lx7cNiD6nGkO8Ljb5FJxIEBge4t84BD jX6+9449Q6o80EhUImqQHqOC2gxWkbo4WnoWqyGnWkrH7P5APItItpLNbxRfmvL6ruUw FQIZWIJ1uvd/yw+WxuDIJ40Fp3uC7IS1K4cXMhuLDamgqsJctdyCwF2srRjG0QMjiXH3 ay0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LZAucNLzijzKQ21Q4plD1d78GkaeAHQGHHtmZwwWx5M=; b=jHk23e7hBn4/Hye+KZCGx7IX36uIaSXBFJ15/GPd92VwDjnyHiItSnAJeuYahPauN1 WfUc08bdk09uTgjE4GeuJ1FRc3Zv/bvPRXaL7+l42Uwj618A3XQNsIe8mrHIO+gvh9qg rLEv1fMFn5s9+KLx5H4qvvDsCxpA4lrPWEMTQ3uxSwam0yRj3umOcFj+bQF35G4PWShD twOb+BjPNiCd38c5tIUNCRGW3sx23e6l/fAThL/DZMwUh1v2Nm8ottaF5Ew/RF82AsVw 31ZCwIDyKKZpcZlYzwjUoXYZj3+HfPT2XEztD+Ip1DCkE+Q2uMs8/N1A065eQkU2vzBX aGww== X-Gm-Message-State: AO0yUKVVrV6Qtprm/pEX8YI5BGQvRzV9Jx/qJc8YQ7d6KqvCLJNra5og FuPKFN1mYmJ7zcB66xNZOwNDcg== X-Google-Smtp-Source: AK7set8vgK5CfM858EiDxkXkMMgPk8OOvF3Hcy+IAl3YuF1Ka53mp4jCWqk6XtOI1TyvyC37K565Pw== X-Received: by 2002:a05:6000:104:b0:2bf:ae3c:e963 with SMTP id o4-20020a056000010400b002bfae3ce963mr2424172wrx.9.1675772731272; Tue, 07 Feb 2023 04:25:31 -0800 (PST) Received: from myrica (054592b0.skybroadband.com. [5.69.146.176]) by smtp.gmail.com with ESMTPSA id f6-20020a5d5686000000b002c3daaef051sm9949472wrv.82.2023.02.07.04.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 04:25:30 -0800 (PST) Date: Tue, 7 Feb 2023 12:25:26 +0000 From: Jean-Philippe Brucker To: Steven Price Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev Subject: Re: [RFC PATCH 06/28] arm64: RME: ioctls to create and configure realms Message-ID: References: <20230127112248.136810-1-suzuki.poulose@arm.com> <20230127112932.38045-1-steven.price@arm.com> <20230127112932.38045-7-steven.price@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230127112932.38045-7-steven.price@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230207_042535_832432_374C8E2E X-CRM114-Status: GOOD ( 11.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 27, 2023 at 11:29:10AM +0000, Steven Price wrote: > +static int kvm_rme_config_realm(struct kvm *kvm, struct kvm_enable_cap *cap) > +{ > + struct kvm_cap_arm_rme_config_item cfg; > + struct realm *realm = &kvm->arch.realm; > + int r = 0; > + > + if (kvm_realm_state(kvm) != REALM_STATE_NONE) > + return -EBUSY; This should also check kvm_is_realm() (otherwise we dereference a NULL realm). I was wondering about fuzzing the API to find more of this kind of issue, but don't know anything about it. Is there a recommended way to fuzz KVM? Thanks, Jean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel