All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henrik Grimler <henrik@grimler.se>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	alim.akhtar@samsung.com, jenneron@protonmail.com,
	markuss.broks@gmail.com, martin.juecker@gmail.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Valentine Iourine <iourine@iourine.msk.su>
Subject: Re: [PATCH v2 2/2] ARM: dts: exynos: add mmc aliases
Date: Thu, 9 Feb 2023 19:20:39 +0100	[thread overview]
Message-ID: <Y+U5d7dpKceXkh6f@L14.lan> (raw)
In-Reply-To: <e6c8ba8a-7d53-6931-a2e8-bcf4ecfbcd81@linaro.org>

On Thu, Feb 09, 2023 at 04:18:33PM +0100, Krzysztof Kozlowski wrote:
> On 09/02/2023 15:50, Marek Szyprowski wrote:
> > On 09.02.2023 15:23, Krzysztof Kozlowski wrote:
> >> On 28/01/2023 14:31, Henrik Grimler wrote:
> >>> Add aliases for eMMC, SD card and WiFi where applicable, so that
> >>> assigned mmcblk numbers are always the same.

[ ... ]

> >>> +	aliases {
> >>> +		mmc0 = &sdhci_0;
> >>> +		mmc2 = &sdhci_2;
> >>> +		mmc3 = &sdhci_3;
> >> 1. Is this actually correct? Since mmc1 was disabled, sdhci_2 had mmc1
> >> index but now will have mmc2.
> >>
> >> 2. I tested Odroid U3 and the ID changed. emmc went from 1 to 0. Any
> >> idea why? Both patches should be transparent.
> > 
> > Nope, eMMC and SD order changed a few times in the past and now they get 
> > indices based on the probe time, so any order is possible depending on 
> > the presence of the sd card / eMMC module.
> > 
> >> 3. Patchset does not look bisectable, so both patches should be squashed.
> > 
> > Why? First patch removes obsolete mshc aliases, which don't determine 
> > the logical MMC device number in the system. The second one adds fixed 
> > indices to the local MMC devices created by the respective MMC host 
> > controllers.
> 
> Ah, I see now, so mshc only determined the caps. That makes sense and
> answers my two questions.
> 
> But my question (1) a bit remains - these numbers of aliases should
> reflect what is wired on the board, so:
> A. before indices were mmc0, mmc1, mmc2 (and sdhcio_1 disabled). Now
> indices will be mmc0, mmc2 and mmc3, right?

Yes (and before indices could change between reboots).

> B. How the interface is called on the board? For some boards we actually
> can check with schematics.

Based on the limited public information like user manuals ([1] and
[2]) I *think* the internal storage, sdhci_0 and mshc_0 on 4210 and
4412 (respectively), is connected to data lines belonging to both
SDMMC0 and SDMMC1 (4+4 data lines, SDMMC# is what the IP is called in
user manuals), since they have a bus-width of 8.  The sdcard reader
however has a bus-width of 4 and is connected to just SDMMC2 on both.

So, I think suggested aliases best describe the hardware.  Maybe Marek
or someone else at Samsung has a better understanding of these boards
though :)

> Best regards,
> Krzysztof

[1] https://web.archive.org/web/20170918162018/http://www.samsung.com/global/business/semiconductor/file/product/Pulbicmanual_Exynos_4_Dual_45nm_Ver00-2.pdf
[2] https://github.com/lian494362816/Tiny4412/blob/master/Pdf/Exynos%204412%20SCP_Users%20Manual_Ver.0.10.00_Preliminary0.pdf

Best regards,
Henrik Grimler

WARNING: multiple messages have this Message-ID (diff)
From: Henrik Grimler <henrik@grimler.se>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	alim.akhtar@samsung.com, jenneron@protonmail.com,
	markuss.broks@gmail.com, martin.juecker@gmail.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Valentine Iourine <iourine@iourine.msk.su>
Subject: Re: [PATCH v2 2/2] ARM: dts: exynos: add mmc aliases
Date: Thu, 9 Feb 2023 19:20:39 +0100	[thread overview]
Message-ID: <Y+U5d7dpKceXkh6f@L14.lan> (raw)
In-Reply-To: <e6c8ba8a-7d53-6931-a2e8-bcf4ecfbcd81@linaro.org>

On Thu, Feb 09, 2023 at 04:18:33PM +0100, Krzysztof Kozlowski wrote:
> On 09/02/2023 15:50, Marek Szyprowski wrote:
> > On 09.02.2023 15:23, Krzysztof Kozlowski wrote:
> >> On 28/01/2023 14:31, Henrik Grimler wrote:
> >>> Add aliases for eMMC, SD card and WiFi where applicable, so that
> >>> assigned mmcblk numbers are always the same.

[ ... ]

> >>> +	aliases {
> >>> +		mmc0 = &sdhci_0;
> >>> +		mmc2 = &sdhci_2;
> >>> +		mmc3 = &sdhci_3;
> >> 1. Is this actually correct? Since mmc1 was disabled, sdhci_2 had mmc1
> >> index but now will have mmc2.
> >>
> >> 2. I tested Odroid U3 and the ID changed. emmc went from 1 to 0. Any
> >> idea why? Both patches should be transparent.
> > 
> > Nope, eMMC and SD order changed a few times in the past and now they get 
> > indices based on the probe time, so any order is possible depending on 
> > the presence of the sd card / eMMC module.
> > 
> >> 3. Patchset does not look bisectable, so both patches should be squashed.
> > 
> > Why? First patch removes obsolete mshc aliases, which don't determine 
> > the logical MMC device number in the system. The second one adds fixed 
> > indices to the local MMC devices created by the respective MMC host 
> > controllers.
> 
> Ah, I see now, so mshc only determined the caps. That makes sense and
> answers my two questions.
> 
> But my question (1) a bit remains - these numbers of aliases should
> reflect what is wired on the board, so:
> A. before indices were mmc0, mmc1, mmc2 (and sdhcio_1 disabled). Now
> indices will be mmc0, mmc2 and mmc3, right?

Yes (and before indices could change between reboots).

> B. How the interface is called on the board? For some boards we actually
> can check with schematics.

Based on the limited public information like user manuals ([1] and
[2]) I *think* the internal storage, sdhci_0 and mshc_0 on 4210 and
4412 (respectively), is connected to data lines belonging to both
SDMMC0 and SDMMC1 (4+4 data lines, SDMMC# is what the IP is called in
user manuals), since they have a bus-width of 8.  The sdcard reader
however has a bus-width of 4 and is connected to just SDMMC2 on both.

So, I think suggested aliases best describe the hardware.  Maybe Marek
or someone else at Samsung has a better understanding of these boards
though :)

> Best regards,
> Krzysztof

[1] https://web.archive.org/web/20170918162018/http://www.samsung.com/global/business/semiconductor/file/product/Pulbicmanual_Exynos_4_Dual_45nm_Ver00-2.pdf
[2] https://github.com/lian494362816/Tiny4412/blob/master/Pdf/Exynos%204412%20SCP_Users%20Manual_Ver.0.10.00_Preliminary0.pdf

Best regards,
Henrik Grimler

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-02-09 18:20 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230128133213eucas1p274ea3393199fe711fba8f542197e1dea@eucas1p2.samsung.com>
2023-01-28 13:31 ` [PATCH v2 0/2] ARM: dts: add mmc aliases for Exynos devices Henrik Grimler
2023-01-28 13:31   ` Henrik Grimler
2023-01-28 13:31   ` [PATCH v2 1/2] ARM: dts: exynos: drop mshc aliases Henrik Grimler
2023-01-28 13:31     ` Henrik Grimler
2023-01-30 13:27     ` Marek Szyprowski
2023-01-30 13:27       ` Marek Szyprowski
2023-02-09 14:39     ` Krzysztof Kozlowski
2023-02-09 14:39       ` Krzysztof Kozlowski
2023-02-09 14:56       ` Henrik Grimler
2023-02-09 14:56         ` Henrik Grimler
2023-01-28 13:31   ` [PATCH v2 2/2] ARM: dts: exynos: add mmc aliases Henrik Grimler
2023-01-28 13:31     ` Henrik Grimler
2023-01-30 13:28     ` Marek Szyprowski
2023-01-30 13:28       ` Marek Szyprowski
2023-02-09 14:23     ` Krzysztof Kozlowski
2023-02-09 14:23       ` Krzysztof Kozlowski
2023-02-09 14:50       ` Marek Szyprowski
2023-02-09 14:50         ` Marek Szyprowski
2023-02-09 15:18         ` Krzysztof Kozlowski
2023-02-09 15:18           ` Krzysztof Kozlowski
2023-02-09 18:20           ` Henrik Grimler [this message]
2023-02-09 18:20             ` Henrik Grimler
2023-02-09 15:06     ` Rob Herring
2023-02-09 15:06       ` Rob Herring
2023-02-09 15:22       ` David Virag
2023-02-09 15:22         ` David Virag
2023-02-09 18:07         ` Henrik Grimler
2023-02-09 18:07           ` Henrik Grimler
2023-01-30 13:28   ` [PATCH v2 0/2] ARM: dts: add mmc aliases for Exynos devices Marek Szyprowski
2023-01-30 13:28     ` Marek Szyprowski
2023-01-30 19:59     ` Henrik Grimler
2023-01-30 19:59       ` Henrik Grimler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+U5d7dpKceXkh6f@L14.lan \
    --to=henrik@grimler.se \
    --cc=alim.akhtar@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=iourine@iourine.msk.su \
    --cc=jenneron@protonmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=markuss.broks@gmail.com \
    --cc=martin.juecker@gmail.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.