From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9B58C636D6 for ; Thu, 9 Feb 2023 14:57:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229834AbjBIO5C (ORCPT ); Thu, 9 Feb 2023 09:57:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231168AbjBIO5B (ORCPT ); Thu, 9 Feb 2023 09:57:01 -0500 Received: from out-108.mta1.migadu.com (out-108.mta1.migadu.com [95.215.58.108]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08555EFA6 for ; Thu, 9 Feb 2023 06:56:57 -0800 (PST) Date: Thu, 9 Feb 2023 15:56:53 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=grimler.se; s=key1; t=1675954615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7pQICwV9BQwh0rqup+XjsiIjDhBDv4jvmO4frgTOT8w=; b=c58lg+63q4bbXysaBaqmipgYlFzuAHV1ucjwoMv2dNxMtO1TEBtlDAJE2DWALUgq46AcHo qmzzS74d7ZmXVTvjG9qeM+kNiyuCo2OD0jH0ZkZQKoL7k4Tm41m2LVrXLMQzGCSDi8rfc5 cAxO6fs71HJA6LaAIG8BJ7+at01DmxQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Henrik Grimler To: Krzysztof Kozlowski Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, jenneron@protonmail.com, markuss.broks@gmail.com, martin.juecker@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v2 1/2] ARM: dts: exynos: drop mshc aliases Message-ID: References: <20230128133151.29471-1-henrik@grimler.se> <20230128133151.29471-2-henrik@grimler.se> <29d63a50-bdfe-ef50-c173-cb9e37923758@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29d63a50-bdfe-ef50-c173-cb9e37923758@linaro.org> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org Hi Krzysztof, Thanks for reviewing! On Thu, Feb 09, 2023 at 03:39:37PM +0100, Krzysztof Kozlowski wrote: > On 28/01/2023 14:31, Henrik Grimler wrote: > > They are no longer needed after commit a13e8ef6008d ("mmc: dw_mmc: > > exynos: use common_caps"). > > > > Are you sure? That commit explicitly says that the caps should be set > from DT and Exynos DT does not set it everywhere... > > plus if alias is missing, then the ctrl_id in dw_mmc.c is 0 and such > caps are applied everywhere - to every DWMMC device. Yeah, you are right, David pointed this out in the ARM64 patchset [1] as well, so I will look it over again and send new versions (when discussion on this version is finalised). > Best regards, > Krzysztof [1] https://patchwork.kernel.org/project/linux-samsung-soc/patch/20230203204000.14410-2-henrik@grimler.se/#25197132 Best regards, Henrik Grimler From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C784C61DA4 for ; Thu, 9 Feb 2023 14:57:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rmDvOsUooMUeZgfjXYPKgVknAkk4/GSLUIWbx1TB33s=; b=KlyuggU57cTvIK uH7mZkICdSDXwft67NBJ6lM7JlAL0v67qOjC9WJZcOhqAoAKNl6rZ0JjmdPq/K4+RRK4uiQhr7gvS Vsfzgm8Yj3dNQBw61BFPYNCni05ox7mwzr3M1UfU98aymglYKVaNEBQdflCmh1ftjiapV4LVRTZSt RLKgQTcM/h0eosmE5DTwIPLlFLKvuFeQ2nmk9oLi6kY23HFAFC3HZq11Z9Rp2KLSmPyUSFDqm2hTa FWtUdd9WDHzDRIw5NPx3va3ew7LjIGRu9TWs5WDNJYLoUELwiLX50fZraldtK8WNvW254orFJtLv0 cRymRWOa1Ca/Dh1HPt3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQ8MC-0025MT-2s; Thu, 09 Feb 2023 14:57:04 +0000 Received: from out-84.mta1.migadu.com ([2001:41d0:203:375::54]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQ8M7-0025KY-Sj for linux-arm-kernel@lists.infradead.org; Thu, 09 Feb 2023 14:57:02 +0000 Date: Thu, 9 Feb 2023 15:56:53 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=grimler.se; s=key1; t=1675954615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7pQICwV9BQwh0rqup+XjsiIjDhBDv4jvmO4frgTOT8w=; b=c58lg+63q4bbXysaBaqmipgYlFzuAHV1ucjwoMv2dNxMtO1TEBtlDAJE2DWALUgq46AcHo qmzzS74d7ZmXVTvjG9qeM+kNiyuCo2OD0jH0ZkZQKoL7k4Tm41m2LVrXLMQzGCSDi8rfc5 cAxO6fs71HJA6LaAIG8BJ7+at01DmxQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Henrik Grimler To: Krzysztof Kozlowski Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, jenneron@protonmail.com, markuss.broks@gmail.com, martin.juecker@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v2 1/2] ARM: dts: exynos: drop mshc aliases Message-ID: References: <20230128133151.29471-1-henrik@grimler.se> <20230128133151.29471-2-henrik@grimler.se> <29d63a50-bdfe-ef50-c173-cb9e37923758@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <29d63a50-bdfe-ef50-c173-cb9e37923758@linaro.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230209_065700_612178_7B9CB9FC X-CRM114-Status: GOOD ( 12.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Thanks for reviewing! On Thu, Feb 09, 2023 at 03:39:37PM +0100, Krzysztof Kozlowski wrote: > On 28/01/2023 14:31, Henrik Grimler wrote: > > They are no longer needed after commit a13e8ef6008d ("mmc: dw_mmc: > > exynos: use common_caps"). > > > > Are you sure? That commit explicitly says that the caps should be set > from DT and Exynos DT does not set it everywhere... > > plus if alias is missing, then the ctrl_id in dw_mmc.c is 0 and such > caps are applied everywhere - to every DWMMC device. Yeah, you are right, David pointed this out in the ARM64 patchset [1] as well, so I will look it over again and send new versions (when discussion on this version is finalised). > Best regards, > Krzysztof [1] https://patchwork.kernel.org/project/linux-samsung-soc/patch/20230203204000.14410-2-henrik@grimler.se/#25197132 Best regards, Henrik Grimler _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel