From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C994C636CD for ; Fri, 10 Feb 2023 10:38:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232075AbjBJKis (ORCPT ); Fri, 10 Feb 2023 05:38:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231935AbjBJKir (ORCPT ); Fri, 10 Feb 2023 05:38:47 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4B9B173E; Fri, 10 Feb 2023 02:38:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4CE8861D62; Fri, 10 Feb 2023 10:38:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17A54C433D2; Fri, 10 Feb 2023 10:38:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1676025525; bh=6tn5sYUfcKRQPPvhKNh4pyzZJ6r3nQvdlm1gZGvGnHQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ikem2CG4I18LkpaZ0OREA9uosnBJogirtUIGiF8TCS9Xsd6v7mRLQ0OrEfpbGVCWi h9sxf3/5UJ0Uef6ixExyO/D/Rj3DsZFTyjzVjh+wGnOXptHSjNACN+3TJ2PFubw/0/ LZzQT1dAYNqSe37MJH1qIjUVH08YsDVQRJJM4cPg= Date: Fri, 10 Feb 2023 11:38:37 +0100 From: Greg Kroah-Hartman To: Neil Armstrong Cc: Heikki Krogerus , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/7] usb: typec: ucsi: add PMIC Glink UCSI driver Message-ID: References: <20230130-topic-sm8450-upstream-pmic-glink-v1-0-0b0acfad301e@linaro.org> <20230130-topic-sm8450-upstream-pmic-glink-v1-1-0b0acfad301e@linaro.org> <720aee1d-87e8-5291-c6a0-ef53e830a21d@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <720aee1d-87e8-5291-c6a0-ef53e830a21d@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Feb 10, 2023 at 11:31:08AM +0100, Neil Armstrong wrote: > On 31/01/2023 10:16, Greg Kroah-Hartman wrote: > > On Mon, Jan 30, 2023 at 10:54:32AM +0100, Neil Armstrong wrote: > > > Introduce the UCSI PMIC Glink aux driver that communicates > > > with the aDSP firmware with the UCSI protocol which handles > > > the USB-C Port(s) Power Delivery. > > > > > > The UCSI messaging is necessary on newer Qualcomm SoCs to > > > provide USB role switch and altmode notifications. > > > > > > Signed-off-by: Neil Armstrong > > > --- > > > drivers/usb/typec/ucsi/Kconfig | 7 + > > > drivers/usb/typec/ucsi/Makefile | 1 + > > > drivers/usb/typec/ucsi/ucsi_glink.c | 321 ++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 329 insertions(+) > > > > > > diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig > > > index 8f9c4b9f31f7..dee6069e46a2 100644 > > > --- a/drivers/usb/typec/ucsi/Kconfig > > > +++ b/drivers/usb/typec/ucsi/Kconfig > > > @@ -58,4 +58,11 @@ config UCSI_STM32G0 > > > To compile the driver as a module, choose M here: the module will be > > > called ucsi_stm32g0. > > > +config UCSI_PMIC_GLINK > > > + tristate "UCSI Qualcomm PMIC GLINK Interface Driver" > > > + depends on QCOM_PMIC_GLINK > > > > No way to test build this code without this option? > > Nop, the QCOM_PMIC_GLINK is a build dependency, this can't be removed Then perhaps the QCOM_PMIC_GLINK code needs to be fixed up to allow for it to be built on all platforms properly? Otherwise you are guaranteeing you will not get much, if any, build coverage and api changes will cause this code to stagnate over time :( thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90D35C636CD for ; Fri, 10 Feb 2023 10:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hAKPoZYo/EURzijL3+6JNYPOVQTjDT/aRi6WKFSbFnY=; b=EW4/N/glgwiUA6 oghmcAg/Ushya9d9Hs5Rjv/37cCXccVemShfNcejERt1EKY1RSRrXzl/beXAQvFYMqqPZ0HEuN6Aj LJla++HkykgNPzrjTtJCSLAH7lenWhBcmp0WHHGVsLM1PDxQ1mlovf1I2nMyukuTE6Z6wcxEW3cnm jaQziI1r71bNeo177HHp1iZZNRPMMWBg0VZEHJtX6DmIP0CaTLacITTbvY8UmQvVAiwowRUf8qcUh rnZgIvjzWvJyhcvc/rdklK/pWVleXBW/QDi9S9gz9LEM8+XQaegrunfnKrg1xP7HLdqN5C3jVRx/+ ny9IfcfUhesXpq1c0FKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQQns-005Jrk-2o; Fri, 10 Feb 2023 10:38:52 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQQno-005Jpw-81 for linux-arm-kernel@lists.infradead.org; Fri, 10 Feb 2023 10:38:49 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4A4EB61D39; Fri, 10 Feb 2023 10:38:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17A54C433D2; Fri, 10 Feb 2023 10:38:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1676025525; bh=6tn5sYUfcKRQPPvhKNh4pyzZJ6r3nQvdlm1gZGvGnHQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ikem2CG4I18LkpaZ0OREA9uosnBJogirtUIGiF8TCS9Xsd6v7mRLQ0OrEfpbGVCWi h9sxf3/5UJ0Uef6ixExyO/D/Rj3DsZFTyjzVjh+wGnOXptHSjNACN+3TJ2PFubw/0/ LZzQT1dAYNqSe37MJH1qIjUVH08YsDVQRJJM4cPg= Date: Fri, 10 Feb 2023 11:38:37 +0100 From: Greg Kroah-Hartman To: Neil Armstrong Cc: Heikki Krogerus , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/7] usb: typec: ucsi: add PMIC Glink UCSI driver Message-ID: References: <20230130-topic-sm8450-upstream-pmic-glink-v1-0-0b0acfad301e@linaro.org> <20230130-topic-sm8450-upstream-pmic-glink-v1-1-0b0acfad301e@linaro.org> <720aee1d-87e8-5291-c6a0-ef53e830a21d@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <720aee1d-87e8-5291-c6a0-ef53e830a21d@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230210_023848_361844_A676A4A6 X-CRM114-Status: GOOD ( 21.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 10, 2023 at 11:31:08AM +0100, Neil Armstrong wrote: > On 31/01/2023 10:16, Greg Kroah-Hartman wrote: > > On Mon, Jan 30, 2023 at 10:54:32AM +0100, Neil Armstrong wrote: > > > Introduce the UCSI PMIC Glink aux driver that communicates > > > with the aDSP firmware with the UCSI protocol which handles > > > the USB-C Port(s) Power Delivery. > > > > > > The UCSI messaging is necessary on newer Qualcomm SoCs to > > > provide USB role switch and altmode notifications. > > > > > > Signed-off-by: Neil Armstrong > > > --- > > > drivers/usb/typec/ucsi/Kconfig | 7 + > > > drivers/usb/typec/ucsi/Makefile | 1 + > > > drivers/usb/typec/ucsi/ucsi_glink.c | 321 ++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 329 insertions(+) > > > > > > diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig > > > index 8f9c4b9f31f7..dee6069e46a2 100644 > > > --- a/drivers/usb/typec/ucsi/Kconfig > > > +++ b/drivers/usb/typec/ucsi/Kconfig > > > @@ -58,4 +58,11 @@ config UCSI_STM32G0 > > > To compile the driver as a module, choose M here: the module will be > > > called ucsi_stm32g0. > > > +config UCSI_PMIC_GLINK > > > + tristate "UCSI Qualcomm PMIC GLINK Interface Driver" > > > + depends on QCOM_PMIC_GLINK > > > > No way to test build this code without this option? > > Nop, the QCOM_PMIC_GLINK is a build dependency, this can't be removed Then perhaps the QCOM_PMIC_GLINK code needs to be fixed up to allow for it to be built on all platforms properly? Otherwise you are guaranteeing you will not get much, if any, build coverage and api changes will cause this code to stagnate over time :( thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel