From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F00EC43219 for ; Mon, 17 Oct 2022 19:34:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230338AbiJQTeO (ORCPT ); Mon, 17 Oct 2022 15:34:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbiJQTeK (ORCPT ); Mon, 17 Oct 2022 15:34:10 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98F0813F1A; Mon, 17 Oct 2022 12:34:07 -0700 (PDT) Received: from zn.tnic (p200300ea9733e793329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e793:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DD66C1EC0531; Mon, 17 Oct 2022 21:34:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1666035242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=A+SmiBJtXQInyL9q8CMvvRTfqz11s9Su0HRnFCAP13s=; b=As/Dl4Uqbukr/M8bYV5G+unu8ttU5HPzu1In68Ztxl6Xsux90JCWMYQsLahcd1FdbGFV38 D457tUet2dDGlD4SvgQY8lPX5ya4SRNatFxvU2pw8T5B3x+QKVpHPGNeuHWKHoLD/dz30m Emtw31b/EA0Y9iAHG7aqgozUYBp1Nz4= Date: Mon, 17 Oct 2022 21:33:56 +0200 From: Borislav Petkov To: "Edgecombe, Rick P" Cc: "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "Yu, Yu-cheng" , "dave.hansen@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "Eranian, Stephane" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "linux-arch@vger.kernel.org" , "kcc@google.com" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "linux-doc@vger.kernel.org" , "Lutomirski, Andy" , "arnd@arndb.de" , "jamorris@linux.microsoft.com" , "Moreira, Joao" , "tglx@linutronix.de" , "mike.kravetz@oracle.com" , "x86@kernel.org" , "Yang, Weijiang" , "john.allen@amd.com" , "rppt@kernel.org" , "mingo@redhat.com" , "Shankar, Ravi V" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" Subject: Re: [PATCH v2 05/39] x86/fpu/xstate: Introduce CET MSR and XSAVES supervisor states Message-ID: References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-6-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 17, 2022 at 06:57:13PM +0000, Edgecombe, Rick P wrote: > Hmm yea. Another reason the actual define is passed in is that the > macro want's to stringify the XFEATURE define in order to generate the > message like this: > XFEATURE_YMM: struct is 123 bytes, cpu state is 456 bytes > > The exact format of the message is probably not too critical though. If > instead it used xfeature_names[], it could be: > [AVX registers]: struct is 123 bytes, cpu state is 456 bytes Bah, "registers", that made me look at the thing. Yeah, not sure if all those "registers" strings even matter there. [AVX]: struct is 123 bytes, cpu state is 456 bytes looks good enough to me too. But WTH do I know. > The full block looks like (like you had): > switch (nr) { > case XFEATURE_YMM: return XCHECK_SZ(sz, nr, struct ymmh_struct); > case XFEATURE_BNDREGS: return XCHECK_SZ(sz, nr, struct > mpx_bndreg_state); > case XFEATURE_BNDCSR: return XCHECK_SZ(sz, nr, struct > mpx_bndcsr_state); > case XFEATURE_OPMASK: return XCHECK_SZ(sz, nr, struct > avx_512_opmask_state); > case XFEATURE_ZMM_Hi256: return XCHECK_SZ(sz, nr, struct > avx_512_zmm_uppers_state); > case XFEATURE_Hi16_ZMM: return XCHECK_SZ(sz, nr, struct > avx_512_hi16_state); > case XFEATURE_PKRU: return XCHECK_SZ(sz, nr, struct pkru_state); > case XFEATURE_PASID: return XCHECK_SZ(sz, nr, struct > ia32_pasid_state); > case XFEATURE_XTILE_CFG: return XCHECK_SZ(sz, nr, struct xtile_cfg); > case XFEATURE_CET_USER: return XCHECK_SZ(sz, nr, struct > cet_user_state); > case XFEATURE_XTILE_DATA: check_xtile_data_against_struct(sz); return > true; > default: > WARN_ONCE(1, "no structure for xstate: %d\n", nr); > XSTATE_WARN_ON(1); > return false; > } > > I like how it fits the XFEATURE_XTILE_DATA check in with the rest. Yap, nice and straight-forward pattern. :) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette