From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18DB1C4332F for ; Thu, 13 Oct 2022 20:12:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229744AbiJMUMQ (ORCPT ); Thu, 13 Oct 2022 16:12:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229711AbiJMUMO (ORCPT ); Thu, 13 Oct 2022 16:12:14 -0400 Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 870CE18DAB9 for ; Thu, 13 Oct 2022 13:12:10 -0700 (PDT) Received: by mail-il1-x134.google.com with SMTP id u10so1546728ilm.5 for ; Thu, 13 Oct 2022 13:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/qDA9dxlzE7pWwjwZW2GWOEPMtytWByBuV6pjMIJqdE=; b=jsbaHm65Xt0xgPM9PgMJG2qhH1KgPdQLabBM+D1THOpDdGrqwNrjCiQLSuJvPRahLf llY/vKuf/8UcXZ7jb2z8oknkCEsTXaDfyXTFHCqLCjfocNJzUK8zCx1VaTI6EeYGx7GW B+vEEndYwGQ8UeYopAm6OlFiGbXHrFbaZ4Sso= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/qDA9dxlzE7pWwjwZW2GWOEPMtytWByBuV6pjMIJqdE=; b=gCQ/mG9mFH6ojg6UoNJquYpJ5AfHFe+nR5ifNVbUxjGs4gWHn7ErTiD48lHiazwtRf +5yD5XslOYsAtytkwHKYDU2KDwWxYQZ/DQpW/goKCXIqqZorCsOfphRfO9woAyyhfige 3T2frvo/8m8FOq9fwU3OlEyB3sItZXsc4w6i/iWXT9AO6Jl8bNp/FAsBWDwJ/vQLHwB7 sOOpYNdeoYl/lrN9VdhQUDsIJ/FEI+FXT5TkmJ5Kj0854udH1iD/TARZ0oe/OKL7leSI xs+e3GRXkNHlfL18g5P7LiySWT/Vys6DBIMUUdgDs+va94QInbn4gExs7oPFPGagEmaN DqOA== X-Gm-Message-State: ACrzQf1hJdyWiRPObTERTiXI1im8UzAMqGnfeKqAiHnjDSYtDnO6eXOK To4Xq5lqVjOUnuDkjj1nlb8auA== X-Google-Smtp-Source: AMsMyM7yQFZbRiNOSXnUVBtX+UaHs1LZQ0tZzg0WgWqpW8/k7tHJsU6ZdgY0GSztYNWzVMdYiNuOiA== X-Received: by 2002:a05:6e02:144f:b0:2fa:7ede:ece9 with SMTP id p15-20020a056e02144f00b002fa7edeece9mr859240ilo.106.1665691929716; Thu, 13 Oct 2022 13:12:09 -0700 (PDT) Received: from localhost (30.23.70.34.bc.googleusercontent.com. [34.70.23.30]) by smtp.gmail.com with UTF8SMTPSA id y25-20020a056638229900b003637fc54f79sm321612jas.59.2022.10.13.13.12.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Oct 2022 13:12:09 -0700 (PDT) Date: Thu, 13 Oct 2022 20:12:08 +0000 From: "mka@chromium.org" To: Luiz Augusto von Dentz Cc: "Balakrishna Godavarthi (QUIC)" , Miao-chen Chou , Marcel Holtmann , Andy Gross , "robh+dt@kernel.org" , "bjorn.andersson@linaro.org" , "linux-arm-msm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Johan Hedberg , "linux-bluetooth@vger.kernel.org" , "Hemant Gupta (QUIC)" , "Sai Teja Aluvala (Temp) (QUIC)" , "Rocky Liao (QUIC)" , Alain Michaud , Abhishek Pandit-Subedi , Zhengping Jiang Subject: Re: [PATCH v1 3/3] Bluetooth: hci_qca: WAR to handle WCN6750 HW issue Message-ID: References: <1651228073-1999-1-git-send-email-quic_bgodavar@quicinc.com> <1651228073-1999-4-git-send-email-quic_bgodavar@quicinc.com> <0D3D8346-0F64-4CAF-8BED-940F189A3E97@holtmann.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Oct 13, 2022 at 01:06:41PM -0700, Luiz Augusto von Dentz wrote: > Hi, > > On Thu, Oct 13, 2022 at 12:29 PM mka@chromium.org wrote: > > > > On Wed, Jun 22, 2022 at 07:27:21AM +0000, Balakrishna Godavarthi (QUIC) wrote: > > > Hi Marcel/Miao, > > > > > > We are working on new driver, by 7/29 we will submit initial patch for review. > > > > Has this ever been sent? I skimmed through the list archives and couldn't find it. > > If you are asking if it was applied, not it wasn't, it probably needs > to be resend since we were expecting a follow up on the set. Sorry, if I wasn't clear, my question was about the new serdev based driver which was supposed to be posted by 7/29. > > > -----Original Message----- > > > From: Miao-chen Chou > > > Sent: Tuesday, May 10, 2022 8:47 AM > > > To: Balakrishna Godavarthi (QUIC) > > > Cc: Marcel Holtmann ; Andy Gross ; robh+dt@kernel.org; bjorn.andersson@linaro.org; linux-arm-msm@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Johan Hedberg ; mka@chromium.org; linux-bluetooth@vger.kernel.org; Hemant Gupta (QUIC) ; Sai Teja Aluvala (Temp) (QUIC) ; quic_rjliao ; Alain Michaud ; Abhishek Pandit-Subedi > > > Subject: Re: [PATCH v1 3/3] Bluetooth: hci_qca: WAR to handle WCN6750 HW issue > > > > > > Hi Bala, > > > > > > When is the estimated start date and timeline of the driver development? > > > > > > Thanks, > > > Miao > > > > > > On Fri, Apr 29, 2022 at 8:09 PM Balakrishna Godavarthi (QUIC) wrote: > > > > > > > > Hi Marcel, > > > > > > > > -----Original Message----- > > > > From: Marcel Holtmann > > > > Sent: Friday, April 29, 2022 8:24 PM > > > > To: Balakrishna Godavarthi (QUIC) > > > > Cc: Andy Gross ; robh+dt@kernel.org; > > > > bjorn.andersson@linaro.org; linux-arm-msm@vger.kernel.org; > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Johan > > > > Hedberg ; mka@chromium.org; > > > > linux-bluetooth@vger.kernel.org; Hemant Gupta (QUIC) > > > > ; Sai Teja Aluvala (Temp) (QUIC) > > > > ; quic_rjliao ; > > > > mcchou@chromium.org > > > > Subject: Re: [PATCH v1 3/3] Bluetooth: hci_qca: WAR to handle WCN6750 > > > > HW issue > > > > > > > > Hi Balakrishna, > > > > > > > > > The patch is workaround for hardware issue on WCN6750. > > > > > On WCN6750 sometimes observed AON power source takes 100ms time to > > > > > fully discharge voltage during OFF. As WCN6750 is combo chip for > > > > > WLAN and BT. If any of the tech area ON is triggered during > > > > > discharge phase, it fails to turn ON. > > > > > To overcome this hardware issue, During BT ON, driver check for > > > > > WLAN_EN pin status. If it high, it will pull BT_EN to high > > > > > immediately else it will wait for 100ms assuming WLAN was just > > > > > powered OFF and then BT_EN will be pulled to high. > > > > > > > > > > Fixes: d8f97da1b92d2 ("Bluetooth: hci_qca: Add support for QTI > > > > > Bluetooth chip wcn6750") > > > > > Reviewed-by: Miao-chen Chou > > > > > Signed-off-by: Sai Teja Aluvala > > > > > Signed-off-by: Balakrishna Godavarthi > > > > > --- > > > > > drivers/bluetooth/hci_qca.c | 30 ++++++++++++++++++++++++------ > > > > > 1 file changed, 24 insertions(+), 6 deletions(-) > > > > > > > > > > diff --git a/drivers/bluetooth/hci_qca.c > > > > > b/drivers/bluetooth/hci_qca.c index eab34e2..c3862d1 100644 > > > > > --- a/drivers/bluetooth/hci_qca.c > > > > > +++ b/drivers/bluetooth/hci_qca.c > > > > > @@ -219,6 +219,7 @@ struct qca_serdev { > > > > > struct hci_uart serdev_hu; > > > > > struct gpio_desc *bt_en; > > > > > struct gpio_desc *sw_ctrl; > > > > > + struct gpio_desc *wlan_en; > > > > > struct clk *susclk; > > > > > enum qca_btsoc_type btsoc_type; > > > > > struct qca_power *bt_power; > > > > > > > > I am really against these intermixing of Bluetooth and WiFi details. There is work ongoing to do some sequence power procedure. Maybe that is something you should look into. This is a mess. > > > > > > > > And again, we are still hacking around hci_qca.c instead of writing a clean serdev only driver for this hardware. I have the feeling that nobody listens to review comments these days. It is just hacking patches together to get hardware enabled somehow and then disappear. > > > > > > > > [Bala]: We are working on serdev like driver for our QCA platform. We are in initial stages of discussion, and soon we will start the driver development work. > > > > In mean to stop stability or functional issues we are trying to add these HACKs in QCA driver. > > > > > > > > Regards > > > > > > > > Marcel > > > > > > > > -- > Luiz Augusto von Dentz