From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C30357E; Mon, 31 Oct 2022 14:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667227551; bh=F7/jUVASJHFdFrib2qiFCrAoDx3j0XxPPYgG1AbgNR4=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=bV3JJgsu14hA7EAeUOslFLEl5VDNVbvrXQWBrehz5fziUiV/pA5r53roxk4F4pze8 nEV9A5wF0mbA3wNk6KNitu9ecRDKbITWqGSNhBoIKWZWRine5QqL0ehsbIR9nv+7L6 BWHRO5dGDVCIz45TEs6oMTGujocN196LXK5keb5A= Received: by b-3.in.mailobj.net [192.168.90.13] with ESMTP via [213.182.55.206] Mon, 31 Oct 2022 15:45:51 +0100 (CET) X-EA-Auth: 6XfSXNO20IQJl9fhQUCf1G+bp7BY2kb6am+RAmSXTh5tu9X2ORcRGUnf+30EMF8X96Pg0x/BStdiBjjZ2egP+0gDc3tLiq9N Date: Mon, 31 Oct 2022 20:15:51 +0530 From: Deepak R Varma To: Greg Kroah-Hartman Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: rtl8192u: remove unused macro definition Message-ID: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Oct 28, 2022 at 01:03:36AM +0530, Deepak Varma wrote: > On Wed, Oct 26, 2022 at 03:55:01PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Oct 26, 2022 at 07:14:43PM +0530, Deepak R Varma wrote: > > > On Wed, Oct 26, 2022 at 03:14:23PM +0200, Greg Kroah-Hartman wrote: > > > > On Wed, Oct 26, 2022 at 08:58:44AM +0530, Deepak R Varma wrote: > > > > > Pre-processor macros that are defined but are never used should be > > > > > cleaned up to avoid unexpected usage. > > > > > > > > > > Signed-off-by: Deepak R Varma > > > > > --- > > > > > drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 -- > > > > > 1 file changed, 2 deletions(-) > > > > > > > > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > > > > > index 00c07455cbb3..0b3dda59d7c0 100644 > > > > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h > > > > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > > > > > @@ -230,8 +230,6 @@ struct cb_desc { > > > > > #define ieee80211_unregister_crypto_ops ieee80211_unregister_crypto_ops_rsl > > > > > #define ieee80211_get_crypto_ops ieee80211_get_crypto_ops_rsl > > > > > > > > > > -#define ieee80211_ccmp_null ieee80211_ccmp_null_rsl > > > > > - > > > > > #define free_ieee80211 free_ieee80211_rsl > > > > > #define alloc_ieee80211 alloc_ieee80211_rsl > > > > > > > > These #defines are a mess, please look into unwinding them as they > > > > should not be needed at all. > > > > > > Hello Greg, > > > I would like to know what you mean by "unwind them". Is there a documentation or past > > > commit that I can review to understand the expectations better? > > > > Look at them and try to figure out why they are there, and then work to > > remove them entirely. A define like this is very odd in the kernel, it > > should not be needed at all, right? > > Hello Greg, > I will look into these additional macros soon and send any further edits as a > separate patch (set). Is the current patch set with 2 patches acceptable? > > Also, I am trying to get Coccinelle to work on my machine. Trying to work > through strange issues. I will work on the macro unwinding task you suggested > once a get the Coccinelle task completed. Hello Greg, Most of these macro defines appear to be unused in the module anywhere. I can simply delete the #defines for these and let the original function names be retained. The other way is to rename the functions by the defined value. So, we will have to make the code change to use the foo_rsl symbol names at all places. This will be a bigger change involving the API name change itself. I am unable to determine the initial intention as to why these #defines were added. Can you please suggest what would be the recommended way for the clean up of these unused macros? Thank you, ./drv > > Thank you, > ./drv > > > > > thanks, > > > > greg k-h > > > > >