From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E85FC433FE for ; Wed, 19 Oct 2022 16:38:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229732AbiJSQip (ORCPT ); Wed, 19 Oct 2022 12:38:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229649AbiJSQio (ORCPT ); Wed, 19 Oct 2022 12:38:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A57C107CEC; Wed, 19 Oct 2022 09:38:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0987BB8254E; Wed, 19 Oct 2022 16:38:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2530C433D6; Wed, 19 Oct 2022 16:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666197520; bh=hWAN4W/Rzw9KgPVsCE2gQRgnd0phSSxJxzE7lCGoioY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TawPkvlnwajRtpZUccEz/raJqSSEkR5n6viMazNe8WRK1EZffnexS4T5CIdsvoAEe x/5VQl89yoYkabEm8Mk+WJ+G5KE1F0WbZegeR9hsITqEVDpbW9rUvneSWhuIu1I7ac ULGMrHZZuWC8r8j383T1XKANGZAux+MS4ukBcLbQTETqdZG4RuPHw9T1LlQxpniLQk /Ur7U4WJCqC3agt1DVCKpCudcMPrTZKqR91AGl/bfluP6I4Ygl0Ao1jShKfB61+nR+ K//B1z0ST1JoSA87k+xhjwl2azEl5XiFv5+BmlBBP2eH7RXegD34d3PWdIDdJFgBfh v5LwsnJpcfcgA== Date: Wed, 19 Oct 2022 22:08:36 +0530 From: Vinod Koul To: Tudor Ambarus Cc: peda@axentia.se, du@axentia.se, regressions@leemhuis.info, ludovic.desroches@microchip.com, maciej.sosnowski@intel.com, dan.j.williams@intel.com, nicolas.ferre@microchip.com, mripard@kernel.org, torfl6749@gmail.com, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tudor Ambarus , stable@vger.kernel.org Subject: Re: [PATCH 07/33] dmaengine: at_hdmac: Fix at_lli struct definition Message-ID: References: <20220820125717.588722-1-tudor.ambarus@microchip.com> <20220820125717.588722-8-tudor.ambarus@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220820125717.588722-8-tudor.ambarus@microchip.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 20-08-22, 15:56, Tudor Ambarus wrote: > From: Tudor Ambarus > > Those hardware registers are all of 32 bits, while dma_addr_t ca be of > type u64 or u32 depending on CONFIG_ARCH_DMA_ADDR_T_64BIT. Force u32 to > comply with what the hardware expects. > > Fixes: dc78baa2b90b ("dmaengine: at_hdmac: new driver for the Atmel AHB DMA Controller") > Signed-off-by: Tudor Ambarus > Cc: stable@vger.kernel.org Okay > --- > drivers/dma/at_hdmac.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c > index 91e53a590d5f..e89facf14fab 100644 > --- a/drivers/dma/at_hdmac.c > +++ b/drivers/dma/at_hdmac.c > @@ -187,13 +187,13 @@ > /* LLI == Linked List Item; aka DMA buffer descriptor */ > struct at_lli { > /* values that are not changed by hardware */ > - dma_addr_t saddr; > - dma_addr_t daddr; > + u32 saddr; > + u32 daddr; I think you should add fixes first in the series and then do header move, that way we can backport this and other fixes to stable kernels... > /* value that may get written back: */ > - u32 ctrla; > + u32 ctrla; > /* more values that are not changed by hardware */ > - u32 ctrlb; > - dma_addr_t dscr; /* chain to next lli */ > + u32 ctrlb; > + u32 dscr; /* chain to next lli */ > }; > > /** > -- > 2.25.1 -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B4E7C433FE for ; Wed, 19 Oct 2022 16:39:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oOoS8EmLZGQo3jSPLG7GXUSD+ws63jMld+P/QfyNp1E=; b=MtLipVn6/qhZRe v0VgdIOjZq7lmrUQgZsyLNBP3zY/2gcM1/0G44wOxfxT/3S5JF9JGVRbmTpxS/2t7X15SKhDsilMZ EtCilhbHW9PLOSF4Vcij4kAuDFWfzTAKGmMkLsNKznu7OtR0r2sLSQXQYA3d0uKrM8/AvXl1QUZs8 WlU7zLCx+ZzCc/AeWQEj/lqeQ9QeVAfY5rynTKFBYoED0oAyjrwz8wUUyHwDUXl4500EcaHCtotgh e2Qr9w79oei6yyyZfL2xW5Jew7gz4JsVAsmnUFgDrxuQwuWj59pRhl3uN/bI8l/ijUzWQh1KL1QAW INMU4YkdLUQzzr0UidQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olC5d-004MXR-5R; Wed, 19 Oct 2022 16:38:45 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olC5a-004MMh-2x for linux-arm-kernel@lists.infradead.org; Wed, 19 Oct 2022 16:38:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4F9DE6195C; Wed, 19 Oct 2022 16:38:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2530C433D6; Wed, 19 Oct 2022 16:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666197520; bh=hWAN4W/Rzw9KgPVsCE2gQRgnd0phSSxJxzE7lCGoioY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TawPkvlnwajRtpZUccEz/raJqSSEkR5n6viMazNe8WRK1EZffnexS4T5CIdsvoAEe x/5VQl89yoYkabEm8Mk+WJ+G5KE1F0WbZegeR9hsITqEVDpbW9rUvneSWhuIu1I7ac ULGMrHZZuWC8r8j383T1XKANGZAux+MS4ukBcLbQTETqdZG4RuPHw9T1LlQxpniLQk /Ur7U4WJCqC3agt1DVCKpCudcMPrTZKqR91AGl/bfluP6I4Ygl0Ao1jShKfB61+nR+ K//B1z0ST1JoSA87k+xhjwl2azEl5XiFv5+BmlBBP2eH7RXegD34d3PWdIDdJFgBfh v5LwsnJpcfcgA== Date: Wed, 19 Oct 2022 22:08:36 +0530 From: Vinod Koul To: Tudor Ambarus Subject: Re: [PATCH 07/33] dmaengine: at_hdmac: Fix at_lli struct definition Message-ID: References: <20220820125717.588722-1-tudor.ambarus@microchip.com> <20220820125717.588722-8-tudor.ambarus@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220820125717.588722-8-tudor.ambarus@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221019_093842_213251_58A5E8FE X-CRM114-Status: GOOD ( 19.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tudor Ambarus , linux-kernel@vger.kernel.org, maciej.sosnowski@intel.com, mripard@kernel.org, torfl6749@gmail.com, du@axentia.se, ludovic.desroches@microchip.com, regressions@leemhuis.info, stable@vger.kernel.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com, peda@axentia.se, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20-08-22, 15:56, Tudor Ambarus wrote: > From: Tudor Ambarus > > Those hardware registers are all of 32 bits, while dma_addr_t ca be of > type u64 or u32 depending on CONFIG_ARCH_DMA_ADDR_T_64BIT. Force u32 to > comply with what the hardware expects. > > Fixes: dc78baa2b90b ("dmaengine: at_hdmac: new driver for the Atmel AHB DMA Controller") > Signed-off-by: Tudor Ambarus > Cc: stable@vger.kernel.org Okay > --- > drivers/dma/at_hdmac.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c > index 91e53a590d5f..e89facf14fab 100644 > --- a/drivers/dma/at_hdmac.c > +++ b/drivers/dma/at_hdmac.c > @@ -187,13 +187,13 @@ > /* LLI == Linked List Item; aka DMA buffer descriptor */ > struct at_lli { > /* values that are not changed by hardware */ > - dma_addr_t saddr; > - dma_addr_t daddr; > + u32 saddr; > + u32 daddr; I think you should add fixes first in the series and then do header move, that way we can backport this and other fixes to stable kernels... > /* value that may get written back: */ > - u32 ctrla; > + u32 ctrla; > /* more values that are not changed by hardware */ > - u32 ctrlb; > - dma_addr_t dscr; /* chain to next lli */ > + u32 ctrlb; > + u32 dscr; /* chain to next lli */ > }; > > /** > -- > 2.25.1 -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel