From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9433FC4332F for ; Wed, 19 Oct 2022 16:50:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229777AbiJSQuQ (ORCPT ); Wed, 19 Oct 2022 12:50:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbiJSQuO (ORCPT ); Wed, 19 Oct 2022 12:50:14 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAEB5143A6E; Wed, 19 Oct 2022 09:50:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5C95AB824C7; Wed, 19 Oct 2022 16:50:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B5D5C433C1; Wed, 19 Oct 2022 16:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666198210; bh=kcgFf4x+wh7v7BVY6QOlT8b5olyWXNSV4e6UOkRCa/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JncByFxeqpiBF5GhyBvFP3yCDvHQ+aCAEswXMaW/U2W79xSoYNtCy/Fwef7lyKI4d xcn4yFHvJJtxrdMhSqiKfmiiUWdlDzT2Mgr6ZNvhquhpzjrRE5c1J6PNZuSGNH0rqP VDPCEnf1pmjea5IorkIb3jmL+eHEFnBmBhvxhvDW/DvGr9kIP+IzAJKyLPiWeo7Ozs /mqzlc9bQV4SCqUilH0gqimrrslVa3tLbYglzp5xJyEWHahLjYJ+oEKgI7z0YcBGeI z6XCGe3T6uSpEzHtVqxYf3RVb0W9tLOqXpK84T0IomuYHu5Aowm/Xy4TXj4toXX7HX 4Yci8n+FT6m1g== Date: Wed, 19 Oct 2022 22:20:04 +0530 From: Vinod Koul To: Tudor Ambarus Cc: peda@axentia.se, du@axentia.se, regressions@leemhuis.info, ludovic.desroches@microchip.com, maciej.sosnowski@intel.com, dan.j.williams@intel.com, nicolas.ferre@microchip.com, mripard@kernel.org, torfl6749@gmail.com, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tudor Ambarus Subject: Re: [PATCH 31/33] dmaengine: at_hdmac: Use pm_ptr() Message-ID: References: <20220820125717.588722-1-tudor.ambarus@microchip.com> <20220820125717.588722-32-tudor.ambarus@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220820125717.588722-32-tudor.ambarus@microchip.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 20-08-22, 15:57, Tudor Ambarus wrote: > From: Tudor Ambarus > > Use pm_ptr() macro to fill at_xdmac_driver.driver.pm. In case CONFIG_PM is > not enabled, the macro will return NULL. You annotated at_dma_dev_pm_ops with __maybe_unused which is a correct thing to do, but should be explained here > > Signed-off-by: Tudor Ambarus > --- > drivers/dma/at_hdmac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c > index 0b473e6d161d..e35b4b325452 100644 > --- a/drivers/dma/at_hdmac.c > +++ b/drivers/dma/at_hdmac.c > @@ -2524,7 +2524,7 @@ static int at_dma_resume_noirq(struct device *dev) > return 0; > } > > -static const struct dev_pm_ops at_dma_dev_pm_ops = { > +static const struct dev_pm_ops __maybe_unused at_dma_dev_pm_ops = { > .prepare = at_dma_prepare, > .suspend_noirq = at_dma_suspend_noirq, > .resume_noirq = at_dma_resume_noirq, > @@ -2536,7 +2536,7 @@ static struct platform_driver at_dma_driver = { > .id_table = atdma_devtypes, > .driver = { > .name = "at_hdmac", > - .pm = &at_dma_dev_pm_ops, > + .pm = pm_ptr(&at_dma_dev_pm_ops), > .of_match_table = of_match_ptr(atmel_dma_dt_ids), > }, > }; > -- > 2.25.1 -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9ED0EC4332F for ; Wed, 19 Oct 2022 16:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2kCdh4shg9s6QrPGu3nzHX1le8s0/H0H1lerrf2ODm4=; b=VG93dHLOvTJykH awGqTj6P5InrY1ONRKKM8C2Yad7ORWCtQRX1m8SrM3Mp1b+m94sy0oxGgR3yZ0OcznUdgM7guaPMe /0i13rcslLTLP+UJPOwtOCPyJXmgAncMtNgE9MdSbTIIg6VpNOVzJ7KaIkYDCoZpt3ZqhgviM9jG3 6yTDrVWHyekDtmcxsmM6IjtHyggO2s67NY7cEmezv4bN9ziFQz6tIDp90BeFj94bYtlxAVk0TOEzq mES7+dnx40rknQK3Oe4N/08RQRZ94bHHUP/9DdCOWqXl7BGMoyGkT0F6Y+ObXhbludEc+RyCr4H74 HL5wPuw7THftE+D+zlLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olCGk-004RYS-6a; Wed, 19 Oct 2022 16:50:14 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olCGh-004RXu-8a for linux-arm-kernel@lists.infradead.org; Wed, 19 Oct 2022 16:50:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9ED2F6193C; Wed, 19 Oct 2022 16:50:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B5D5C433C1; Wed, 19 Oct 2022 16:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666198210; bh=kcgFf4x+wh7v7BVY6QOlT8b5olyWXNSV4e6UOkRCa/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JncByFxeqpiBF5GhyBvFP3yCDvHQ+aCAEswXMaW/U2W79xSoYNtCy/Fwef7lyKI4d xcn4yFHvJJtxrdMhSqiKfmiiUWdlDzT2Mgr6ZNvhquhpzjrRE5c1J6PNZuSGNH0rqP VDPCEnf1pmjea5IorkIb3jmL+eHEFnBmBhvxhvDW/DvGr9kIP+IzAJKyLPiWeo7Ozs /mqzlc9bQV4SCqUilH0gqimrrslVa3tLbYglzp5xJyEWHahLjYJ+oEKgI7z0YcBGeI z6XCGe3T6uSpEzHtVqxYf3RVb0W9tLOqXpK84T0IomuYHu5Aowm/Xy4TXj4toXX7HX 4Yci8n+FT6m1g== Date: Wed, 19 Oct 2022 22:20:04 +0530 From: Vinod Koul To: Tudor Ambarus Subject: Re: [PATCH 31/33] dmaengine: at_hdmac: Use pm_ptr() Message-ID: References: <20220820125717.588722-1-tudor.ambarus@microchip.com> <20220820125717.588722-32-tudor.ambarus@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220820125717.588722-32-tudor.ambarus@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221019_095011_362273_A0AC8BCE X-CRM114-Status: GOOD ( 20.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tudor Ambarus , linux-kernel@vger.kernel.org, maciej.sosnowski@intel.com, mripard@kernel.org, torfl6749@gmail.com, du@axentia.se, ludovic.desroches@microchip.com, regressions@leemhuis.info, dmaengine@vger.kernel.org, dan.j.williams@intel.com, peda@axentia.se, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20-08-22, 15:57, Tudor Ambarus wrote: > From: Tudor Ambarus > > Use pm_ptr() macro to fill at_xdmac_driver.driver.pm. In case CONFIG_PM is > not enabled, the macro will return NULL. You annotated at_dma_dev_pm_ops with __maybe_unused which is a correct thing to do, but should be explained here > > Signed-off-by: Tudor Ambarus > --- > drivers/dma/at_hdmac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c > index 0b473e6d161d..e35b4b325452 100644 > --- a/drivers/dma/at_hdmac.c > +++ b/drivers/dma/at_hdmac.c > @@ -2524,7 +2524,7 @@ static int at_dma_resume_noirq(struct device *dev) > return 0; > } > > -static const struct dev_pm_ops at_dma_dev_pm_ops = { > +static const struct dev_pm_ops __maybe_unused at_dma_dev_pm_ops = { > .prepare = at_dma_prepare, > .suspend_noirq = at_dma_suspend_noirq, > .resume_noirq = at_dma_resume_noirq, > @@ -2536,7 +2536,7 @@ static struct platform_driver at_dma_driver = { > .id_table = atdma_devtypes, > .driver = { > .name = "at_hdmac", > - .pm = &at_dma_dev_pm_ops, > + .pm = pm_ptr(&at_dma_dev_pm_ops), > .of_match_table = of_match_ptr(atmel_dma_dt_ids), > }, > }; > -- > 2.25.1 -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel