All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Emily Peri <eperi1024@gmail.com>
Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: rtl8723bs: fix white space warnings
Date: Thu, 20 Oct 2022 09:07:33 +0200	[thread overview]
Message-ID: <Y1DztSHmsjFWpXJy@kroah.com> (raw)
In-Reply-To: <Y1DcimyMZwkSDm+C@marshmallow>

On Wed, Oct 19, 2022 at 10:28:42PM -0700, Emily Peri wrote:
> On Thu, Oct 20, 2022 at 06:57:03AM +0200, Greg KH wrote:
> > On Wed, Oct 19, 2022 at 07:10:51PM -0700, Emily Peri wrote:
> > > Fix the following checkpatch warnings in rtw_ioctl_set:
> > > 1) Add missing blankline after declaration
> > > 2) Replace spaces used for indent with tab
> > > 3) Remove space before tab
> > 
> > When you have to list the different things you do, you should really
> > break that up into individual patches.  This should be 3.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Thanks greg for the feedback! I got the idea to put them all in the same
> patch from the PatchPhilosophy guide, which suggested combining a bunch
> of white space corrections into one commit. But, it sounds like I
> misinterpreted what the guide was saying. Maybe if there are identical
> warnings, such as "trailing white space" in the driver code, could those
> corrections go together in a single patch?
> 

Yes, you are correct, you could do a "fix all trailing whitespace in
this file" in one patch.

thanks,

greg k-h

  reply	other threads:[~2022-10-20  7:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20  2:10 [PATCH 0/3] staging: rtl8723bs: clean up driver code in rtw_ioctl_set Emily Peri
2022-10-20  2:10 ` [PATCH 1/3] staging: rtl8723bs: fix white space warnings Emily Peri
2022-10-20  4:04   ` Praveen Kumar
2022-10-20  5:05     ` Emily Peri
2022-10-20  5:59       ` Michael Straube
2022-10-20  4:57   ` Greg KH
2022-10-20  5:28     ` Emily Peri
2022-10-20  7:07       ` Greg KH [this message]
2022-10-20  2:10 ` [PATCH 2/3] staging: rtl8723bs: align block comment stars Emily Peri
2022-10-20  2:10 ` [PATCH 3/3] staging: rtl8723bs: remove unnecessary parenthesis Emily Peri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1DztSHmsjFWpXJy@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=eperi1024@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.