From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A2DAC433FE for ; Thu, 20 Oct 2022 09:00:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229891AbiJTJAB (ORCPT ); Thu, 20 Oct 2022 05:00:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229861AbiJTJAA (ORCPT ); Thu, 20 Oct 2022 05:00:00 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8413B40E09; Thu, 20 Oct 2022 01:59:58 -0700 (PDT) Received: from zn.tnic (p200300ea9733e710329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e710:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 113011EC072D; Thu, 20 Oct 2022 10:59:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1666256393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Bs1/OT7XUduIKrkt7gmt/mUSJU7zQYJbSy05qdldQNg=; b=JqkuLsWX55sdDVkn/5SupKyGgqEoWX2+xhPhAfsJc2jAKR6ytCr3JkrdemqyaJfyDVlUAY iejUF6bQy87xJ4Iyxep3XVaNnBA3THZeZMAjR9AQGFwtQtHgkWERKPSFeX2rybcyeCpkYV ghzhPd7L6QZ0fjSBTJnVEvi4hr+OHAM= Date: Thu, 20 Oct 2022 10:59:48 +0200 From: Borislav Petkov To: Maxim Levitsky Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Pawan Gupta , Ingo Molnar , Josh Poimboeuf , Namhyung Kim , Tony Luck , Paolo Bonzini , "H. Peter Anvin" , Arnaldo Carvalho de Melo , Thomas Gleixner , Alexander Shishkin , Tim Chen , "David S. Miller" , Dave Hansen , "Chang S. Bae" , Jane Malalane , Kees Cook , Kan Liang , Peter Zijlstra , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Herbert Xu , Jiri Olsa , Mark Rutland , linux-perf-users@vger.kernel.org, "open list:CRYPTO API" Subject: Re: [PATCH v2 1/5] perf/x86/intel/lbr: use setup_clear_cpu_cap instead of clear_cpu_cap Message-ID: References: <20220718141123.136106-1-mlevitsk@redhat.com> <20220718141123.136106-2-mlevitsk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Sep 28, 2022 at 01:49:34PM +0300, Maxim Levitsky wrote: > Patch 5 is the main fix - it makes the kernel to be tolerant to a > broken CPUID config (coming hopefully from hypervisor), where you have > a feature (AVX2 in my case) but not a feature on which this feature > depends (AVX). I really really don't like it when people are fixing the wrong thing. Why does the kernel need to get fixed when something else can't get its CPUID dependencies straight? I don't even want to know why something would set AVX2 without AVX?!?! Srsly. Some of your other bits look sensible and I'd take a deeper look but this does not make any sense. This is a hypervisor problem - not a kernel one. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette