From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46AD3C4332F for ; Fri, 21 Oct 2022 03:40:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229741AbiJUDjC (ORCPT ); Thu, 20 Oct 2022 23:39:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbiJUDi5 (ORCPT ); Thu, 20 Oct 2022 23:38:57 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 560181EEF35; Thu, 20 Oct 2022 20:38:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1XY73f1kjOU4NdkwAVhndbgqvAKzNMKeh42X8Tt0Wkw=; b=jPWpIVKYoxvDDgxbcKiw/lXPPT 1LEj3moZ+xR5z103bB9Dbe/R0y8xz42AMGxzKRoBtVA1STPNlx3rPPKEEi4/IIkDH0LBlru86x02f O24rRi97bFyMhvrK/fDNvBve6BdXyyAlnQyplqqzBqqaKBk8LGLFY0rBEpwjGxX4BS0Fg3N9x/tMG sKCmeytDq8T3+azeoGdA/oOfOE3inboL/Peuo+A8L0dNv63o3A4lJFZ3iC5VjsIB/NcFyi0yPS/0+ 6bsTiWGhYVdpi4WUjEynekfJj3rk3vxFFfLSvwe3qCYmO5fnoIZVxywahWn9ytz4R1MQ5Hf1Y1ctd oU2kAutA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1olirY-00CrCi-Qx; Fri, 21 Oct 2022 03:38:24 +0000 Date: Fri, 21 Oct 2022 04:38:24 +0100 From: Matthew Wilcox To: Linus Torvalds Cc: Peter Zijlstra , the arch/x86 maintainers , Yu Zhao , Andrew Morton , Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Johannes Weiner , Jonathan Corbet , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Tejun Heo , Vlastimil Babka , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, page-reclaim@google.com, Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , Holger =?iso-8859-1?Q?Hoffst=E4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Subject: Re: [PATCH v14 08/14] mm: multi-gen LRU: support page table walks Message-ID: References: <20220815071332.627393-1-yuzhao@google.com> <20220815071332.627393-9-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 20, 2022 at 07:10:46PM -0700, Linus Torvalds wrote: > Maybe we should just bite the bullet, and say that we only support > x86-32 with 'cmpxchg8b' (ie Pentium and later). > > Get rid of all the "emulate 64-bit atomics with cli/sti, knowing that > nobody has SMP on those CPU's anyway", and implement a generic x86-32 > xchg() setup using that try_cmpxchg64 loop. > > I think most (all?) distros already enable X86_PAE anyway, which makes > that X86_CMPXCHG64 be part of the base requirement. > > Not that I'm convinced most distros even do 32-bit development anyway > these days. > > (Of course, if we require X86_CMPXCHG64, we'll also hit some of the > odd clone CPU's that actually *do* support the instruction, but do not > report it in cpuid due to an odd old Windows NT bug. IOW, things like > the Cyrix and Transmeta CPU's did support the instruction, but had the > CX8 bit clear because otherwise NT wouldn't boot. We may or may not > get those cases right, but I doubt anybody really has any of those old > CPUs). > > We got rid of i386 support back in 2012. Maybe it's time to get rid of > i486 support in 2022? Arnd suggested removing i486 last year and got a bit of pushback. The most convincing to my mind was Maciej: https://lore.kernel.org/lkml/alpine.DEB.2.21.2110231853170.38243@angie.orcam.me.uk/ but you can see a few other responses indicating that people have shipped new 486-class hardware within the last few years (!) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BCB7C433FE for ; Fri, 21 Oct 2022 03:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4mjwayxoZfaUMR+U2VxkpPamj7hkh0bkzKsK9pDXp8A=; b=4wIdw0tOnJADD+ JZ6tvouMT2IirL0WmJXg6VHng4OrgjFzi5u+7DyAjzEe0WCbs+eliWVRx7gS2bSwexcNB66t/Hs8P MwJAHAJp0oz/Y8gHgwMpp3vq6HbPOIuZaRAlUVqTC5WTIjv46QNy117RK0Q+J1HykTE5CNBWBjBt9 BbqzAuTnI/W0LCcvPJFNnhkXR0MeP5h6YXoQoRz0FLjbSPzvyVT0PsPAdIBeKOn3GsW4sN8eOr7uA 3SZTJNVOss12qQGxoPWOHNbVR1S6VAmez8L9h+m0lT9A+V18Z6hNl44z4pNU41idsaLZIHcVSX3yl b6rrYo+1MMAK7b028hJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oliri-004o8Z-O2; Fri, 21 Oct 2022 03:38:34 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olirg-004o7s-9H for linux-arm-kernel@bombadil.infradead.org; Fri, 21 Oct 2022 03:38:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1XY73f1kjOU4NdkwAVhndbgqvAKzNMKeh42X8Tt0Wkw=; b=jPWpIVKYoxvDDgxbcKiw/lXPPT 1LEj3moZ+xR5z103bB9Dbe/R0y8xz42AMGxzKRoBtVA1STPNlx3rPPKEEi4/IIkDH0LBlru86x02f O24rRi97bFyMhvrK/fDNvBve6BdXyyAlnQyplqqzBqqaKBk8LGLFY0rBEpwjGxX4BS0Fg3N9x/tMG sKCmeytDq8T3+azeoGdA/oOfOE3inboL/Peuo+A8L0dNv63o3A4lJFZ3iC5VjsIB/NcFyi0yPS/0+ 6bsTiWGhYVdpi4WUjEynekfJj3rk3vxFFfLSvwe3qCYmO5fnoIZVxywahWn9ytz4R1MQ5Hf1Y1ctd oU2kAutA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1olirY-00CrCi-Qx; Fri, 21 Oct 2022 03:38:24 +0000 Date: Fri, 21 Oct 2022 04:38:24 +0100 From: Matthew Wilcox To: Linus Torvalds Cc: Peter Zijlstra , the arch/x86 maintainers , Yu Zhao , Andrew Morton , Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Johannes Weiner , Jonathan Corbet , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Tejun Heo , Vlastimil Babka , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, page-reclaim@google.com, Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , Holger =?iso-8859-1?Q?Hoffst=E4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Subject: Re: [PATCH v14 08/14] mm: multi-gen LRU: support page table walks Message-ID: References: <20220815071332.627393-1-yuzhao@google.com> <20220815071332.627393-9-yuzhao@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 20, 2022 at 07:10:46PM -0700, Linus Torvalds wrote: > Maybe we should just bite the bullet, and say that we only support > x86-32 with 'cmpxchg8b' (ie Pentium and later). > > Get rid of all the "emulate 64-bit atomics with cli/sti, knowing that > nobody has SMP on those CPU's anyway", and implement a generic x86-32 > xchg() setup using that try_cmpxchg64 loop. > > I think most (all?) distros already enable X86_PAE anyway, which makes > that X86_CMPXCHG64 be part of the base requirement. > > Not that I'm convinced most distros even do 32-bit development anyway > these days. > > (Of course, if we require X86_CMPXCHG64, we'll also hit some of the > odd clone CPU's that actually *do* support the instruction, but do not > report it in cpuid due to an odd old Windows NT bug. IOW, things like > the Cyrix and Transmeta CPU's did support the instruction, but had the > CX8 bit clear because otherwise NT wouldn't boot. We may or may not > get those cases right, but I doubt anybody really has any of those old > CPUs). > > We got rid of i386 support back in 2012. Maybe it's time to get rid of > i486 support in 2022? Arnd suggested removing i486 last year and got a bit of pushback. The most convincing to my mind was Maciej: https://lore.kernel.org/lkml/alpine.DEB.2.21.2110231853170.38243@angie.orcam.me.uk/ but you can see a few other responses indicating that people have shipped new 486-class hardware within the last few years (!) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel