From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEF48C4332F for ; Fri, 21 Oct 2022 09:38:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230142AbiJUJiF (ORCPT ); Fri, 21 Oct 2022 05:38:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbiJUJiB (ORCPT ); Fri, 21 Oct 2022 05:38:01 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0629724D887; Fri, 21 Oct 2022 02:38:00 -0700 (PDT) Received: from zn.tnic (p200300ea9733e769329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e769:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 82D441EC0742; Fri, 21 Oct 2022 11:37:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1666345074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=n1fViR5INKz08b2AX2t7evluOd1FEBYL4nLLbMadCI4=; b=qs2gkp4aJmtxjOcQKwx/G+yHdTEnttGZv3ojWJWMdtf3oX7UcemiflgKLWgarZk6MQHQB2 koV9meyxS5O1jLHKi99mBj369nejOCC6PIebCo8xw3UEW/cTmKqaqWtSjaLaz31QtYERqs bZY5H0QsKXVEbDn9I8H++lfFKXYBVhI= Date: Fri, 21 Oct 2022 11:37:54 +0200 From: Borislav Petkov To: Huang Rui Cc: "Limonciello, Mario" , "Yuan, Perry" , "rafael.j.wysocki@intel.com" , "viresh.kumar@linaro.org" , "Sharma, Deepak" , "Fontenot, Nathan" , "Deucher, Alexander" , "Huang, Shimmer" , "Du, Xiaojian" , "Meng, Li (Jassmine)" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RESEND PATCH V2 4/9] x86/msr: Add the MSR definition for AMD CPPC boost state Message-ID: References: <20221010162248.348141-1-Perry.Yuan@amd.com> <20221010162248.348141-5-Perry.Yuan@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 21, 2022 at 01:22:11PM +0800, Huang Rui wrote: > > > If I rename that the MSR definition string, that will cause lots of driver file > > > change. > > > So I suggest to add one new MSR macro for the CPPC, the MSR_K7_HWCR is > > > mismatching in the CPPC Pstate driver. > > > If you refuse to use this new one, I will reuse that old one. > > > > To avoid changing too much stuff at once how about if you give an alias? > > IE something like: > > > > #define MSR_AMD_CPPC_HW_CTL MSR_K7_HWCR Why would you all even think about adding a new name and not use MSR_K7_HWCR? The other code uses it just fine, do git grep MSR_K7_HWCR. We have waaay too many MSRs, no need to unnecessarily confuse people with an alias or rename stuff. Just use MSR_K7_HWCR like everything else does. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette