From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32FFFC433FE for ; Fri, 21 Oct 2022 21:29:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229906AbiJUV25 (ORCPT ); Fri, 21 Oct 2022 17:28:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229777AbiJUV2k (ORCPT ); Fri, 21 Oct 2022 17:28:40 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 554BD2A0423; Fri, 21 Oct 2022 14:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3hD2er5RCB6yxwdfG36pC3HJcKq32TIWBK3DhRt40Ks=; b=ahgW1gTqY14JCuLT6uIeIgRk1V PyidkqTva5c3EIxVb6bMgJm7AWJ1dlzYZMZIdJXTMBB0jQbAE7ye/TpdDddFxu/VeqJKACNj/7ObP sD2zSYzzwIg3SYPqJB/HbXlhLjDyGWSWSCf1CaD0oaUo0X3W5yiQJYnTj08qb4FoICm9YPpC7dMTl Edn2bTfCW51D3lCyRgjZaBPV/VvzcByBjMyRa3NS0Dhk0fugIP5i9W351r8ar4t1VWknerClco611 uCwWRh5uJAhliBLjO/Be4IZo8F+UhQPml7CowzJVBmZ7UDcST9d3LD2gDopuB+Hl35kOpWMNbhP2x lOrW0L4g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34880) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1olzYt-0000j5-Uz; Fri, 21 Oct 2022 22:28:15 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1olzYn-0004Tn-KC; Fri, 21 Oct 2022 22:28:09 +0100 Date: Fri, 21 Oct 2022 22:28:09 +0100 From: "Russell King (Oracle)" To: Frank Wunderlich Cc: Frank Wunderlich , linux-mediatek@lists.infradead.org, Alexander Couzens , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: Re: Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops Message-ID: References: <20221020144431.126124-1-linux@fw-web.de> <02A54E45-2084-440A-A643-772C0CC9F988@public-files.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 21, 2022 at 09:52:36PM +0200, Frank Wunderlich wrote: > > Gesendet: Freitag, 21. Oktober 2022 um 20:31 Uhr > > Von: "Russell King (Oracle)" > > > On Fri, Oct 21, 2022 at 07:47:47PM +0200, Frank Wunderlich wrote: > > > > Gesendet: Freitag, 21. Oktober 2022 um 11:06 Uhr > > > > Von: "Russell King (Oracle)" > > > > > Looking at SGMSYS_PCS_CONTROL_1, this is actually the standard BMCR in > > > > the low 16 bits, and BMSR in the upper 16 bits, so: > > > > > > > > At address 4, I'd expect the PHYSID. > > > > At address 8, I'd expect the advertisement register in the low 16 bits > > > > and the link partner advertisement in the upper 16 bits. > > > > > > > > Can you try an experiment, and in mtk_sgmii_init() try accessing the > > > > regmap at address 0, 4, and 8 and print their contents please? > > > > > > is this what you want to see? > > > > [ 1.083359] dev: 0 offset:0 0x840140 > > > [ 1.083376] dev: 0 offset:4 0x4d544950 > > > [ 1.086955] dev: 0 offset:8 0x1 > > > [ 1.090697] dev: 1 offset:0 0x81140 > > > [ 1.093866] dev: 1 offset:4 0x4d544950 > > > [ 1.097342] dev: 1 offset:8 0x1 > > > > Thanks. Decoding these... > > > > dev 0: > > BMCR: fixed, full duplex, 1000Mbps, !autoneg > > BMSR: link up > > Phy ID: 0x4d54 0x4950 > > Advertise: 0x0001 (which would correspond with the MAC side of SGMII) > > Link partner: 0x0000 (no advertisement received, but we're not using > > negotiation.) > > > > dev 1: > > BMCR: autoneg (full duplex, 1000Mbps - both would be ignored) > > BMSR: able to do autoneg, no link > > Phy ID: 0x4d54 0x4950 > > Advertise: 0x0001 (same as above) > > Link partner: 0x0000 (no advertisement received due to no link) > > > > Okay, what would now be interesting is to see how dev 1 behaves when > > it has link with a 1000base-X link partner that is advertising > > properly. If this changes to 0x01e0 or similar (in the high 16-bits > > of offset 8) then we definitely know that this is an IEEE PHY register > > set laid out in memory, and we can program the advertisement and read > > the link partner's abilities. > > added register-read on the the new get_state function too > > on bootup it is now a bit different > > [ 1.086283] dev: 0 offset:0 0x40140 #was previously 0x840140 > [ 1.086301] dev: 0 offset:4 0x4d544950 > [ 1.089795] dev: 0 offset:8 0x1 > [ 1.093584] dev: 1 offset:0 0x81140 > [ 1.096716] dev: 1 offset:4 0x4d544950 > [ 1.100191] dev: 1 offset:8 0x1 > > root@bpi-r3:~# ip link set eth1 up > [ 172.037519] mtk_soc_eth 15100000.ethernet eth1: configuring for inband/1000base-x link mode > root@bpi-r3:~# > [ 172.102949] offset:0 0x40140 #still same value If this is "dev: 1" the value has changed - the ANENABLE bit has been turned off, which means it's not going to bother receiving or sending the 16-bit control word. Bit 12 needs to stay set for it to perform the exchange. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 753F2C38A2D for ; Fri, 21 Oct 2022 21:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y5aHNbxb/pW6ktC3I1n1IxPwHokh2QPRPpgDkWfNkMI=; b=1idpOW6fRwX3ME mrbnriQD/XPjAfLbH1CXF+0GszfwoxjbT/WhmRihMnr9uTpV9EXwirl5IdbuRqkeDlbbsP9lMbksv btOvHrMN2txQnpGawhSvFvv2Y0jg1EQkYp3ufHAk/58rbY7RGASjnZNx6GTg898P5RtkrnD/EIovv 3AyDsu7ZK2X63w4Ht9M3RooW+Ryy8dGIn4cPyKNmShDHCUe7w6vQnxVaajY1dngdIN9shCa+ZFY3s XboXlij2cjlV/1aQ3Dc5Rz68ZCk6CLAd6bxPCQZ9Df80o2ztojPAOz4E4nYEJhnqwCmza+Es6lNcM HSJzNocLFo8NFtw5a2KA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olzZ8-00A0o9-1F; Fri, 21 Oct 2022 21:28:30 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olzZ3-00A0me-Jz; Fri, 21 Oct 2022 21:28:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3hD2er5RCB6yxwdfG36pC3HJcKq32TIWBK3DhRt40Ks=; b=ahgW1gTqY14JCuLT6uIeIgRk1V PyidkqTva5c3EIxVb6bMgJm7AWJ1dlzYZMZIdJXTMBB0jQbAE7ye/TpdDddFxu/VeqJKACNj/7ObP sD2zSYzzwIg3SYPqJB/HbXlhLjDyGWSWSCf1CaD0oaUo0X3W5yiQJYnTj08qb4FoICm9YPpC7dMTl Edn2bTfCW51D3lCyRgjZaBPV/VvzcByBjMyRa3NS0Dhk0fugIP5i9W351r8ar4t1VWknerClco611 uCwWRh5uJAhliBLjO/Be4IZo8F+UhQPml7CowzJVBmZ7UDcST9d3LD2gDopuB+Hl35kOpWMNbhP2x lOrW0L4g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34880) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1olzYt-0000j5-Uz; Fri, 21 Oct 2022 22:28:15 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1olzYn-0004Tn-KC; Fri, 21 Oct 2022 22:28:09 +0100 Date: Fri, 21 Oct 2022 22:28:09 +0100 From: "Russell King (Oracle)" To: Frank Wunderlich Cc: Frank Wunderlich , linux-mediatek@lists.infradead.org, Alexander Couzens , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: Re: Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops Message-ID: References: <20221020144431.126124-1-linux@fw-web.de> <02A54E45-2084-440A-A643-772C0CC9F988@public-files.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221021_142825_683516_4985285C X-CRM114-Status: GOOD ( 26.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 21, 2022 at 09:52:36PM +0200, Frank Wunderlich wrote: > > Gesendet: Freitag, 21. Oktober 2022 um 20:31 Uhr > > Von: "Russell King (Oracle)" > > > On Fri, Oct 21, 2022 at 07:47:47PM +0200, Frank Wunderlich wrote: > > > > Gesendet: Freitag, 21. Oktober 2022 um 11:06 Uhr > > > > Von: "Russell King (Oracle)" > > > > > Looking at SGMSYS_PCS_CONTROL_1, this is actually the standard BMCR in > > > > the low 16 bits, and BMSR in the upper 16 bits, so: > > > > > > > > At address 4, I'd expect the PHYSID. > > > > At address 8, I'd expect the advertisement register in the low 16 bits > > > > and the link partner advertisement in the upper 16 bits. > > > > > > > > Can you try an experiment, and in mtk_sgmii_init() try accessing the > > > > regmap at address 0, 4, and 8 and print their contents please? > > > > > > is this what you want to see? > > > > [ 1.083359] dev: 0 offset:0 0x840140 > > > [ 1.083376] dev: 0 offset:4 0x4d544950 > > > [ 1.086955] dev: 0 offset:8 0x1 > > > [ 1.090697] dev: 1 offset:0 0x81140 > > > [ 1.093866] dev: 1 offset:4 0x4d544950 > > > [ 1.097342] dev: 1 offset:8 0x1 > > > > Thanks. Decoding these... > > > > dev 0: > > BMCR: fixed, full duplex, 1000Mbps, !autoneg > > BMSR: link up > > Phy ID: 0x4d54 0x4950 > > Advertise: 0x0001 (which would correspond with the MAC side of SGMII) > > Link partner: 0x0000 (no advertisement received, but we're not using > > negotiation.) > > > > dev 1: > > BMCR: autoneg (full duplex, 1000Mbps - both would be ignored) > > BMSR: able to do autoneg, no link > > Phy ID: 0x4d54 0x4950 > > Advertise: 0x0001 (same as above) > > Link partner: 0x0000 (no advertisement received due to no link) > > > > Okay, what would now be interesting is to see how dev 1 behaves when > > it has link with a 1000base-X link partner that is advertising > > properly. If this changes to 0x01e0 or similar (in the high 16-bits > > of offset 8) then we definitely know that this is an IEEE PHY register > > set laid out in memory, and we can program the advertisement and read > > the link partner's abilities. > > added register-read on the the new get_state function too > > on bootup it is now a bit different > > [ 1.086283] dev: 0 offset:0 0x40140 #was previously 0x840140 > [ 1.086301] dev: 0 offset:4 0x4d544950 > [ 1.089795] dev: 0 offset:8 0x1 > [ 1.093584] dev: 1 offset:0 0x81140 > [ 1.096716] dev: 1 offset:4 0x4d544950 > [ 1.100191] dev: 1 offset:8 0x1 > > root@bpi-r3:~# ip link set eth1 up > [ 172.037519] mtk_soc_eth 15100000.ethernet eth1: configuring for inband/1000base-x link mode > root@bpi-r3:~# > [ 172.102949] offset:0 0x40140 #still same value If this is "dev: 1" the value has changed - the ANENABLE bit has been turned off, which means it's not going to bother receiving or sending the 16-bit control word. Bit 12 needs to stay set for it to perform the exchange. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel