From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Daniel Henrique Barboza <danielhb413@gmail.com>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>, "John Snow" <jsnow@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: Re: [PATCH] avocado: use sha1 for fc31 imgs to avoid first time re-download
Date: Mon, 24 Oct 2022 10:02:41 +0100 [thread overview]
Message-ID: <Y1ZUsauC6F3yDuny@redhat.com> (raw)
In-Reply-To: <20221022170350.936685-1-danielhb413@gmail.com>
On Sat, Oct 22, 2022 at 02:03:50PM -0300, Daniel Henrique Barboza wrote:
> 'make check-avocado' will download any images that aren't present in the
> cache via 'get-vm-images' in tests/Makefile.include. The target that
> downloads fedora 31 images, get-vm-image-fedora-31, will use 'avocado
> vmimage get --distro=fedora --distro-version=31 --arch=(...)' to
> download the image for each arch. Note that this command does not
> support any argument to set the hash algorithm used and, based on the
> avocado source code [1], DEFAULT_HASH_ALGORITHM is set to "sha1". The
> sha1 hash is stored in a Fedora-Cloud-Base-31-1.9.{ARCH}.qcow2-CHECKSUM
> in the cache.
> For now, in QEMU, let's use sha1 for all Fedora 31 images. This will
> immediately spares us at least one extra download for each Fedora 31
> image that we're doing in all our CI runs.
>
> [1] https://github.com/avocado-framework/avocado.git @ 942a5d6972906
> [2] https://github.com/avocado-framework/avocado/issues/5496
Can we just ask Avocado maintainers to fix this problem on their
side to allow use of a modern hash alg as a priority item. We've
already had this problem in QEMU for over a year AFAICT, so doesn't
seem like we need to urgently do a workaround on QEMU side, so we
can get Avocado devs to commit to fixing it in the next month.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-10-24 10:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 17:03 [PATCH] avocado: use sha1 for fc31 imgs to avoid first time re-download Daniel Henrique Barboza
2022-10-24 9:02 ` Daniel P. Berrangé [this message]
2022-10-25 9:55 ` Daniel Henrique Barboza
2022-10-27 7:46 ` Thomas Huth
2022-10-27 9:01 ` Daniel P. Berrangé
2022-11-09 15:39 ` Daniel Henrique Barboza
2022-11-09 23:26 ` Philippe Mathieu-Daudé
2022-11-10 14:57 ` Jan Richter
2022-11-10 19:29 ` Daniel Henrique Barboza
2022-11-14 16:00 ` Jan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1ZUsauC6F3yDuny@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=danielhb413@gmail.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.