From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B3FA7B for ; Tue, 25 Oct 2022 08:21:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EtmojnUqnCVKWOh8C7J92DZrsq9/z0GK3KV0rT9mLpw=; b=BiKMTB/c8/919DvH6LZjZyf2T7 Lk+Oc0WQgSHrU043Y+cnUTrcCAWFFIRwbP/gwShZJOH7Ph6ZjNkE4YzQLwl+rZ6FQMYOZVZ1KaAAv JrHnpzzBk58E6Bw1q1q6MogLgb0j7g2H4c3zZg9FWX17eaRq/RM83PQCbfJMvNXNS9KzKq0aINVsM KaygbGcRwn6F39U9DxcVpgeF99Nlne7F879RubTg63DmK7uq37EnDvG5KYZFfCKozoHb2sgk7eO4l lwO6xacAFy+7uJjlKmYCqjbyjVIn9IsBwGV8SHQv4hpDF3zC3DsR7nT9nOHu1R4lpXKIo3O5UJycU fdMcQzOw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34940) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1onFBQ-0004Dt-7i; Tue, 25 Oct 2022 09:21:12 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1onFBL-0007xV-IX; Tue, 25 Oct 2022 09:21:07 +0100 Date: Tue, 25 Oct 2022 09:21:07 +0100 From: "Russell King (Oracle)" To: Jakub Kicinski Cc: kernel test robot , Andrew Morton , ntfs3@lists.linux.dev, netdev@vger.kernel.org, linux-parisc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, amd-gfx@lists.freedesktop.org, Linux Memory Management List Subject: Re: [linux-next:master] BUILD SUCCESS WITH WARNING 76cf65d1377f733af1e2a55233e3353ffa577f54 Message-ID: References: <6356c451.pwLIF+9EvDUrDjTY%lkp@intel.com> <20221024145527.0eff7844@kernel.org> Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024145527.0eff7844@kernel.org> Sender: Russell King (Oracle) On Mon, Oct 24, 2022 at 02:55:27PM -0700, Jakub Kicinski wrote: > On Tue, 25 Oct 2022 00:58:57 +0800 kernel test robot wrote: > > drivers/net/phy/phylink.c:588 phylink_validate_mask_caps() warn: variable dereferenced before check 'state' (see line 583) > > Hi Russell, I think the warning is semi-legit. Your commit f392a1846489 > ("net: phylink: provide phylink_validate_mask_caps() helper") added an > if (state) before defer'ing state but it's already deref'ed higher up > so can't be null. Not me, Sean. My original implementation of phylink_validate_mask_caps() doesn't know anything about rate matching, so my version didn't have this issue. Sean's version of my patch (which is what was submitted) added the dereference that causes this, so, it's up to Sean to figure out a fix - but he reading his follow up to the build bot's message, he seems to be passing it over to me to fix! I've got other issues to be worked on right now, and have no time to spare to fix other people's mistakes. Sorry. You can't always rely on the apparent author mentioned in the commit to be the actual person responsible for the changes in a patch. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24E51C04A95 for ; Tue, 25 Oct 2022 08:22:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hIj9eM4+egsYo5EWF+9GOb4FOX4QqRDheSoUEXYhPyo=; b=kKaIOhwjMpuZOs L3Jk8qqyON8QJ+eG1PY5TAXTsq6SWGWIA3ur7ynJKIrBzZl1EE//K9lSuNeLeYA5Gv/+ZPN279i7X KiQg1v2JRI4BY4IFPlF12+LueJve/XvD3Vo+Ko/jz5NKidLDJvuUE4Fu1HttTkvt34WQGw8BpRu+F OcPhFlFyv8sCjuLQDreembfGPIPZ615h+c3DCp1fSShs8BkTAg66pcBzP5SIRBNjdh+jvKiSRKM8b wqoiizaRq7uYcKvh7uQB4km/0x8V64E1SEfu4Su5HeG3pipEPlw5XPkpo5RY0pSYQ+Ma/RfGPdPLP 0MZqE2USsusaIdPNUYpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onFBm-004JGf-7a; Tue, 25 Oct 2022 08:21:34 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onFBi-004JF6-Dg; Tue, 25 Oct 2022 08:21:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EtmojnUqnCVKWOh8C7J92DZrsq9/z0GK3KV0rT9mLpw=; b=BiKMTB/c8/919DvH6LZjZyf2T7 Lk+Oc0WQgSHrU043Y+cnUTrcCAWFFIRwbP/gwShZJOH7Ph6ZjNkE4YzQLwl+rZ6FQMYOZVZ1KaAAv JrHnpzzBk58E6Bw1q1q6MogLgb0j7g2H4c3zZg9FWX17eaRq/RM83PQCbfJMvNXNS9KzKq0aINVsM KaygbGcRwn6F39U9DxcVpgeF99Nlne7F879RubTg63DmK7uq37EnDvG5KYZFfCKozoHb2sgk7eO4l lwO6xacAFy+7uJjlKmYCqjbyjVIn9IsBwGV8SHQv4hpDF3zC3DsR7nT9nOHu1R4lpXKIo3O5UJycU fdMcQzOw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34940) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1onFBQ-0004Dt-7i; Tue, 25 Oct 2022 09:21:12 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1onFBL-0007xV-IX; Tue, 25 Oct 2022 09:21:07 +0100 Date: Tue, 25 Oct 2022 09:21:07 +0100 From: "Russell King (Oracle)" To: Jakub Kicinski Cc: kernel test robot , Andrew Morton , ntfs3@lists.linux.dev, netdev@vger.kernel.org, linux-parisc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, amd-gfx@lists.freedesktop.org, Linux Memory Management List Subject: Re: [linux-next:master] BUILD SUCCESS WITH WARNING 76cf65d1377f733af1e2a55233e3353ffa577f54 Message-ID: References: <6356c451.pwLIF+9EvDUrDjTY%lkp@intel.com> <20221024145527.0eff7844@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221024145527.0eff7844@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221025_012130_777629_D98889CB X-CRM114-Status: GOOD ( 13.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 24, 2022 at 02:55:27PM -0700, Jakub Kicinski wrote: > On Tue, 25 Oct 2022 00:58:57 +0800 kernel test robot wrote: > > drivers/net/phy/phylink.c:588 phylink_validate_mask_caps() warn: variable dereferenced before check 'state' (see line 583) > > Hi Russell, I think the warning is semi-legit. Your commit f392a1846489 > ("net: phylink: provide phylink_validate_mask_caps() helper") added an > if (state) before defer'ing state but it's already deref'ed higher up > so can't be null. Not me, Sean. My original implementation of phylink_validate_mask_caps() doesn't know anything about rate matching, so my version didn't have this issue. Sean's version of my patch (which is what was submitted) added the dereference that causes this, so, it's up to Sean to figure out a fix - but he reading his follow up to the build bot's message, he seems to be passing it over to me to fix! I've got other issues to be worked on right now, and have no time to spare to fix other people's mistakes. Sorry. You can't always rely on the apparent author mentioned in the commit to be the actual person responsible for the changes in a patch. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BA0EC38A2D for ; Tue, 25 Oct 2022 13:12:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DF3110E385; Tue, 25 Oct 2022 13:12:12 +0000 (UTC) X-Greylist: delayed 352 seconds by postgrey-1.36 at gabe; Tue, 25 Oct 2022 08:27:26 UTC Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7EAEC10E278 for ; Tue, 25 Oct 2022 08:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EtmojnUqnCVKWOh8C7J92DZrsq9/z0GK3KV0rT9mLpw=; b=BiKMTB/c8/919DvH6LZjZyf2T7 Lk+Oc0WQgSHrU043Y+cnUTrcCAWFFIRwbP/gwShZJOH7Ph6ZjNkE4YzQLwl+rZ6FQMYOZVZ1KaAAv JrHnpzzBk58E6Bw1q1q6MogLgb0j7g2H4c3zZg9FWX17eaRq/RM83PQCbfJMvNXNS9KzKq0aINVsM KaygbGcRwn6F39U9DxcVpgeF99Nlne7F879RubTg63DmK7uq37EnDvG5KYZFfCKozoHb2sgk7eO4l lwO6xacAFy+7uJjlKmYCqjbyjVIn9IsBwGV8SHQv4hpDF3zC3DsR7nT9nOHu1R4lpXKIo3O5UJycU fdMcQzOw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34940) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1onFBQ-0004Dt-7i; Tue, 25 Oct 2022 09:21:12 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1onFBL-0007xV-IX; Tue, 25 Oct 2022 09:21:07 +0100 Date: Tue, 25 Oct 2022 09:21:07 +0100 From: "Russell King (Oracle)" To: Jakub Kicinski Subject: Re: [linux-next:master] BUILD SUCCESS WITH WARNING 76cf65d1377f733af1e2a55233e3353ffa577f54 Message-ID: References: <6356c451.pwLIF+9EvDUrDjTY%lkp@intel.com> <20221024145527.0eff7844@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024145527.0eff7844@kernel.org> X-Mailman-Approved-At: Tue, 25 Oct 2022 13:12:08 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, amd-gfx@lists.freedesktop.org, Linux Memory Management List , linux-mediatek@lists.infradead.org, Andrew Morton , ntfs3@lists.linux.dev, linux-arm-kernel@lists.infradead.org Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Mon, Oct 24, 2022 at 02:55:27PM -0700, Jakub Kicinski wrote: > On Tue, 25 Oct 2022 00:58:57 +0800 kernel test robot wrote: > > drivers/net/phy/phylink.c:588 phylink_validate_mask_caps() warn: variable dereferenced before check 'state' (see line 583) > > Hi Russell, I think the warning is semi-legit. Your commit f392a1846489 > ("net: phylink: provide phylink_validate_mask_caps() helper") added an > if (state) before defer'ing state but it's already deref'ed higher up > so can't be null. Not me, Sean. My original implementation of phylink_validate_mask_caps() doesn't know anything about rate matching, so my version didn't have this issue. Sean's version of my patch (which is what was submitted) added the dereference that causes this, so, it's up to Sean to figure out a fix - but he reading his follow up to the build bot's message, he seems to be passing it over to me to fix! I've got other issues to be worked on right now, and have no time to spare to fix other people's mistakes. Sorry. You can't always rely on the apparent author mentioned in the commit to be the actual person responsible for the changes in a patch. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!