All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Pedro Guilherme Siqueira Moreira <pedro.guilherme@espectro.eng.br>
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] media: uvc_driver: fix missing newline after declarations
Date: Tue, 25 Oct 2022 21:50:57 +0300	[thread overview]
Message-ID: <Y1gwETdTkfAMTB8E@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20221025050450.1743072-1-pedro.guilherme@espectro.eng.br>

Hi Pedro,

Thank you for the patch.

On Tue, Oct 25, 2022 at 02:04:48AM -0300, Pedro Guilherme Siqueira Moreira wrote:
> Fixes 'Missing a blank line after declarations' warning issued by
> scripts/checkpatch.pl on drivers/media/usb/uvc/uvc_driver.c
> 
> Signed-off-by: Pedro Guilherme Siqueira Moreira <pedro.guilherme@espectro.eng.br>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/usb/uvc/uvc_driver.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 215fb483efb0..b591ad823c66 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -732,6 +732,7 @@ static int uvc_parse_streaming(struct uvc_device *dev,
>  	/* Parse the alternate settings to find the maximum bandwidth. */
>  	for (i = 0; i < intf->num_altsetting; ++i) {
>  		struct usb_host_endpoint *ep;
> +
>  		alts = &intf->altsetting[i];
>  		ep = uvc_find_endpoint(alts,
>  				streaming->header.bEndpointAddress);
> @@ -1859,12 +1860,14 @@ static void uvc_delete(struct kref *kref)
>  
>  	list_for_each_safe(p, n, &dev->chains) {
>  		struct uvc_video_chain *chain;
> +
>  		chain = list_entry(p, struct uvc_video_chain, list);
>  		kfree(chain);
>  	}
>  
>  	list_for_each_safe(p, n, &dev->entities) {
>  		struct uvc_entity *entity;
> +
>  		entity = list_entry(p, struct uvc_entity, list);
>  #ifdef CONFIG_MEDIA_CONTROLLER
>  		uvc_mc_cleanup_entity(entity);
> @@ -1874,6 +1877,7 @@ static void uvc_delete(struct kref *kref)
>  
>  	list_for_each_safe(p, n, &dev->streams) {
>  		struct uvc_streaming *streaming;
> +
>  		streaming = list_entry(p, struct uvc_streaming, list);
>  		usb_driver_release_interface(&uvc_driver.driver,
>  			streaming->intf);

-- 
Regards,

Laurent Pinchart

  parent reply	other threads:[~2022-10-25 18:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-25  5:04 [PATCH v2 1/3] media: uvc_driver: fix missing newline after declarations Pedro Guilherme Siqueira Moreira
2022-10-25  5:04 ` [PATCH v2 2/3] media: uvc_driver: fix assignment inside if condition Pedro Guilherme Siqueira Moreira
2022-10-25  8:45   ` Ricardo Ribalda
2022-10-25 18:54     ` Laurent Pinchart
2022-10-25  5:04 ` [PATCH v2 3/3] media: uvc_driver: fix usage of symbolic permissions to octal Pedro Guilherme Siqueira Moreira
2022-10-25 14:58   ` Ricardo Ribalda
2022-10-25 18:54     ` Laurent Pinchart
2022-10-25 18:50 ` Laurent Pinchart [this message]
2022-10-25 18:57   ` [PATCH v2 1/3] media: uvc_driver: fix missing newline after declarations Laurent Pinchart
2022-10-25 19:48     ` Pedro Guilherme Siqueira Moreira
  -- strict thread matches above, loose matches on Subject: below --
2022-10-25  1:36 [PATCH " Laurent Pinchart
2022-10-25  2:19 ` [PATCH v2 " Pedro Guilherme Siqueira Moreira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1gwETdTkfAMTB8E@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pedro.guilherme@espectro.eng.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.