From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AE71C433FE for ; Wed, 26 Oct 2022 09:25:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233187AbiJZJZG (ORCPT ); Wed, 26 Oct 2022 05:25:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233387AbiJZJYu (ORCPT ); Wed, 26 Oct 2022 05:24:50 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7862D3FD63 for ; Wed, 26 Oct 2022 02:24:48 -0700 (PDT) Received: from zn.tnic (p200300ea9733e7b8329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e7b8:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 381161EC064E; Wed, 26 Oct 2022 11:24:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1666776287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=uZok860yPzg2HSkFXYHJ/wRjPzyzd3KTktgEJeYsqRY=; b=EW8aND/2FfWr5evU4I55E/F43rrzXt4ayM8e3QikewJgE+LdWkOl7U8OR0DAjpUxWLG7g5 p/gGBQm+7VT4yTIgH0dolQQlu94/TbEFHxQ42fgPrQBXDVGcXlmCxNlmhcah12hU+YoAdM TDn/t9Q8rOCZqFEHuEWAA85aIUqLiSw= Date: Wed, 26 Oct 2022 11:24:41 +0200 From: Borislav Petkov To: Juergen Gross Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v4 05/16] x86/mtrr: split MTRR specific handling from cache dis/enabling Message-ID: References: <20221004081023.32402-1-jgross@suse.com> <20221004081023.32402-6-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221004081023.32402-6-jgross@suse.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 04, 2022 at 10:10:12AM +0200, Juergen Gross wrote: > @@ -764,11 +779,8 @@ void cache_disable(void) __acquires(cache_disable_lock) > count_vm_tlb_event(NR_TLB_LOCAL_FLUSH_ALL); > flush_tlb_local(); > > - /* Save MTRR state */ > - rdmsr(MSR_MTRRdefType, deftype_lo, deftype_hi); > - > - /* Disable MTRRs, and set the default type to uncached */ > - mtrr_wrmsr(MSR_MTRRdefType, deftype_lo & ~0xcff, deftype_hi); > + if (boot_cpu_has(X86_FEATURE_MTRR)) check_for_deprecated_apis: Warning: arch/x86/kernel/cpu/mtrr/generic.c:782: Do not use boot_cpu_has() - use cpu_feature_enabled() instead. > + mtrr_disable(); > > /* Again, only flush caches if we have to. */ > if (!static_cpu_has(X86_FEATURE_SELFSNOOP)) > @@ -781,8 +793,8 @@ void cache_enable(void) __releases(cache_disable_lock) > count_vm_tlb_event(NR_TLB_LOCAL_FLUSH_ALL); > flush_tlb_local(); > > - /* Intel (P6) standard MTRRs */ > - mtrr_wrmsr(MSR_MTRRdefType, deftype_lo, deftype_hi); > + if (boot_cpu_has(X86_FEATURE_MTRR)) Ditto. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette