From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BFE41C03; Wed, 26 Oct 2022 13:54:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C3D9C433C1; Wed, 26 Oct 2022 13:54:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666792449; bh=qtJhkpBNI09xyN+fRFiz2dyg8X03xHEV6Ai99KiJV2Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EnfwyRUSZErm+pvgMwTNddfTWovLzhr1Oh8B35+Dabsp1Yg4o6DX7PCJYh1l5DQ7p 0GwS/I8io1kir1Cnlkrf01C/fG/tl6Kz1X/6Gv/uVUj47oHrB95v7JUqX89LKHfcTx lDUpBN+JKgKfi4Vy5O+ssXCkdX76BkNKoiqzUtwQ= Date: Wed, 26 Oct 2022 15:55:01 +0200 From: Greg Kroah-Hartman To: Deepak R Varma Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: rtl8192u: remove unused macro definition Message-ID: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Oct 26, 2022 at 07:14:43PM +0530, Deepak R Varma wrote: > On Wed, Oct 26, 2022 at 03:14:23PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Oct 26, 2022 at 08:58:44AM +0530, Deepak R Varma wrote: > > > Pre-processor macros that are defined but are never used should be > > > cleaned up to avoid unexpected usage. > > > > > > Signed-off-by: Deepak R Varma > > > --- > > > drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > > > index 00c07455cbb3..0b3dda59d7c0 100644 > > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h > > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > > > @@ -230,8 +230,6 @@ struct cb_desc { > > > #define ieee80211_unregister_crypto_ops ieee80211_unregister_crypto_ops_rsl > > > #define ieee80211_get_crypto_ops ieee80211_get_crypto_ops_rsl > > > > > > -#define ieee80211_ccmp_null ieee80211_ccmp_null_rsl > > > - > > > #define free_ieee80211 free_ieee80211_rsl > > > #define alloc_ieee80211 alloc_ieee80211_rsl > > > > These #defines are a mess, please look into unwinding them as they > > should not be needed at all. > > Hello Greg, > I would like to know what you mean by "unwind them". Is there a documentation or past > commit that I can review to understand the expectations better? Look at them and try to figure out why they are there, and then work to remove them entirely. A define like this is very odd in the kernel, it should not be needed at all, right? thanks, greg k-h