From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19C8C1C13; Thu, 27 Oct 2022 19:33:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1666899222; bh=xys/aAejh7JTopsuNYt2PnyiMn9PjHrWmN/+pjwgiEE=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=KS9YmOf6EBDaxcPo/tg3HGTAuf92EmuJLBWel96a+p+8VCYMwpuPluj7RvyYISadM IoAjmxcvGPR5sbEM6w3U8Ys37h44Scfj0dIbcnLwbdkKq4MMreqmuF/lHKOQ/Wu2dH zIU3agUiYkRtpPq9h6CuvK1tsOEi2pG7GCZ3VWCk= Received: by b-2.in.mailobj.net [192.168.90.12] with ESMTP via [213.182.55.206] Thu, 27 Oct 2022 21:33:42 +0200 (CEST) X-EA-Auth: B0BsiMOjJQVyJF9UqMNnrzd1/hQN7g5BhYv/Vhez2hUJ+yc4MQSg/PqvKBP4gCRwzt/uBl5if8fWpFUovfKJtnJ6Bt3Q5gaY Date: Fri, 28 Oct 2022 01:03:36 +0530 From: Deepak R Varma To: Greg Kroah-Hartman Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: rtl8192u: remove unused macro definition Message-ID: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Oct 26, 2022 at 03:55:01PM +0200, Greg Kroah-Hartman wrote: > On Wed, Oct 26, 2022 at 07:14:43PM +0530, Deepak R Varma wrote: > > On Wed, Oct 26, 2022 at 03:14:23PM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Oct 26, 2022 at 08:58:44AM +0530, Deepak R Varma wrote: > > > > Pre-processor macros that are defined but are never used should be > > > > cleaned up to avoid unexpected usage. > > > > > > > > Signed-off-by: Deepak R Varma > > > > --- > > > > drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 -- > > > > 1 file changed, 2 deletions(-) > > > > > > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > > > > index 00c07455cbb3..0b3dda59d7c0 100644 > > > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h > > > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > > > > @@ -230,8 +230,6 @@ struct cb_desc { > > > > #define ieee80211_unregister_crypto_ops ieee80211_unregister_crypto_ops_rsl > > > > #define ieee80211_get_crypto_ops ieee80211_get_crypto_ops_rsl > > > > > > > > -#define ieee80211_ccmp_null ieee80211_ccmp_null_rsl > > > > - > > > > #define free_ieee80211 free_ieee80211_rsl > > > > #define alloc_ieee80211 alloc_ieee80211_rsl > > > > > > These #defines are a mess, please look into unwinding them as they > > > should not be needed at all. > > > > Hello Greg, > > I would like to know what you mean by "unwind them". Is there a documentation or past > > commit that I can review to understand the expectations better? > > Look at them and try to figure out why they are there, and then work to > remove them entirely. A define like this is very odd in the kernel, it > should not be needed at all, right? Hello Greg, I will look into these additional macros soon and send any further edits as a separate patch (set). Is the current patch set with 2 patches acceptable? Also, I am trying to get Coccinelle to work on my machine. Trying to work through strange issues. I will work on the macro unwinding task you suggested once a get the Coccinelle task completed. Thank you, ./drv > > thanks, > > greg k-h >