From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/6] gpiolib: add support for software nodes
Date: Thu, 10 Nov 2022 15:48:02 +0200 [thread overview]
Message-ID: <Y20BEuHlY2OEsZ0v@smile.fi.intel.com> (raw)
In-Reply-To: <Y2v6lxoCQvlRdr8q@google.com>
On Wed, Nov 09, 2022 at 11:08:07AM -0800, Dmitry Torokhov wrote:
> On Wed, Nov 09, 2022 at 01:20:46PM +0200, Andy Shevchenko wrote:
> > On Tue, Nov 08, 2022 at 04:26:51PM -0800, Dmitry Torokhov wrote:
...
> > > + pr_debug("%s: parsed '%s' property of node '%pfwP[%d]' - status (%d)\n",
> > > + __func__, propname, fwnode, idx, PTR_ERR_OR_ZERO(desc));
> >
> > %pe ?
>
> "/* %pe with a non-ERR_PTR gets treated as plain %p */".
>
> I do not think users are interested in the address on success.
Hmm... Perhaps we can teach %pe to behave differently with, e.g. %pe0,
modification. But this is another story. So, let's go with your variant.
...
> > > +#include <dt-bindings/gpio/gpio.h>
> >
> > Not sure why we have this here.
>
> For convenience - so that users have access to GPIO_ACTIVE_HIGH/
> GPIO_ACTIVE_LOW and other flags.
Okay, would we make this as a guarantee then?
In such case a comment before this inclusion should be added to explain why
we do that without any actual user to be present in the header file.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-10 13:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 0:26 [PATCH v2 0/6] Add support for software nodes to gpiolib Dmitry Torokhov
2022-11-09 0:26 ` [PATCH v2 1/6] gpiolib: of: change of_find_gpio() to accept device node Dmitry Torokhov
2022-11-09 0:26 ` [PATCH v2 2/6] gpiolib: acpi: change acpi_find_gpio() to accept firmware node Dmitry Torokhov
2022-11-09 0:26 ` [PATCH v2 3/6] gpiolib: acpi: teach acpi_find_gpio() to handle data-only nodes Dmitry Torokhov
2022-11-09 0:26 ` [PATCH v2 4/6] gpiolib: acpi: avoid leaking ACPI details into upper gpiolib layers Dmitry Torokhov
2022-11-09 0:26 ` [PATCH v2 5/6] gpiolib: consolidate GPIO lookups Dmitry Torokhov
2022-11-09 11:25 ` Andy Shevchenko
2022-11-09 19:00 ` Dmitry Torokhov
2022-11-10 13:42 ` Andy Shevchenko
2022-11-10 17:21 ` Dmitry Torokhov
2022-11-10 20:10 ` Andy Shevchenko
2022-11-09 0:26 ` [PATCH v2 6/6] gpiolib: add support for software nodes Dmitry Torokhov
2022-11-09 11:20 ` Andy Shevchenko
2022-11-09 19:08 ` Dmitry Torokhov
2022-11-10 13:48 ` Andy Shevchenko [this message]
2022-11-10 17:17 ` Dmitry Torokhov
2022-11-09 11:29 ` [PATCH v2 0/6] Add support for software nodes to gpiolib Andy Shevchenko
2022-11-09 19:32 ` Dmitry Torokhov
2022-11-10 14:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y20BEuHlY2OEsZ0v@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.