From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from meesny.iki.fi (meesny.iki.fi [195.140.195.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 608AB2582 for ; Fri, 11 Nov 2022 10:31:35 +0000 (UTC) Received: from hillosipuli.retiisi.eu (82-181-192-243.bb.dnainternet.fi [82.181.192.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sailus) by meesny.iki.fi (Postfix) with ESMTPSA id E37FD2070D; Fri, 11 Nov 2022 12:21:34 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1668162095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u4K1Zr9Nd9xjqasmHb1Oi3vEJFEf/Rl2t4cMnoUhyi8=; b=MeJPv5HYsv8Kwy5VGGktQdQ9wA1pwUJlNCJYFL4j4wRjXZIiaAkI6nXJx4+psWX9ZiMtQR WTgmnFKCNbzMGnJ63ouZUUsEoSPVKRJtjtyjnEpHr0zu4zOFXPGNsNg63ApLWi/vwf1000 QtQYFUKMHhkeO3CF0+mBbdegKYq8y0E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1668162095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u4K1Zr9Nd9xjqasmHb1Oi3vEJFEf/Rl2t4cMnoUhyi8=; b=tI6XIgJpnJmo1ZaEbil4cop5fay0jxqg0ACX3dC9RiBk6omBhIzurOfAgLNi/xB2cY4aOZ XSn39lbal3Zzx0NrqsAytBBEJv9j55OjCsrL93kOm0q6JjhSOhRKVRgkEbIdDaX+app8N8 I8UCQxH11QfRPCd2gCqvafVRFRG6KQ4= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=sailus smtp.mailfrom=sakari.ailus@iki.fi ARC-Seal: i=1; s=meesny; d=iki.fi; t=1668162095; a=rsa-sha256; cv=none; b=YX9mI5+JQNAalqyYlLg/+VcGCfkNyyuPQugRgGo9OKZmdkLaQPWf/uu0SZRNfBHRfaGQmQ j4Wsgsxq874q4NyN6zvjCuJhsnKnUt3aOwj+dsvKJ40Z+h+pC1Sf98sLSjADU/+1i5K5wT 3rPj4mTa8B+c4SrKVh06p5B77OBab1k= Received: from valkosipuli.retiisi.eu (valkosipuli.localdomain [192.168.4.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.eu (Postfix) with ESMTPS id 74346634C99; Fri, 11 Nov 2022 12:21:34 +0200 (EET) Date: Fri, 11 Nov 2022 12:21:34 +0200 From: Sakari Ailus To: Paul Kocialkowski Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Yong Deng , Mauro Carvalho Chehab , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni Subject: Re: [PATCH v7 18/28] media: sun6i-csi: Introduce format match structure, list and helper Message-ID: References: <20221103163113.245462-1-paul.kocialkowski@bootlin.com> <20221103163113.245462-19-paul.kocialkowski@bootlin.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Nov 11, 2022 at 12:18:14PM +0200, Sakari Ailus wrote: > Hi Paul, > > On Thu, Nov 03, 2022 at 05:31:03PM +0100, Paul Kocialkowski wrote: > > Introduce a list of mbus/pixel format combinations that need an exact > > match between the two sides. This is the case when using raw input > > configuration. The list will be used to replace the > > sun6i_csi_is_format_supported combinatory helper. > > This patch introduces an unused function which generates a compiler warning > that is now treated as an error. > > I'll squash this to the following patch that uses the function. I think the > commit message will do as-is. Ok, maybe the helper actually should be mentioned. I used this: Rework the capture link validate implementation with actual logic that reflects the possibilities of the device instead of the combinatory helper functions, using the added match list helper sun6i_csi_is_format_supported() when needed. Remove the previous dedicated helper. -- Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F3DAC433FE for ; Fri, 11 Nov 2022 10:22:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r23fVnaAwR2PTyfu/syhyc1WxKcl4tz9i7NmHQ/bw6w=; b=RP65ZrfB1dzvZW NYrtes28q8B16JVXBTOagcdSVmfcMJr2sLGePxy1P1aNZsia70T/uktRC1RlFG6K1qeac+XG6p1JT EgolwvJjvasARI3glFfb95wRgpxBNBWJz0OhecU5gBqnkMVM8dsylYRVZ6x8stNkHttT/Xo2B05Px DzS5hBBdSo1VCFrN+DzsXAqDP6RUXii4q6MZepMXoMxN3taEgz3/42Fgo2CpHKwuA3QBY41QZcTsN BZfO1akZAsujUOvYGMxUKkwBLjZXiDdZXACtc5dR0pqqAjojR8DeTW+t0uVQRpFTzRYo4G2SIIu2j DXRBI0zzqAHpj58jor1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1otRAN-00EumM-0k; Fri, 11 Nov 2022 10:21:43 +0000 Received: from meesny.iki.fi ([2001:67c:2b0:1c1::201]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1otRAK-00EukA-If for linux-arm-kernel@lists.infradead.org; Fri, 11 Nov 2022 10:21:41 +0000 Received: from hillosipuli.retiisi.eu (82-181-192-243.bb.dnainternet.fi [82.181.192.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sailus) by meesny.iki.fi (Postfix) with ESMTPSA id E37FD2070D; Fri, 11 Nov 2022 12:21:34 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1668162095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u4K1Zr9Nd9xjqasmHb1Oi3vEJFEf/Rl2t4cMnoUhyi8=; b=MeJPv5HYsv8Kwy5VGGktQdQ9wA1pwUJlNCJYFL4j4wRjXZIiaAkI6nXJx4+psWX9ZiMtQR WTgmnFKCNbzMGnJ63ouZUUsEoSPVKRJtjtyjnEpHr0zu4zOFXPGNsNg63ApLWi/vwf1000 QtQYFUKMHhkeO3CF0+mBbdegKYq8y0E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1668162095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u4K1Zr9Nd9xjqasmHb1Oi3vEJFEf/Rl2t4cMnoUhyi8=; b=tI6XIgJpnJmo1ZaEbil4cop5fay0jxqg0ACX3dC9RiBk6omBhIzurOfAgLNi/xB2cY4aOZ XSn39lbal3Zzx0NrqsAytBBEJv9j55OjCsrL93kOm0q6JjhSOhRKVRgkEbIdDaX+app8N8 I8UCQxH11QfRPCd2gCqvafVRFRG6KQ4= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=sailus smtp.mailfrom=sakari.ailus@iki.fi ARC-Seal: i=1; s=meesny; d=iki.fi; t=1668162095; a=rsa-sha256; cv=none; b=YX9mI5+JQNAalqyYlLg/+VcGCfkNyyuPQugRgGo9OKZmdkLaQPWf/uu0SZRNfBHRfaGQmQ j4Wsgsxq874q4NyN6zvjCuJhsnKnUt3aOwj+dsvKJ40Z+h+pC1Sf98sLSjADU/+1i5K5wT 3rPj4mTa8B+c4SrKVh06p5B77OBab1k= Received: from valkosipuli.retiisi.eu (valkosipuli.localdomain [192.168.4.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.eu (Postfix) with ESMTPS id 74346634C99; Fri, 11 Nov 2022 12:21:34 +0200 (EET) Date: Fri, 11 Nov 2022 12:21:34 +0200 From: Sakari Ailus To: Paul Kocialkowski Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Yong Deng , Mauro Carvalho Chehab , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni Subject: Re: [PATCH v7 18/28] media: sun6i-csi: Introduce format match structure, list and helper Message-ID: References: <20221103163113.245462-1-paul.kocialkowski@bootlin.com> <20221103163113.245462-19-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221111_022140_824464_B5B1946B X-CRM114-Status: GOOD ( 18.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 11, 2022 at 12:18:14PM +0200, Sakari Ailus wrote: > Hi Paul, > > On Thu, Nov 03, 2022 at 05:31:03PM +0100, Paul Kocialkowski wrote: > > Introduce a list of mbus/pixel format combinations that need an exact > > match between the two sides. This is the case when using raw input > > configuration. The list will be used to replace the > > sun6i_csi_is_format_supported combinatory helper. > > This patch introduces an unused function which generates a compiler warning > that is now treated as an error. > > I'll squash this to the following patch that uses the function. I think the > commit message will do as-is. Ok, maybe the helper actually should be mentioned. I used this: Rework the capture link validate implementation with actual logic that reflects the possibilities of the device instead of the combinatory helper functions, using the added match list helper sun6i_csi_is_format_supported() when needed. Remove the previous dedicated helper. -- Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel