All of
 help / color / mirror / Atom feed
From: Tejun Heo <>
To: Christoph Hellwig <>
Cc: "Jiri Slaby (SUSE)" <>,, Martin Liska <>,
	Josef Bacik <>, Jens Axboe <>,,
Subject: Re: [PATCH] block/blk-iocost (gcc13): cast enum members to int in prints
Date: Mon, 31 Oct 2022 07:57:05 -1000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Oct 31, 2022 at 05:24:28AM -0700, Christoph Hellwig wrote:
> On Mon, Oct 31, 2022 at 12:45:20PM +0100, Jiri Slaby (SUSE) wrote:
> > Cast the enum members to int when printing them.
> > 
> > Alternatively, we can cast them to ulong (to silence gcc < 12) and use %lu.
> > Alternatively, we can move VTIME_PER_SEC away from the enum.
> Yes, either split the enum or just use a define.  But casts are a big
> code smell and should be avoided if there is a reasonable alternative.

enums are so much better for debugging and other instrumentation stuff. The
only requirement for the enum types is that they're big enough to express
all the members and we can use whatever printf format letter which matches
the type in use. The problem here is that the compiler behavior is different
depending on the compiler version, which kinda sucks.

I suppose the most reasonable thing to do here is just splitting them into
separate enum definitions. Does anyone know how this behavior change came to
be? Do we know whether clang is gonna be changed the same way?



  reply	other threads:[~2022-10-31 17:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31 11:45 [PATCH] block/blk-iocost (gcc13): cast enum members to int in prints Jiri Slaby (SUSE)
2022-10-31 12:24 ` Christoph Hellwig
2022-10-31 17:57   ` Tejun Heo [this message]
2022-11-01  5:46     ` Jiri Slaby
2022-11-01 16:46       ` Tejun Heo
2022-11-02  8:35         ` David Laight
2022-11-02 16:27           ` 'Tejun Heo'
2022-11-02 16:43             ` 'Tejun Heo'
2022-12-12 12:14               ` Jiri Slaby
2022-12-12 21:46                 ` 'Tejun Heo'
2022-12-13  8:30                   ` David Laight
2022-12-13 11:15                     ` Jiri Slaby
2022-12-13 11:50                       ` David Laight
2022-12-13 12:05                         ` Jiri Slaby
2022-12-13 12:58                           ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.