From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C743AC4332F for ; Wed, 2 Nov 2022 16:32:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231192AbiKBQcT (ORCPT ); Wed, 2 Nov 2022 12:32:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231717AbiKBQal (ORCPT ); Wed, 2 Nov 2022 12:30:41 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B592F2DA85; Wed, 2 Nov 2022 09:27:49 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id c2so17049790plz.11; Wed, 02 Nov 2022 09:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=XOnTIwSkLdz0Y256VHM03IJIqS86treru+v0xLpx+F0=; b=TSWa57P1ikjpGFCx0r7ilDPFqEDtPVd3KC8p2+bfITDvY+qgxXOhl/TxGYJIPL8HKw 1FAG5fB5ofC4QbMSaaU2lNl3GcDir6a2aQx/Z9Fu6JVPm894KAXlZvEJ+xsgusNCqqza NhDO1Mw9eSPwcyGqeebl2KKJ4x+2fpwGevQ8j22Do7C7344WtfBMf/EJDTg4QRgEWlGr qwhwF8T6Dd/42zvmmTRa47pRMCKV6mjfETEqrCWEc5cHFJhXsJeKsryaMPZsu/E5Nx8b jBviskxJiTgDjC3nxI/YYsC1dG8PZqpmRUyhK+9HaalZ6GWbSwlt0+qe4HBRsiqY96A6 jqpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XOnTIwSkLdz0Y256VHM03IJIqS86treru+v0xLpx+F0=; b=nHia3AKzR7HptIvCzVlAB7xzIhVt20jnh/ayfD6UjUViFu7UYOAtZK6DqZvPy4e7G1 MZukaUsv18WIKbezc7qOkkDvTzEYFNpW81hIZyaAAIV6EeDfXytEN8xJu91ULRCe0rSm 41gjPyDm0IBIzWRIa845VD+zWGpCTgr66oaGtJoKbYH/X9VFUU9DTR0Gh8FhLplmbbKA ujzn5N/fbXc1D7zlq8c6e03Uf/u+jN4Pdt0XbijMIiqVpHkQ0LBVQE6Hi4fnKQz9XzFc Rs9xGw1ziqjqfgkLyNofIUDSTF1Rz7oxe4sqaOBcTkg4kUlHttPXbRbJG7cOnV1ToeH9 34Sw== X-Gm-Message-State: ACrzQf3uv9cUKSoy/Cq9G6U193lYfzMXNoH5DOyepQn4w/BoZVFs7yTB p733QrnhlTyp2ZjImc7e8pY= X-Google-Smtp-Source: AMsMyM7E2quPmXEsuYj49alVoNVVsWh6p89cJPYFs1P3dPWc/mnKd8dL5eFZdh1eX6wV5Y7Mx9Z2QA== X-Received: by 2002:a17:90a:d990:b0:214:2404:19f3 with SMTP id d16-20020a17090ad99000b00214240419f3mr6559132pjv.125.1667406468787; Wed, 02 Nov 2022 09:27:48 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id y13-20020a17090322cd00b00176d347e9a7sm8614361plg.233.2022.11.02.09.27.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 09:27:47 -0700 (PDT) Sender: Tejun Heo Date: Wed, 2 Nov 2022 06:27:46 -1000 From: 'Tejun Heo' To: David Laight Cc: Jiri Slaby , Christoph Hellwig , "linux-kernel@vger.kernel.org" , Martin Liska , Josef Bacik , Jens Axboe , "cgroups@vger.kernel.org" , "linux-block@vger.kernel.org" Subject: Re: [PATCH] block/blk-iocost (gcc13): cast enum members to int in prints Message-ID: References: <20221031114520.10518-1-jirislaby@kernel.org> <2b975ee3117e45aaa7882203cf9a4db8@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2b975ee3117e45aaa7882203cf9a4db8@AcuMS.aculab.com> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Nov 02, 2022 at 08:35:34AM +0000, David Laight wrote: > I think the enums have to be split. > There will be other side effects of promoting the constants to 64bit > that are much more difficult to detect than the warnings from printf. idk, I think I can just add LLU to everything and it should be fine. > I'm also not sure whether the type is even consistent for 32bit > and 64bit builds. > Casts are (sort of) horrid. Yeah, I don't think casts are the solution either. Lemme add LLU to everything and see how it works. Thanks. -- tejun