From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27015C4332F for ; Thu, 3 Nov 2022 11:30:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229953AbiKCLaO (ORCPT ); Thu, 3 Nov 2022 07:30:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229882AbiKCLaN (ORCPT ); Thu, 3 Nov 2022 07:30:13 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B33E1182C for ; Thu, 3 Nov 2022 04:30:12 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B266D21D04; Thu, 3 Nov 2022 11:30:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1667475010; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type; bh=7K4EyUaBFaixIgI9latIoLa1BXKgqesuuFxP/tMTlIc=; b=rDra/KeFaFLkkvY9Uya8Xvu0H3jLDrc4Om53idL7SLLA0ie++EQn+4XE+91TlQ1kwIMufi 9tnipMkTW/7qicabKlJP1+3cbiFq0yh1HfrJvfTudf9M0q3++vPNxqlUSzc0I3fPCQ493k lUcMUpSNNGeNLkLLzhAsL/ZG60+qQH0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1667475010; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type; bh=7K4EyUaBFaixIgI9latIoLa1BXKgqesuuFxP/tMTlIc=; b=7NRxdv5/mTFPflsimWgQ05hgJv4SfIRkUqrtnka31RAIlWeGGtqJ9oD4m6npTV96Mf9+MM p23GGNc0nGsJqwBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5CEB613480; Thu, 3 Nov 2022 11:30:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2lpvFUKmY2N2GwAAMHmgww (envelope-from ); Thu, 03 Nov 2022 11:30:10 +0000 Date: Thu, 3 Nov 2022 12:30:08 +0100 From: Petr Vorel To: netdev@vger.kernel.org Cc: "David S. Miller" , Michal Kubecek , Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= , David Ahern , Paolo Abeni , Eric Dumazet , Jakub Kicinski , Xin Long , Vasiliy Kulikov , Hideaki YOSHIFUJI Subject: ping (iputils) review (call for help) Message-ID: Reply-To: Petr Vorel MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, I'm sorry to bother you about userspace. I'm preparing new iputils release and I'm not sure about these two patches. As there has been many regressions, review from experts is more than welcome. If you have time to review them, it does not matter if you post your comments/RBT in github or here (as long as you keep Cc me so that I don't overlook it). BTW I wonder if it make sense to list Hideaki YOSHIFUJI as NETWORKING IPv4/IPv6 maintainer. If I'm not mistaken, it has been a decade since he was active. * ping: Call connect() before sending/receiving https://github.com/iputils/iputils/pull/391 => I did not even knew it's possible to connect to ping socket, but looks like it works on both raw socket and on ICMP datagram socket. * ping: revert "ping: do not bind to device when destination IP is on device https://github.com/iputils/iputils/pull/396 => the problem has been fixed in mainline and stable/LTS kernels therefore I suppose we can revert cc44f4c as done in this PR. It's just a question if we should care about people who run new iputils on older (unfixed) kernels. Kind regards, Petr