From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2200C4332F for ; Thu, 3 Nov 2022 20:39:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229487AbiKCUjg (ORCPT ); Thu, 3 Nov 2022 16:39:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbiKCUjf (ORCPT ); Thu, 3 Nov 2022 16:39:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF7C6DFFB for ; Thu, 3 Nov 2022 13:39:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 97EAFB82A04 for ; Thu, 3 Nov 2022 20:39:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85618C433C1; Thu, 3 Nov 2022 20:39:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667507971; bh=RHAZe3GqgR+VgFxzGfLlFgwffbK+mipPN01FLSK7k8E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c475ZXwDXYcU1B1/IoE7sNlRQy6OhTPQPzrOqlFpLvlCFgLJXWsEmUhWu4W0umeLX IkN9H7oC1UiIQuEViRegZvB5rEA3duHDLdlQIDTBhxJ4vpbaqVpC578ct/BxqCVP+E toH9SI+ACwLVqaO/ik0TOi8EC018fGhzsQ6k1S5f2qhQdFxdRYeVIW7TpFYsCzk/WU 5kX507Ji0g/ThuEpJDC9z5YL7J1Ypzngz327IoqrJTBLHB4lvk4kSt2kpzfALXFHmh g2uhUme5dp9GBWDfD3ZlbGREm0C95KKiQG08Xj1qcoeHXDDOL+DTeplnG8TKfG6lRI ral10Qxl/LxBA== Date: Thu, 3 Nov 2022 14:39:27 -0600 From: Keith Busch To: Mikulas Patocka Cc: Keith Busch , linux-block@vger.kernel.org, dm-devel@redhat.com, axboe@kernel.dk, stefanha@redhat.com, ebiggers@kernel.org, me@demsh.org Subject: Re: [PATCH 0/3] fix direct io errors on dm-crypt Message-ID: References: <20221103152559.1909328-1-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Nov 03, 2022 at 12:33:19PM -0400, Mikulas Patocka wrote: > Hi > > The patchset seems OK - but dm-integrity also has a limitation that the > bio vectors must be aligned on logical block size. > > dm-writecache and dm-verity seem to handle unaligned bioset, but you > should check them anyway. > > I'm not sure about dm-log-writes. Yeah, dm-integrity definitly needs it too. This is easy enough to use the same io_hint that I added for dm-crypt. dm-log-writes is doing some weird things with writes that I don't think would work with some low level drivers without the same alignment constraint. The other two appear to handle this fine, but I'll run everything through some focused test cases to be sure. In the meantime, do you want to see the remaining mappers fixed in a v2, or are you okay if they follow after this series? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33E6FC4332F for ; Fri, 4 Nov 2022 06:50:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667544612; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=2EbQp2drCXeT48ebocBCwzAdy9covQN69e1c3fn0M48=; b=OBL2QG+Pydnz3oTecnCgRQszCwJh63xi8jS8vs/ofATs/scoV1ffy+8XuPln9KW+QKdlZb N5Cl+QV+thfLDmkSDiw/iaQB5LwM4AwwkKG4QLaIjJo7zJhjRSBC0eU/FLk0nFQw38k9Fo 5KbRsS+U4B4I7SbQyqwmbD+IflV5tMo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-624--dEoY_DfNAehU-n2ZE25qw-1; Fri, 04 Nov 2022 02:50:10 -0400 X-MC-Unique: -dEoY_DfNAehU-n2ZE25qw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AEE7C185A7B0; Fri, 4 Nov 2022 06:50:08 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9BC56403161; Fri, 4 Nov 2022 06:50:08 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 895FB194705A; Fri, 4 Nov 2022 06:50:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 28D9E1946594 for ; Thu, 3 Nov 2022 20:39:38 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EC3B81400C3A; Thu, 3 Nov 2022 20:39:37 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E58C01401C23 for ; Thu, 3 Nov 2022 20:39:37 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CBA5985A5B6 for ; Thu, 3 Nov 2022 20:39:37 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-483-pS0iFP10NUGC16vTnm9vqQ-1; Thu, 03 Nov 2022 16:39:36 -0400 X-MC-Unique: pS0iFP10NUGC16vTnm9vqQ-1 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 83C46B8277B; Thu, 3 Nov 2022 20:39:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85618C433C1; Thu, 3 Nov 2022 20:39:30 +0000 (UTC) Date: Thu, 3 Nov 2022 14:39:27 -0600 From: Keith Busch To: Mikulas Patocka Message-ID: References: <20221103152559.1909328-1-kbusch@meta.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mailman-Approved-At: Fri, 04 Nov 2022 06:50:05 +0000 Subject: Re: [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, ebiggers@kernel.org, Keith Busch , linux-block@vger.kernel.org, dm-devel@redhat.com, stefanha@redhat.com, me@demsh.org Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Nov 03, 2022 at 12:33:19PM -0400, Mikulas Patocka wrote: > Hi > > The patchset seems OK - but dm-integrity also has a limitation that the > bio vectors must be aligned on logical block size. > > dm-writecache and dm-verity seem to handle unaligned bioset, but you > should check them anyway. > > I'm not sure about dm-log-writes. Yeah, dm-integrity definitly needs it too. This is easy enough to use the same io_hint that I added for dm-crypt. dm-log-writes is doing some weird things with writes that I don't think would work with some low level drivers without the same alignment constraint. The other two appear to handle this fine, but I'll run everything through some focused test cases to be sure. In the meantime, do you want to see the remaining mappers fixed in a v2, or are you okay if they follow after this series? -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel