From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB6D5C4332F for ; Fri, 4 Nov 2022 05:14:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230127AbiKDFOm (ORCPT ); Fri, 4 Nov 2022 01:14:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229563AbiKDFOm (ORCPT ); Fri, 4 Nov 2022 01:14:42 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7CDA126 for ; Thu, 3 Nov 2022 22:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KtnH4lY7eWCbdXk4ptyVJPyTaXTOdaPt3O3731FV9hg=; b=hxMGLirp7MKACIB12emHuxiujU 2pDG1iyhaNmYKrVJRaftU3JHA4Mfy8bXgylUnse7+1wXwUZK9686wuUbxw5+rU4mEF9fbUMEoj3r7 CIwF/OMfM63VStvVHgIYlwdEdCr4t1XlhRH1vgGCREbuxzUE0BUM8JBOfnw6NO7cZHkT5vo+gkdGO VVfOjQ5SQ/x7aBpDiyQWpNDajd/YiyPX7rtYcQGt8MEqBQvTM8lo6FifkkheK6mpaBWh6ezV94G7+ hR/GmKLV9k7T2wY3vj/diFfd1410serE39zs4NwFb1Ct2qjYedZ3YoBGc3551U1ZZ9cdAKKb7wZvJ cSJDAtkA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqp2M-002Q3k-4A; Fri, 04 Nov 2022 05:14:38 +0000 Date: Thu, 3 Nov 2022 22:14:38 -0700 From: Christoph Hellwig To: Keith Busch Cc: linux-block@vger.kernel.org, dm-devel@redhat.com, axboe@kernel.dk, stefanha@redhat.com, ebiggers@kernel.org, me@demsh.org, mpatocka@redhat.com, Keith Busch Subject: Re: [PATCH 1/3] block: make dma_alignment a stacking queue_limit Message-ID: References: <20221103152559.1909328-1-kbusch@meta.com> <20221103152559.1909328-2-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221103152559.1909328-2-kbusch@meta.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Nov 03, 2022 at 08:25:57AM -0700, Keith Busch wrote: > From: Keith Busch > > Device mappers had always been getting the default 511 dma mask, but > the underlying device might have a larger alignment requirement. Since > this value is used to determine alloweable direct-io alignment, this > needs to be a stackable limit. This can also remove the just added blk_queue_dma_alignment in nvme_mpath_alloc_disk again as it is right next to the blk_set_stacking_limits call. Otherwise looks good: Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 125CDC4332F for ; Fri, 4 Nov 2022 06:03:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667541833; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=4tRftJ4OoHSG172buhtQkyMaFmstzLuoNQokO0tUWu0=; b=JCTkFzuepTgN06NlQhOCcVeYbrTTwQo5smprAusT2xyX1mfAR9MhpRpW4KxuK2MuELfi4S 4Ua8kPFJFP6Cy2QQ49i97m2+dMAghOdR6Eanf7NftZ6pYeRyMjBxp+prWMteQFJzWnpKKW YS5gO05AmmSWQ5wuNHtpPtpj8ibNy5A= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-589-3YkU33EKMN2_18BVqNxP-g-1; Fri, 04 Nov 2022 02:03:50 -0400 X-MC-Unique: 3YkU33EKMN2_18BVqNxP-g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9B19B1C0513F; Fri, 4 Nov 2022 06:03:48 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9EAB92024CBF; Fri, 4 Nov 2022 06:03:47 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6CE571946597; Fri, 4 Nov 2022 06:03:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3D8031946594 for ; Fri, 4 Nov 2022 06:03:43 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id DF3A91121330; Fri, 4 Nov 2022 06:03:42 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D825F1121325 for ; Fri, 4 Nov 2022 06:03:42 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B869E299E768 for ; Fri, 4 Nov 2022 06:03:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-626-zXwjgM88NCq5lV1TNP7k6A-1; Fri, 04 Nov 2022 02:03:41 -0400 X-MC-Unique: zXwjgM88NCq5lV1TNP7k6A-1 Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqp2M-002Q3k-4A; Fri, 04 Nov 2022 05:14:38 +0000 Date: Thu, 3 Nov 2022 22:14:38 -0700 From: Christoph Hellwig To: Keith Busch Message-ID: References: <20221103152559.1909328-1-kbusch@meta.com> <20221103152559.1909328-2-kbusch@meta.com> MIME-Version: 1.0 In-Reply-To: <20221103152559.1909328-2-kbusch@meta.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Subject: Re: [dm-devel] [PATCH 1/3] block: make dma_alignment a stacking queue_limit X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, ebiggers@kernel.org, linux-block@vger.kernel.org, dm-devel@redhat.com, mpatocka@redhat.com, stefanha@redhat.com, Keith Busch , me@demsh.org Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Nov 03, 2022 at 08:25:57AM -0700, Keith Busch wrote: > From: Keith Busch > > Device mappers had always been getting the default 511 dma mask, but > the underlying device might have a larger alignment requirement. Since > this value is used to determine alloweable direct-io alignment, this > needs to be a stackable limit. This can also remove the just added blk_queue_dma_alignment in nvme_mpath_alloc_disk again as it is right next to the blk_set_stacking_limits call. Otherwise looks good: Reviewed-by: Christoph Hellwig -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel