All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Veerasenareddy Burru <vburru@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	lironh@marvell.com, aayarekar@marvell.com, sedara@marvell.com,
	sburla@marvell.com, linux-doc@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 1/9] octeon_ep: wait for firmware ready
Date: Mon, 7 Nov 2022 10:18:53 +0200	[thread overview]
Message-ID: <Y2i/bdCAgQa95du8@unreal> (raw)
In-Reply-To: <20221107072524.9485-2-vburru@marvell.com>

On Sun, Nov 06, 2022 at 11:25:15PM -0800, Veerasenareddy Burru wrote:
> Make driver initialize the device only after firmware is ready
>  - add async device setup routine.
>  - poll firmware status register.
>  - once firmware is ready, call async device setup routine.

Please don't do it. It is extremely hard to do it right. The proposed
code that has combination of atomics used as a locks together with absence
of proper locking from PCI and driver cores supports my claim.

Thanks

  reply	other threads:[~2022-11-07  8:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07  7:25 [PATCH net-next 0/9] octeon_ep: Update PF mailbox for VF Veerasenareddy Burru
2022-11-07  7:25 ` [PATCH net-next 1/9] octeon_ep: wait for firmware ready Veerasenareddy Burru
2022-11-07  8:18   ` Leon Romanovsky [this message]
2022-11-14 20:47     ` [EXT] " Veerasenareddy Burru
2022-11-15  9:04       ` Leon Romanovsky
2022-11-07  7:25 ` [PATCH net-next 2/9] octeon_ep: poll for control messages Veerasenareddy Burru
2022-11-07  7:25 ` [PATCH net-next 3/9] octeon_ep: control mailbox for multiple PFs Veerasenareddy Burru
2022-11-07  7:25 ` [PATCH net-next 4/9] octeon_ep: enhance control mailbox for VF support Veerasenareddy Burru
2022-11-07  7:25 ` [PATCH net-next 5/9] octeon_ep: support asynchronous notifications Veerasenareddy Burru
2022-11-07  7:25 ` [PATCH net-next 6/9] octeon_ep: control mbox support for VF stats and link info Veerasenareddy Burru
2022-11-07  7:25 ` [PATCH net-next 7/9] octeon_ep: add SRIOV VF creation Veerasenareddy Burru
2022-11-07  8:13   ` Leon Romanovsky
2022-11-07  7:25 ` [PATCH net-next 8/9] octeon_ep: add PF-VF mailbox communication Veerasenareddy Burru
2022-11-07  7:25 ` [PATCH net-next 9/9] octeon_ep: add heartbeat monitor Veerasenareddy Burru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2i/bdCAgQa95du8@unreal \
    --to=leon@kernel.org \
    --cc=aayarekar@marvell.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lironh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sburla@marvell.com \
    --cc=sedara@marvell.com \
    --cc=vburru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.