From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A21AC433FE for ; Tue, 8 Nov 2022 13:47:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F33AB84F72; Tue, 8 Nov 2022 14:47:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Y134LaOK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2CD5E84F4D; Tue, 8 Nov 2022 14:47:54 +0100 (CET) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BF01784F7D for ; Tue, 8 Nov 2022 14:47:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wr1-x429.google.com with SMTP id g12so21013935wrs.10 for ; Tue, 08 Nov 2022 05:47:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3nkzYHJ4ZgBsp3zEJUFtdi8xvH93OaQPwg07XyQtpBQ=; b=Y134LaOKJ3uSfl06n97kzeAAR+U2Xf0k7srCkw7EiiYRy2z9oz8DXiZqoQIf6oefNv 9TT7LYxehywCPr7+y4tZAffTvfL3lSJVIq4Glw5xQckyQ0tpZllBsZ9xgG6sufbC/tCI CBA1mF1/qo/N3IcmLblkhQpAiFHPBkcsevGsIOEu20nrQXNb6FrcGMtv6n5tMuRtHWyT 1LjUktiwJMZ6W3I12eQ8dzF9f9WMWshLmsqOkpT0fJelVpdP/zVQf3TnKkbesztqbDNa uIq38OsFfY8ZdjChgsBu1pO4GyD6hegELFRiY0s8ShHc8B+20CjH9ma+qThN/Vdrbi25 OvKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3nkzYHJ4ZgBsp3zEJUFtdi8xvH93OaQPwg07XyQtpBQ=; b=Z3GnNWm2bF6nXb48CinmXpLjZThw9kCFirBGZ+zDlJ3X2IkSnLdmOG5aFZxg4XR367 1jZwcUqINACI2qd1VU0hSIpJDaZ2tCLy6liVTykkpE4COYcL4XBBrdahbs9q+4FpCCKy ln39mHtI9jQCR1MJzJLyIvAGSXGjqOcu1DjcM8qF4syipXAeHZgEJcLsg445sEikn6+E qPzgtZgy5sJ2aSOrEnjQZMmh1+rf9NLncUxfrEdKg+CJW2wKKREqYuQNhPUltjAvlc0h LJHacSJSbX/hBGiInTAY4os5xDUtVMN8Ue/9r4HyuCkqFxSC+OJeHzuZkmEluIc9OJYe wHxA== X-Gm-Message-State: ACrzQf3tx1ijeIErFS7oqSBRWV5AiK9BdJlVD687xERnwz3OOR+91GVh iuL98h4SaTqezqxTaD08RXZ56g== X-Google-Smtp-Source: AMsMyM7ADp3oC3z2whVnh3BUglZ4lVT7in4M9M7kwccrY4zwtXzBQGBQXTeVlAttrQLcT5Yf8jYp5g== X-Received: by 2002:adf:fa8d:0:b0:236:bb9c:45e4 with SMTP id h13-20020adffa8d000000b00236bb9c45e4mr33279169wrr.216.1667915270304; Tue, 08 Nov 2022 05:47:50 -0800 (PST) Received: from hera (ppp046103046165.access.hol.gr. [46.103.46.165]) by smtp.gmail.com with ESMTPSA id h8-20020a05600c350800b003c6f426467fsm15881827wmq.40.2022.11.08.05.47.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 05:47:49 -0800 (PST) Date: Tue, 8 Nov 2022 15:47:46 +0200 From: Ilias Apalodimas To: Abdellatif El Khlifi Cc: Drew.Reed@arm.com, achin.gupta@arm.com, jens.wiklander@linaro.org, nd@arm.com, sjg@chromium.org, trini@konsulko.com, u-boot@lists.denx.de, vishnu.banavath@arm.com, xueliang.zhong@arm.com Subject: Re: [PATCH v7 02/10] lib: uuid: introduce uuid_str_to_le_bin function Message-ID: References: <20221013103857.614-1-abdellatif.elkhlifi@arm.com> <20221107192055.21669-1-abdellatif.elkhlifi@arm.com> <20221107192055.21669-3-abdellatif.elkhlifi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221107192055.21669-3-abdellatif.elkhlifi@arm.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Abdellatif, On Mon, Nov 07, 2022 at 07:20:47PM +0000, Abdellatif El Khlifi wrote: > convert UUID string to little endian binary data > > Signed-off-by: Abdellatif El Khlifi > Cc: Tom Rini > Cc: Simon Glass > Cc: Ilias Apalodimas > Cc: Jens Wiklander > > --- > > Changelog: > =============== > > v7: > > * rename be_uuid_str_to_le_bin() to uuid_str_to_le_bin() > * make uuid_str_to_le_bin() implementation similar to uuid_str_to_bin() > by using same APIs > > v4: > > * rename ffa_uuid_str_to_bin to be_uuid_str_to_le_bin and put in > a standalone commit (the current) > > v3: > > * introduce ffa_uuid_str_to_bin (provided by > arm_ffa: introduce Arm FF-A low-level driver) > > include/uuid.h | 8 ++++++++ > lib/uuid.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 54 insertions(+) > > diff --git a/include/uuid.h b/include/uuid.h > index 4a4883d3b5..293a8eb0a5 100644 > --- a/include/uuid.h > +++ b/include/uuid.h > @@ -2,6 +2,8 @@ > /* > * Copyright (C) 2014 Samsung Electronics > * Przemyslaw Marczak > + * (C) Copyright 2022 ARM Limited > + * Abdellatif El Khlifi > */ > #ifndef __UUID_H__ > #define __UUID_H__ > @@ -44,4 +46,10 @@ int uuid_guid_get_bin(const char *guid_str, unsigned char *guid_bin); > const char *uuid_guid_get_str(const unsigned char *guid_bin); > void gen_rand_uuid(unsigned char *uuid_bin); > void gen_rand_uuid_str(char *uuid_str, int str_format); > + > +/** > + * uuid_str_to_le_bin - Converts a UUID string to little endian binary data > + */ > +int uuid_str_to_le_bin(const char *uuid_str, unsigned char *uuid_bin); > + > #endif > diff --git a/lib/uuid.c b/lib/uuid.c > index 465e1ac38f..cde5ae2bb7 100644 > --- a/lib/uuid.c > +++ b/lib/uuid.c > @@ -1,6 +1,8 @@ > // SPDX-License-Identifier: GPL-2.0+ > /* > * Copyright 2011 Calxeda, Inc. > + * (C) Copyright 2022 ARM Limited > + * Abdellatif El Khlifi > */ > > #include > @@ -346,6 +348,50 @@ int uuid_str_to_bin(const char *uuid_str, unsigned char *uuid_bin, > return 0; > } > > +/** > + * uuid_str_to_le_bin() - Convert string UUID to little endian binary data. > + * @uuid_str: pointer to UUID string > + * @uuid_bin: pointer to allocated array for little endian output [16B] > + * > + * UUID string is 36 characters (36 bytes): > + * > + * xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx > + * > + * where x is a hexadecimal character. Fields are separated by '-'s. > + * When converting to a little endian binary UUID, the string fields are reversed. > + * > + * Return: > + * > + * uuid_bin filled with little endian UUID data > + * On success 0 is returned. Otherwise, failure code. > + */ > +int uuid_str_to_le_bin(const char *uuid_str, unsigned char *uuid_bin) > +{ > + u16 tmp16; > + u32 tmp32; > + u64 tmp64; > + > + if (!uuid_str_valid(uuid_str) || !uuid_bin) > + return -EINVAL; > + > + tmp32 = cpu_to_le32(hextoul(uuid_str, NULL)); > + memcpy(uuid_bin, &tmp32, 4); > + > + tmp16 = cpu_to_le16(hextoul(uuid_str + 9, NULL)); > + memcpy(uuid_bin + 4, &tmp16, 2); > + > + tmp16 = cpu_to_le16(hextoul(uuid_str + 14, NULL)); > + memcpy(uuid_bin + 6, &tmp16, 2); > + > + tmp16 = cpu_to_le16(hextoul(uuid_str + 19, NULL)); > + memcpy(uuid_bin + 8, &tmp16, 2); > + > + tmp64 = cpu_to_le64(hextoul(uuid_str + 24, NULL)); > + memcpy(uuid_bin + 10, (char *)&tmp64, 6); The cast isn't needed here > + > + return 0; > +} > + > /* > * uuid_bin_to_str() - convert big endian binary data to string UUID or GUID. > * > -- > 2.17.1 >