From: Sakari Ailus <sakari.ailus@iki.fi>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-media@vger.kernel.org,
'Linux Samsung SOC' <linux-samsung-soc@vger.kernel.org>,
Daniel Scally <djrscally@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH] media: exynos4-is: don't rely on the v4l2_async_subdev internals
Date: Wed, 9 Nov 2022 11:29:41 +0200 [thread overview]
Message-ID: <Y2tzBUXHnZmZNClM@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <fa77dbaa-e62a-b365-3b54-357e2074932f@samsung.com>
Hi Marek,
On Tue, Nov 08, 2022 at 03:14:14PM +0100, Marek Szyprowski wrote:
> On 05.10.2022 16:47, Sylwester Nawrocki wrote:
> > On 23.09.2022 11:42, Marek Szyprowski wrote:
> >> Commit 1f391df44607 ("media: v4l2-async: Use endpoints in
> >> __v4l2_async_nf_add_fwnode_remote()") changed the data that is stored in
> >> the v4l2_async_subdev internals from the fwnode pointer to the parent
> >> device to the fwnode pointer to the matched endpoint. This broke the
> >> sensor matching code, which relied on the particular fwnode data in the
> >> v4l2_async_subdev internals. Fix this by simply matching the
> >> v4l2_async_subdev pointer, which is already available there.
> >>
> >> Reported-by: Daniel Scally <djrscally@gmail.com>
> >> Fixes: fa91f1056f17 ("[media] exynos4-is: Add support for asynchronous subdevices registration")
> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>
> Gentle ping for merging this fix.
It's in my PR to Mauro:
<URL:https://patchwork.linuxtv.org/project/linux-media/patch/Y1uVp8hHo7DYUK82@valkosipuli.retiisi.eu/>
--
Sakari Ailus
next prev parent reply other threads:[~2022-11-09 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220923094232eucas1p1deb3985c9637a0876609c75967175e9b@eucas1p1.samsung.com>
2022-09-23 9:42 ` [PATCH] media: exynos4-is: don't rely on the v4l2_async_subdev internals Marek Szyprowski
2022-09-23 20:35 ` Daniel Scally
2022-10-05 14:47 ` Sylwester Nawrocki
2022-11-08 14:14 ` Marek Szyprowski
2022-11-09 9:29 ` Sakari Ailus [this message]
2022-11-09 10:30 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2tzBUXHnZmZNClM@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=djrscally@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.