From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBAE4C4332F for ; Wed, 9 Nov 2022 14:59:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230392AbiKIO7M (ORCPT ); Wed, 9 Nov 2022 09:59:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229678AbiKIO7K (ORCPT ); Wed, 9 Nov 2022 09:59:10 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27D04121 for ; Wed, 9 Nov 2022 06:59:09 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id D96BE1FAE9; Wed, 9 Nov 2022 14:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1668005947; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oYtWekrwOkPu3rl9s9CI8gzCVVn5E+80FelDen93dc4=; b=feQaiqc9Dr7Wr/7W8mpDhyggKmsP/rnWP+vWENGkVL7vjXTcEGxxMWXR7S0TIDaHEG7gKi 4Acqwl1E6Qzn5PAlwjr43Bc8/N3AceZbIEbO3kFkFz3e4IgJ3hAVcmDMx3gMklp/1THWPv B6u2l292MiZnFHqbGTZmrELcfNylHmQ= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id C07052C141; Wed, 9 Nov 2022 14:59:05 +0000 (UTC) Date: Wed, 9 Nov 2022 15:59:05 +0100 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, Jason Wessel , Daniel Thompson , Douglas Anderson , Luis Chamberlain , Aaron Tomlin , kgdb-bugreport@lists.sourceforge.net Subject: Re: [PATCH printk v3 10/40] kdb: kdb_io: use console_is_enabled() Message-ID: References: <20221107141638.3790965-1-john.ogness@linutronix.de> <20221107141638.3790965-11-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221107141638.3790965-11-john.ogness@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2022-11-07 15:22:08, John Ogness wrote: > Replace (console->flags & CON_ENABLED) usage with console_is_enabled(). > > Signed-off-by: John Ogness > Reviewed-by: Petr Mladek > Reviewed-by: Douglas Anderson > --- > kernel/debug/kdb/kdb_io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c > index 67d3c48a1522..550fe8b456ec 100644 > --- a/kernel/debug/kdb/kdb_io.c > +++ b/kernel/debug/kdb/kdb_io.c > @@ -559,7 +559,7 @@ static void kdb_msg_write(const char *msg, int msg_len) > } > > for_each_console(c) { > - if (!(c->flags & CON_ENABLED)) > + if (!console_is_enabled(c)) Same as with the 9th patch. I would prefer to merge this with the patch switching to the srcu console list iterator. It will explain why the racy check is needed here. This change does not make sense without the other. Best Regards, Petr