From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E932C433FE for ; Thu, 24 Nov 2022 15:41:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229828AbiKXPlZ (ORCPT ); Thu, 24 Nov 2022 10:41:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229834AbiKXPlN (ORCPT ); Thu, 24 Nov 2022 10:41:13 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E119A12BFCE for ; Thu, 24 Nov 2022 07:41:12 -0800 (PST) Received: from zn.tnic (p200300ea9733e75b329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e75b:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 77D7E1EC0495; Thu, 24 Nov 2022 16:41:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1669304471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=MjlmGKD7Cl7QwdM1GSOW1hqqMdGYXCBKr+XtB8i4H0Y=; b=Ir7wUj29hUggP2JYbWU3vro70Rlrnq91Vv1vXNfsYkH+XgMd4yoVLqb8vvo1I8XOyJRjm3 vhUUKJ5tNXQ93D5ChMF/v3V/o2j2don5aRo43tHDB+tycH5xbd4xTZKSadVSkM3kESxIOk BqngnrKRkMgIG6ISHEjmLdYKxUNIC60= Date: Thu, 24 Nov 2022 16:41:11 +0100 From: Borislav Petkov To: Petr Pavlu Cc: tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, nicolas@fjasle.eu, masahiroy@kernel.org, kirill.shutemov@linux.intel.com, tony.luck@intel.com, michael.roth@amd.com, nathan@kernel.org, ndesaulniers@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86: Avoid relocation information in final vmlinux Message-ID: References: <20220927084632.14531-1-petr.pavlu@suse.com> <1af5ee66-5ab1-45b2-f229-182f89dc6b94@suse.com> <765e1e78-c540-0753-7a19-7d335bcc998b@suse.com> <1cc97d84-da4d-c8cc-dbcd-fcdc34c6d11c@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1cc97d84-da4d-c8cc-dbcd-fcdc34c6d11c@suse.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 24, 2022 at 02:33:28PM +0100, Petr Pavlu wrote: > If the before case is with RANDOMIZE_BASE=n and the after case is with > RANDOMIZE_BASE=y then it makes sense the resulting sizes are similar. With > RANDOMIZE_BASE=n, vmlinux is linked without --emit-relocs and so there will be > no relocation sections at all. With RANDOMIZE_BASE=y and my patch, the > sections get created but are stripped eventually. The increased size in the > second case is likely due to the logic to support the relocation process. This is in both cases with your patch, once with RANDOMIZE_BASE=y and once with RANDOMIZE_BASE=n. IOW, your patch actually makes my vmlinux bigger by 51K. IOW, I cannot reproduce your | Configuration | With relocs | Stripped relocs | | x86_64_defconfig | 70 MB | 43 MB | claim, but not with a defconfig but with my specially tailored config. I guess the next thing I'll try is without your patch. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette