From: Tony Lindgren <tony@atomide.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
b-liu@ti.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: musb: remove extra check in musb_gadget_vbus_draw
Date: Wed, 23 Nov 2022 09:12:56 +0200 [thread overview]
Message-ID: <Y33H+Pqf3QoN8/IM@atomide.com> (raw)
In-Reply-To: <Y3z0nvoyiHQZ3MnY@kroah.com>
* Greg KH <gregkh@linuxfoundation.org> [221122 16:01]:
> On Mon, Nov 14, 2022 at 10:59:47AM +0200, Ivaylo Dimitrov wrote:
> > The check for musb->xceiv->set_power duplicates the check done in
> > usb_phy_set_power(). Moreover, not calling usb_phy_set_power() results in
> > current USB config max current not being propagated through usb_charger FW
>
> What does "FW" mean here?
>
> >
> > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> > ---
> > drivers/usb/musb/musb_gadget.c | 2 --
> > 1 file changed, 2 deletions(-)
>
> And is this a bugfix? If so, what commit id does it fix? Should it go
> to stable kernels? What hardware was this tested on that this solved a
> problem for?
>
> Please fix this and send a v2.
Ivaylo please also test with the musb phy changes in Linux next that might
affect this patch.
Regards,
Tony
next prev parent reply other threads:[~2022-11-23 7:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 8:59 [PATCH] usb: musb: remove extra check in musb_gadget_vbus_draw Ivaylo Dimitrov
2022-11-22 16:11 ` Greg KH
2022-11-23 7:12 ` Tony Lindgren [this message]
2022-11-25 18:21 ` [PATCH v2] " Ivaylo Dimitrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y33H+Pqf3QoN8/IM@atomide.com \
--to=tony@atomide.com \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.