From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB7ABC4332F for ; Tue, 13 Dec 2022 18:20:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236363AbiLMSUR (ORCPT ); Tue, 13 Dec 2022 13:20:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236256AbiLMSUP (ORCPT ); Tue, 13 Dec 2022 13:20:15 -0500 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54CC618B; Tue, 13 Dec 2022 10:20:14 -0800 (PST) Received: by mail-pf1-x430.google.com with SMTP id g1so2797145pfk.2; Tue, 13 Dec 2022 10:20:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=12L7Z+MEDZZwbqdCC2cbVjIty7N4/EBKUaDawJXCP64=; b=Obe3K9oqhURedPlDLQyxc4+H7IMBElvpTTJ5KnsfHhRpClEgYnRBwiilY0sPViIrYR m2N+yHYkDX1D1odshVfvZQaWTbooGMdeU202FuS6zqOB2oHiUMcprJzsWM94WBqXzOp2 /YEU3wTQLNjO/tqkHrDYb9mx2C9gU0EgUL/EmKcBhwhIlFy9d98534d5NO8g2wYdrBLn uPTIZdudDIBek4aVxg1UjIiX+PKNiJZlJ343w/Y/b6GblBLCVSfxJckDxcuG605hIMy5 3q+jmwUozeRcA9t0fPKe9fyMustqF12DrWzPs6hrSehbuUb3dNS9UDtShUY58eaW4EXJ Goiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=12L7Z+MEDZZwbqdCC2cbVjIty7N4/EBKUaDawJXCP64=; b=gZVyQGhPJnOiotZIXV7menEQxF5HMIVHNoHxJCDoIweWeClAi7M5VamScqCNvRqSxP kogEJfhfLtdrpoyCmIpE6MCWJZq+ANxRvrtplzN02s9mQj5RvrAhx4fURltI8/vqV6Qi ARY4DBrZY7YrOcKaKn9VkSMzArX0KF51u125Y4i/D45kMV0kGHXUgfpmRr/iVX+WzRqe RJVM2iJV74CCeIsySN3+tsYaQ4Or23Osefaux2Rc36zJEM4YUDCqUWURatvLgTIk7/UY eyrBoLRPOLkNJNJPLT6xCYbLNIDyDyj+hfL556zZrk7ae3FLMkiRXkLj4wvMrD2s69W0 QkMg== X-Gm-Message-State: ANoB5pnHaIjdyCa0G2cSHCxWtVMQEYmYfPwov4miRivE74Rap/ZWTaCC 6ENubmAWJGqf4YjqmEdrdl0= X-Google-Smtp-Source: AA0mqf7B/t8kQ8DMVePJFYIFKLlu1ypmHi38pqTVS5zUqPpl3q21s9Zh62nS/l0TMxjP/CXn5w0Xfw== X-Received: by 2002:a62:fb11:0:b0:56c:3696:ad68 with SMTP id x17-20020a62fb11000000b0056c3696ad68mr21069016pfm.8.1670955613572; Tue, 13 Dec 2022 10:20:13 -0800 (PST) Received: from localhost (c-73-164-155-12.hsd1.wa.comcast.net. [73.164.155.12]) by smtp.gmail.com with ESMTPSA id f136-20020a62388e000000b00574679561b4sm7946846pfa.134.2022.12.13.10.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 10:20:13 -0800 (PST) Date: Wed, 23 Nov 2022 12:31:28 +0000 From: Bobby Eshleman To: Stefano Garzarella Cc: "Michael S. Tsirkin" , Bobby Eshleman , Cong Wang , Krasnov Arseniy , Jiang Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Eric Dumazet , Stefan Hajnoczi , kvm@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" Subject: Re: [PATCH net-next v6] virtio/vsock: replace virtio_vsock_pkt with sk_buff Message-ID: References: <20221213072549.1997724-1-bobby.eshleman@bytedance.com> <20221213102232.n2mc3y7ietabncax@sgarzare-redhat> <20221213100510-mutt-send-email-mst@kernel.org> <20221213154304.rjrwzbv6jywkrpxq@sgarzare-redhat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221213154304.rjrwzbv6jywkrpxq@sgarzare-redhat> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 13, 2022 at 04:43:04PM +0100, Stefano Garzarella wrote: > On Tue, Dec 13, 2022 at 10:06:23AM -0500, Michael S. Tsirkin wrote: > > On Tue, Dec 13, 2022 at 11:22:32AM +0100, Stefano Garzarella wrote: > > > > + if (len <= GOOD_COPY_LEN && !skb_queue_empty_lockless(&vvs->rx_queue)) { > > > > > > Same here. > > > > > > If there are no major changes to be made, I think the next version is the > > > final ones, though we are now in the merge window, so net-next is closed > > > [1], only RFCs can be sent [2]. > > > > > > I suggest you wait until the merge window is over (two weeks usually) to > > > send the next version. > > > > Nah, you never know, could be more comments. And depending on the timing > > I might be able to merge it. > > Right, in the end these changes are only to virtio-vsock transport, so they > can go smoothly even with your tree. > > @Bobby, so if you can fix the remaining small things, we can try to merge it > :-) > > Thanks, > Stefano Sure thing. I'll change / send now. Best, Bobby