From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1oxr7f-0001ob-VE for mharc-grub-devel@gnu.org; Wed, 23 Nov 2022 09:53:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxr7d-0001oK-MH for grub-devel@gnu.org; Wed, 23 Nov 2022 09:53:09 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxr7b-00052R-An for grub-devel@gnu.org; Wed, 23 Nov 2022 09:53:09 -0500 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ANET6QF023888 for ; Wed, 23 Nov 2022 14:53:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2022-7-12; bh=lg+4CNDCYQg8H7CqoC/JXp8jRO+9oT+VyWJLcKxHdbk=; b=LhIOvXKqaABBE5pQXxVTLM9WUx/N/zz+5S4LQKf+uByhWk06lSikTZyYFpFC9VQaB6pq IzB72Nxdtwy4gC5vV0O6RHoVPQym+C5UhnRWLlJK4JMdB/W0HOZGafpCudyTVa5KOrMO 7j4uOcic3A27Y2I0sxMB9kYdRkYsKEesjQRqp50sOlSy+EmPpDvLdzfntO+W0L1/aAiu I9A+HZ4MKes+SMqTNw7wuBBIM+52YS5MA2UJWGfkecsuyBIXi8nZqzpOdpYf1AALA5kc hfnAUqUNbaeQ3A3ftuTTK1hX6TwyUx0kS78FoDUW9+uG4EOkDx4q1UFbas2GyJrzLDHa sg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3m1mjj06nw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 23 Nov 2022 14:53:02 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2ANDIASO034563 for ; Wed, 23 Nov 2022 14:53:00 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2170.outbound.protection.outlook.com [104.47.73.170]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3kxnkcrvp6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 23 Nov 2022 14:52:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mBIbTzwInrEfD9iT3evATUMYqrQ4bbqJZKkQX4QN30nGdTCCv8dxIPq6kRKS2Yp6yTiJD0G85ATYnZG1rsbOqUxN/vvfmv8fxlHufHOwyabb7laSWSj9hVZrs+UYpaqAUbi1tQkib6LUWPWmqImS4Al5bOqvTlsAKuoQvUERUJ5uRJaleiC71wTSk1udCGajwR+l1ae9qJkbPM+wGzCgCMAi/Xxl/76HIIzdbuQs3YUclrhccRTqRl4QeHLz+kRlaKeb3I+Q38h9oqbtn4d1FAOs89pcMUyjSb64Qn9BDwhRIFxna4xLjys7YRkITgYCDz1ZMUL91z+z6+tpwHUcyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lg+4CNDCYQg8H7CqoC/JXp8jRO+9oT+VyWJLcKxHdbk=; b=JJkHEDoD//FQyhWqP71OJNWpsRgql4hA1mf+yfk87KB8NTIvIs2V0ioCJA1M690XxMjMUE0t3mChBjGHR1Pswb2CUewWYcRK2fLcwO2NnRXAYCnQ/VGbHb/+J2ALo/hgCrSyongUMlW+vuLDYVMq0lQiXVM6gAQr1vymd6UxQCBQBc0zBO5Xl4EjMpCigpPDPpMuuII3x7NB3LFQ42w8veuGx3fPvvRz2eXaw+Nfd9hwr6Myn6cqNUZ/bEfWiZ+knaNWXdzcTFQiI39Asgcpgz3LQ+THyqdfxzTfsvQVwJG7QvUqlpLjlC+55rff3DNDsxiUW1vH6A03Delw5FJ8qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lg+4CNDCYQg8H7CqoC/JXp8jRO+9oT+VyWJLcKxHdbk=; b=eObJ2mrt0Qyozcljcr6lPJARabcmSLwK4rV1rDTMFpcWRlhEVIvFUQ0QAnQCPDArAIDgO7Kc7/y26+O4CQaAOxy45NELzb2AN6M9nshkvJLTvyrMoXzsTteJDTflVxeLuKmNUipnaoJoqWSOeEf/JsOqbpAFUm3HOYXRBlhJjvA= Received: from DS7PR10MB4829.namprd10.prod.outlook.com (2603:10b6:5:38c::20) by SJ0PR10MB4702.namprd10.prod.outlook.com (2603:10b6:a03:2af::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 14:52:57 +0000 Received: from DS7PR10MB4829.namprd10.prod.outlook.com ([fe80::e426:2700:f2bd:1f55]) by DS7PR10MB4829.namprd10.prod.outlook.com ([fe80::e426:2700:f2bd:1f55%5]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 14:52:57 +0000 Date: Wed, 23 Nov 2022 15:52:50 +0100 From: Daniel Kiper To: Jagannathan Raman Cc: grub-devel@gnu.org, darren.kenny@oracle.com, ross.philipson@oracle.com, alec.r.brown@oracle.com Subject: Re: [PATCH 1/1] fs/udf: validate length of AED in grub_udf_read_block() Message-ID: References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BE1P281CA0071.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:26::16) To DS7PR10MB4829.namprd10.prod.outlook.com (2603:10b6:5:38c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR10MB4829:EE_|SJ0PR10MB4702:EE_ X-MS-Office365-Filtering-Correlation-Id: 83562ec9-1d3d-49d8-70dc-08dacd6268b1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uGu/5Ja+kdpl2fOn6YMVwU5AkmfJ9JCoLb7Zksj+OYXNZlsTO/aTfWLh+Bj9DTKdu9aFuwQOWdOmPCy6/tIMy4ubdqECa5bNEGTz+yS6PEfCDriUie4l95EM83lwm6ZBIeyIvEG18jolyz3oIb9ckeRrkFkjRhRVK/q/23iEgmhIy2xcr3asbHQdEx9LwUlG4SLCTN3pN65nUSfvRkX3XgTA/sLHDgnp2hJ+Js8IReWbaKQsAfRoRMYjJ20q8SJIvLUVjCF7w1CwukELADt5q9qdDc0bfc4SDyyQb/Bg7GCkT5gQDYsfSAOcIXWjrGcUKGrr3WiT268ULS3TKR3ILbjUdHB6a8eQ7UW5iasYBdMd8mOQP0lPeTfo6atb5pwLZes+ytuO3RDJSFolV4pxSO1x3nodGa8185HBnfmdzIwQ5qF6awJdTGzBwKG6yt6Te98d6abikaq1SOxz+xA0DwgKg0uwei8bcmTo5lvXNrMTc5eFcH7zgWZMqpl5FeDqD9V00Js354+GLzPsg5GKTSy7JbUUzMw9QTA+XbCN9dKDjyrlkz3ABdnpg0CDqpQfQ4xEKDs1wi2sLhKl2r/mrsBBzQ01obL0xTE6NOphKhWLjvgfvo3VByMsAcmSA5Ny X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS7PR10MB4829.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(136003)(376002)(346002)(39860400002)(451199015)(4326008)(41300700001)(66476007)(66556008)(8676002)(83380400001)(186003)(478600001)(66946007)(86362001)(6486002)(8936002)(6862004)(26005)(9686003)(6512007)(5660300002)(2906002)(4744005)(316002)(15650500001)(6666004)(6636002)(107886003)(38100700002)(6506007)(44832011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dxVAzDQ7S0f9800FEV6RCDs+Oep8DhF/YqK0gmS8mfe2MpAR49J/LNKfGo/d?= =?us-ascii?Q?P8YEgiNr7a6J70Fx1fR1ajhvhL9UyfLvxtuSyqmuJvGI4P7z4sNPa4AQNgwU?= =?us-ascii?Q?nROJh4fQ3qsI+JbixLZ8jl3SyJhO11BktdY4lNuTxb1W+n+DjaoBS1W9FO7Q?= =?us-ascii?Q?BbJ98CcaejBupyfqIxE2Tzpyp2xtrmXe0AogwCkTkIq7tTcmsQ6DPvr9A8GS?= =?us-ascii?Q?zccLt2DFB5iHKGkuWcH6e6NBdrGnBRR1V74iFrWMCOVi+Rjl3HFV0bQhkFIt?= =?us-ascii?Q?IZpTY5JufHLyQwcRzFsI9cW9okdCnK4Txd06KK1jkdFK6B7aBV5O9dHHmy5y?= =?us-ascii?Q?ZgjcxMNO3PhjGhXLdw2fpL7o0SXFw+WetT1IR5z5drREUeGjc1fNN6fFQyCe?= =?us-ascii?Q?CQn+1Oaqy68Bb5pz5DBXw41hG9IRzlkddUOLEj/0rClAeKSgyYX6vJJiOJGZ?= =?us-ascii?Q?Qgqr22vzzzhTV7jW+9kTKrAk2J6m8nVgDfKjqK2URSc7UL45HVSUXZp7S2CY?= =?us-ascii?Q?AjoPKPZoHIoE5KfswF/qoo7OpJ5X4IxLLjN3uHliFmLaJ6IV49YkYpeQlmD4?= =?us-ascii?Q?MrrI1mbIa1Q9jy3OeUKXcPU6hEcJ3zuCWyOlgNHuG3T6Zbx76GIYSom9YV1R?= =?us-ascii?Q?/gxHjoGr8c666AFVAEMjbPmJ1m1WeVuGDoqrWP4THj/aYQ/VvGd/mygY+Ncu?= =?us-ascii?Q?l+KtNwHlEMVUkLTaBX34u4DfwOAF3GbWKlMySGhlxuELsBUzRCQGhVAFEGh3?= =?us-ascii?Q?TVUPwuRyjLGvwx/7QyYI2zdcv2tie2cpMJXoPj6vQyVwPzfFtFrpSi/w6DKK?= =?us-ascii?Q?Qd1mqJRdHoMCquKV79xECncrVC0FQ1zSbHDj6Yj4DSvZUF6/6HFMX+2v1Qhr?= =?us-ascii?Q?XYpHqfb1Me/CYRHtVsk6QMptMxWhQulH+2/1DYpD1NySXGlPKs+EsMFBQ1du?= =?us-ascii?Q?7dTi8c1jPYF2AD9DFTskZQKi70l6pfJ80A1bZJG06QlPiYDwnFB0r6u92qXj?= =?us-ascii?Q?tW0esGJvEnUmSZaZhiXdzEWBX4jhiufugNa4guU/MsNYUvJm0JF25U5/eCe3?= =?us-ascii?Q?TgQcoTGPQUr6RLGt91xq41tRZEZln1StAJvXDQPHRkvwe/rG9CfxiXPJazWM?= =?us-ascii?Q?qPrCGZUfLeJM+zvn91uJagDu/hyH9dpAQ7vrHuUPLT5hat3PFGntL37xSKPQ?= =?us-ascii?Q?Z6sxOuxr0jDNJSZwB2dtQzhQF/yCFu7KeEOCwDyumZqKE+hEOyW5srrJYE2n?= =?us-ascii?Q?rnGvkNbIn4sfPA0VFhKQRvmTZrmm4bSmWA8xDlWxEBshPhNvLMYBY9NjcqUU?= =?us-ascii?Q?xkFcADUGXhG1PrsgC8dLhyQg3MRQ+t/M5YGqoPMQd0rDiegaj47ANw6crX12?= =?us-ascii?Q?EnNAlHvd17IsxHCto0DRuSY+qELRpzsyNsJYpPIT7lW4DR+AhPHQ+baR+M8X?= =?us-ascii?Q?4o0EfK1LXZrABIo1rZwkHOXgJpX0rgfNAm27mS8hSltcZ/N53n+If7aChWTr?= =?us-ascii?Q?mts5ypdwvaQvsbrqak2N3XR0lwGoj+t/dYmIG6oD8znF7xgzoVEMTG+7bZBx?= =?us-ascii?Q?+zubcXiAoVwricjeAaRqblDT0DHs8grOIDks8J2F?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: gB4dyHxvbBazGJ4go1W1++a6NOPBWW7BOadgVkewdFgLWSgsBYaHgLR0Z39bKFF//3ZV8Udcj36F/tdE5jYhV4GiJLP7Z61zj82WacOTAdpdPxb0ntVTNyhv5p2F2yaGFRs7O+mODzI2STeSR7SUMgZEug9dk6NHJ9k5Y5lzG5bgAMc6voEZ5nvTpglmNt/fHxNGK/xvaJD6hdKznSrV5zDICCvtp3L90lQmdK9mFhZjcpiJ6nGt91cYvz8X7YxhnIdjRvH+np5XjGllEe6ubwwFQd9BeMfdG/N27Uxnhaaw8jYJE8nGMlNR75DxYS+3O0xXAYi9nemwHWPCK5Hybxfbg/QAhftl0Sfjqw07ty1mJoabFpVLbAODD+TmWQeu3XolD/ukkMMFeTKC7GL8pHUhoZXb0cwL10k8b7L1ScvURwA3zwhuDOX8hBfk5x0yGH2FFwwDwMnPwz+8t+TupAfYfL/7wxp8kPeBTUT7QFZ5/ZNExiriRFUIVJBY5AoJibjK4dCrnrUgsTAgDuDVOCxf6h13dUK7tBxyTBg27oTzzJn04DGUNXKg92v6b65f5Fh5/T1oVXCcauAhYlGeGfLYt1RP3MR3Z4JQbC9VvQqBblzftHnCC0k1Uyo1tmUA5Lw4jQ2Sv1H680NVwBp/woEAROSQuo+wgKswW2l6/afswjzCfJ9exKluWzRnv3gw+pKjvPrfAwoBGCjGrKqYz+8soDhCYChacAsCzVNyed6qXhv+O9WHKvtNAU0BhZIc X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83562ec9-1d3d-49d8-70dc-08dacd6268b1 X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB4829.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 14:52:57.4544 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: obK1wVFIoi9bsHmT6tdt1QJshspySaLi1O4uHqzcOXsurJp7HXFW4uU3pjqDWFsqfmgN9BoYJ35K131+OdU6Ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4702 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-23_08,2022-11-23_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211230110 X-Proofpoint-GUID: N00-pd4uYFWxgYCqti0PvifX2xGFKGxW X-Proofpoint-ORIG-GUID: N00-pd4uYFWxgYCqti0PvifX2xGFKGxW Received-SPF: pass client-ip=205.220.165.32; envelope-from=daniel.kiper@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2022 14:53:10 -0000 On Thu, Nov 17, 2022 at 12:17:52AM +0000, Jagannathan Raman wrote: > Validate the length of Allocation Extent Descriptor in > grub_udf_read_block(), based on the details in UDF spec. v2.01 section > 2.3.11 > > Fixes: CID 314037 > > Signed-off-by: Jagannathan Raman Reviewed-by: Daniel Kiper Daniel