From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95BC2C46467 for ; Wed, 23 Nov 2022 15:53:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238722AbiKWPx0 (ORCPT ); Wed, 23 Nov 2022 10:53:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238772AbiKWPwz (ORCPT ); Wed, 23 Nov 2022 10:52:55 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB32457B76; Wed, 23 Nov 2022 07:52:50 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 57703B82172; Wed, 23 Nov 2022 15:52:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DFB3C433D6; Wed, 23 Nov 2022 15:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1669218768; bh=/DumSgjbm3+bFjW/YII5HB+37hZffmS6RIQzxFus23A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Axk59HaPRU6B2o8/sQ2xV/J3QDnuJbllXINFmP+zTkfGNyl9/NsBA856568zy/Zy0 ziibqVHor7E2pImZW09H3fsO0rmk5lAkiY8/xImxvEPWF1JugZkU42k7XZp/1gGlxF YjrYDdmJl0DMzZ+GHnRpj/dpCWN4eBZtN+hiAE0Q= Date: Wed, 23 Nov 2022 16:52:45 +0100 From: Greg Kroah-Hartman To: Maximilian Luz Cc: Matthew Wilcox , Andy Shevchenko , linux-kernel@vger.kernel.org, Jens Axboe , "Rafael J. Wysocki" , Len Brown , Stefan Richter , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Sean Young , Mauro Carvalho Chehab , Rob Herring , Frank Rowand , Hans de Goede , Mark Gross , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Jiri Slaby , Heikki Krogerus , "Martin K. Petersen" , Chaitanya Kulkarni , Ming Lei , Jilin Yuan , Alan Stern , Sakari Ailus , Jason Gunthorpe , Thomas Gleixner , Ira Weiny , Dan Williams , Won Chung , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-block@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux1394-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * Message-ID: References: <20221123122523.1332370-1-gregkh@linuxfoundation.org> <20221123122523.1332370-3-gregkh@linuxfoundation.org> <711d5275-7e80-c00d-0cdc-0f3d52175361@gmail.com> <97be39ed-3cea-d55a-caa6-c2652baef399@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Nov 23, 2022 at 04:48:41PM +0100, Maximilian Luz wrote: > On 11/23/22 16:37, Greg Kroah-Hartman wrote: > > On Wed, Nov 23, 2022 at 02:52:59PM +0000, Matthew Wilcox wrote: > > > On Wed, Nov 23, 2022 at 02:59:00PM +0100, Maximilian Luz wrote: > > > > On 11/23/22 14:34, Andy Shevchenko wrote: > > > > > On Wed, Nov 23, 2022 at 02:14:31PM +0100, Maximilian Luz wrote: > > > > > > On 11/23/22 13:25, Greg Kroah-Hartman wrote: > > > > > > > The uevent() callback in struct device_type should not be modifying the > > > > > > > device that is passed into it, so mark it as a const * and propagate the > > > > > > > function signature changes out into all relevant subsystems that use > > > > > > > this callback. > > > > > > > > > > [...] > > > > > > > > > > > > -static inline struct ssam_device *to_ssam_device(struct device *d) > > > > > > > +static inline struct ssam_device *to_ssam_device(const struct device *d) > > > > > > > { > > > > > > > return container_of(d, struct ssam_device, dev); > > > > > > > } > > > > > > > > > > > > I am slightly conflicted about this change as that now more or less > > > > > > implicitly drops the const. So I'm wondering if it wouldn't be better to > > > > > > either create a function specifically for const pointers or to just > > > > > > open-code it in the instance above. > > > > > > > > > > > > I guess we could also convert this to a macro. Then at least there > > > > > > wouldn't be an explicit and potentially misleading const-conversion > > > > > > indicated in the function signature. > > > > > > > > > > This is an intermediate step as far as I know since moving container_of to > > > > > recognize const is a bit noisy right now. I guess you can find a discussion > > > > > on the topic between Greg and Sakari. > > > > > > > > Thanks! I assume you are referring to the following? > > > > > > > > https://lore.kernel.org/lkml/4218173bd72b4f1899d4c41a8e251f0d@AcuMS.aculab.com/T/ > > > > > > > > As far as I can tell this is only a warning in documentation, not > > > > compile time (which would probably be impossible?). > > > > > > > > As I've said I'd be fine with converting the function to a macro (and > > > > preferably adding a similar warning like the one proposed in that > > > > thread). The point that irks me up is just that, as proposed, the > > > > function signature would now advertise a conversion that should never be > > > > happening. > > > > > > > > Having two separate functions would create a compile-time guarantee, so > > > > I'd prefer that, but I can understand if that might be considered too > > > > noisy in code. Or if there is a push to make container_of() emit a > > > > compile-time warning I'd also be perfectly happy with converting it to a > > > > macro now as that'd alleviate the need for functions in the future. > > > > > > Can't we do: > > > > > > static inline const struct ssam_device *to_ssam_device(const struct device *d) > > > { > > > return container_of(d, const struct ssam_device, dev); > > > } > > > > > > > You could, if you can always handle a const pointer coming out of this > > function, but I don't think you can. > > > > What you might want to do instead, and I'll be glad to do it for all of > > the functions like this I change, is to do what we have for struct > > device now: > > > > static inline struct device *__kobj_to_dev(struct kobject *kobj) > > { > > return container_of(kobj, struct device, kobj); > > } > > > > static inline const struct device *__kobj_to_dev_const(const struct kobject *kobj) > > { > > return container_of(kobj, const struct device, kobj); > > } > > > > /* > > * container_of() will happily take a const * and spit back a non-const * as it > > * is just doing pointer math. But we want to be a bit more careful in the > > * driver code, so manually force any const * of a kobject to also be a const * > > * to a device. > > */ > > #define kobj_to_dev(kobj) \ > > _Generic((kobj), \ > > const struct kobject *: __kobj_to_dev_const, \ > > struct kobject *: __kobj_to_dev)(kobj) > > > > > > Want me to do the same thing here as well? > > That looks great! Thanks! > > I would very much prefer that. Ok, will respin this patch as at least 2 individual patches, one that does the change to to_ssam_device() and the next that does the bus-wide changes. I'll review the other container_of() users in this patch as well to see if they can be converted as well. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFA44C47090 for ; Fri, 25 Nov 2022 21:21:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NAT2V2fFCcIA3Xk9eTqFnQLXj4UeS1cAv0qJRMfP2xk=; b=cr268YtzUyCQ3S hFhh59nikdkPY5X9PB6IB+k5eiMV828plxUUMzuWJwQ0wF++g+SEd9ZK3FP4DSYGyGOqpD4t8tEW8 VNK5HXN25BR+ISXVLh4Jexmia8nLIA9aJyBa2nisLsY2MCvm44AcJ4CcFjhtBhYrJTJ/3fKGTY0TK JFw2fe2nkxJd9ZIJO5+cDLngi/gUPETl9XOW//UtbQ6hZZKXhM9JANTTYt7VeBNysJ27Q8QLLi7Ut 0a7X3JhNtqu1LI/bmCNQpAf21SPpSzpytlvjs7pzlWz8x8BMaDzKnymPkBtQ9ja3N/WnagTNcR4cT dpxSf6Q2LO7NZYpsVSpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyg8I-002E4T-8Z; Fri, 25 Nov 2022 21:21:14 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxs3N-000eH9-5n for linux-i3c@lists.infradead.org; Wed, 23 Nov 2022 15:52:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A7AFF61D32; Wed, 23 Nov 2022 15:52:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DFB3C433D6; Wed, 23 Nov 2022 15:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1669218768; bh=/DumSgjbm3+bFjW/YII5HB+37hZffmS6RIQzxFus23A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Axk59HaPRU6B2o8/sQ2xV/J3QDnuJbllXINFmP+zTkfGNyl9/NsBA856568zy/Zy0 ziibqVHor7E2pImZW09H3fsO0rmk5lAkiY8/xImxvEPWF1JugZkU42k7XZp/1gGlxF YjrYDdmJl0DMzZ+GHnRpj/dpCWN4eBZtN+hiAE0Q= Date: Wed, 23 Nov 2022 16:52:45 +0100 From: Greg Kroah-Hartman To: Maximilian Luz Cc: Matthew Wilcox , Andy Shevchenko , linux-kernel@vger.kernel.org, Jens Axboe , "Rafael J. Wysocki" , Len Brown , Stefan Richter , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Sean Young , Mauro Carvalho Chehab , Rob Herring , Frank Rowand , Hans de Goede , Mark Gross , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Jiri Slaby , Heikki Krogerus , "Martin K. Petersen" , Chaitanya Kulkarni , Ming Lei , Jilin Yuan , Alan Stern , Sakari Ailus , Jason Gunthorpe , Thomas Gleixner , Ira Weiny , Dan Williams , Won Chung , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-block@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux1394-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * Message-ID: References: <20221123122523.1332370-1-gregkh@linuxfoundation.org> <20221123122523.1332370-3-gregkh@linuxfoundation.org> <711d5275-7e80-c00d-0cdc-0f3d52175361@gmail.com> <97be39ed-3cea-d55a-caa6-c2652baef399@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221123_075249_308571_C6D8E320 X-CRM114-Status: GOOD ( 46.65 ) X-Mailman-Approved-At: Fri, 25 Nov 2022 13:21:10 -0800 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org On Wed, Nov 23, 2022 at 04:48:41PM +0100, Maximilian Luz wrote: > On 11/23/22 16:37, Greg Kroah-Hartman wrote: > > On Wed, Nov 23, 2022 at 02:52:59PM +0000, Matthew Wilcox wrote: > > > On Wed, Nov 23, 2022 at 02:59:00PM +0100, Maximilian Luz wrote: > > > > On 11/23/22 14:34, Andy Shevchenko wrote: > > > > > On Wed, Nov 23, 2022 at 02:14:31PM +0100, Maximilian Luz wrote: > > > > > > On 11/23/22 13:25, Greg Kroah-Hartman wrote: > > > > > > > The uevent() callback in struct device_type should not be modifying the > > > > > > > device that is passed into it, so mark it as a const * and propagate the > > > > > > > function signature changes out into all relevant subsystems that use > > > > > > > this callback. > > > > > > > > > > [...] > > > > > > > > > > > > -static inline struct ssam_device *to_ssam_device(struct device *d) > > > > > > > +static inline struct ssam_device *to_ssam_device(const struct device *d) > > > > > > > { > > > > > > > return container_of(d, struct ssam_device, dev); > > > > > > > } > > > > > > > > > > > > I am slightly conflicted about this change as that now more or less > > > > > > implicitly drops the const. So I'm wondering if it wouldn't be better to > > > > > > either create a function specifically for const pointers or to just > > > > > > open-code it in the instance above. > > > > > > > > > > > > I guess we could also convert this to a macro. Then at least there > > > > > > wouldn't be an explicit and potentially misleading const-conversion > > > > > > indicated in the function signature. > > > > > > > > > > This is an intermediate step as far as I know since moving container_of to > > > > > recognize const is a bit noisy right now. I guess you can find a discussion > > > > > on the topic between Greg and Sakari. > > > > > > > > Thanks! I assume you are referring to the following? > > > > > > > > https://lore.kernel.org/lkml/4218173bd72b4f1899d4c41a8e251f0d@AcuMS.aculab.com/T/ > > > > > > > > As far as I can tell this is only a warning in documentation, not > > > > compile time (which would probably be impossible?). > > > > > > > > As I've said I'd be fine with converting the function to a macro (and > > > > preferably adding a similar warning like the one proposed in that > > > > thread). The point that irks me up is just that, as proposed, the > > > > function signature would now advertise a conversion that should never be > > > > happening. > > > > > > > > Having two separate functions would create a compile-time guarantee, so > > > > I'd prefer that, but I can understand if that might be considered too > > > > noisy in code. Or if there is a push to make container_of() emit a > > > > compile-time warning I'd also be perfectly happy with converting it to a > > > > macro now as that'd alleviate the need for functions in the future. > > > > > > Can't we do: > > > > > > static inline const struct ssam_device *to_ssam_device(const struct device *d) > > > { > > > return container_of(d, const struct ssam_device, dev); > > > } > > > > > > > You could, if you can always handle a const pointer coming out of this > > function, but I don't think you can. > > > > What you might want to do instead, and I'll be glad to do it for all of > > the functions like this I change, is to do what we have for struct > > device now: > > > > static inline struct device *__kobj_to_dev(struct kobject *kobj) > > { > > return container_of(kobj, struct device, kobj); > > } > > > > static inline const struct device *__kobj_to_dev_const(const struct kobject *kobj) > > { > > return container_of(kobj, const struct device, kobj); > > } > > > > /* > > * container_of() will happily take a const * and spit back a non-const * as it > > * is just doing pointer math. But we want to be a bit more careful in the > > * driver code, so manually force any const * of a kobject to also be a const * > > * to a device. > > */ > > #define kobj_to_dev(kobj) \ > > _Generic((kobj), \ > > const struct kobject *: __kobj_to_dev_const, \ > > struct kobject *: __kobj_to_dev)(kobj) > > > > > > Want me to do the same thing here as well? > > That looks great! Thanks! > > I would very much prefer that. Ok, will respin this patch as at least 2 individual patches, one that does the change to to_ssam_device() and the next that does the bus-wide changes. I'll review the other container_of() users in this patch as well to see if they can be converted as well. thanks, greg k-h -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AF67C4332F for ; Sat, 26 Nov 2022 08:12:41 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 72C4B18A5; Sat, 26 Nov 2022 09:11:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 72C4B18A5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1669450359; bh=/DumSgjbm3+bFjW/YII5HB+37hZffmS6RIQzxFus23A=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=uxS3v13AKsBtB3dyappvKip0V44lCPqMhYFIYg3/yIB3OYfE3aBYGedtRdfW3oTCn gfYQH9BtdjwDkRLBTeCbKC3oG2h+v59S7MSmf+My0Hr94lKkzZZlKBdAZfdf3tx9HG j1SaG+qsnQOi62WIwW+H9SD/57Bm5VE9feK2wX88= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4C356F80685; Sat, 26 Nov 2022 08:59:26 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CE4C7F8025D; Wed, 23 Nov 2022 16:52:52 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 26A29F80115 for ; Wed, 23 Nov 2022 16:52:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 26A29F80115 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Axk59HaP" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A7AFF61D32; Wed, 23 Nov 2022 15:52:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DFB3C433D6; Wed, 23 Nov 2022 15:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1669218768; bh=/DumSgjbm3+bFjW/YII5HB+37hZffmS6RIQzxFus23A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Axk59HaPRU6B2o8/sQ2xV/J3QDnuJbllXINFmP+zTkfGNyl9/NsBA856568zy/Zy0 ziibqVHor7E2pImZW09H3fsO0rmk5lAkiY8/xImxvEPWF1JugZkU42k7XZp/1gGlxF YjrYDdmJl0DMzZ+GHnRpj/dpCWN4eBZtN+hiAE0Q= Date: Wed, 23 Nov 2022 16:52:45 +0100 From: Greg Kroah-Hartman To: Maximilian Luz Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * Message-ID: References: <20221123122523.1332370-1-gregkh@linuxfoundation.org> <20221123122523.1332370-3-gregkh@linuxfoundation.org> <711d5275-7e80-c00d-0cdc-0f3d52175361@gmail.com> <97be39ed-3cea-d55a-caa6-c2652baef399@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Sat, 26 Nov 2022 08:58:53 +0100 Cc: Alexandre Belloni , Heikki Krogerus , Sean Young , "Rafael J. Wysocki" , alsa-devel@alsa-project.org, platform-driver-x86@vger.kernel.org, linux-i2c@vger.kernel.org, Andreas Noever , linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, Bard Liao , Dan Williams , Andy Shevchenko , linux-acpi@vger.kernel.org, Frank Rowand , Pierre-Louis Bossart , Matthew Wilcox , Jason Gunthorpe , Alan Stern , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Won Chung , Len Brown , devicetree@vger.kernel.org, Chaitanya Kulkarni , Ira Weiny , Michael Jamet , Ming Lei , Mark Gross , Hans de Goede , Rob Herring , Jiri Slaby , Thomas Gleixner , Mauro Carvalho Chehab , Mika Westerberg , Jens Axboe , linux-block@vger.kernel.org, Jilin Yuan , "Martin K. Petersen" , Dmitry Torokhov , linux-kernel@vger.kernel.org, Wolfram Sang , Vinod Koul , Stefan Richter , Sakari Ailus , Yehezkel Bernat , Sanyog Kale , linux-media@vger.kernel.org, linux-usb@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Nov 23, 2022 at 04:48:41PM +0100, Maximilian Luz wrote: > On 11/23/22 16:37, Greg Kroah-Hartman wrote: > > On Wed, Nov 23, 2022 at 02:52:59PM +0000, Matthew Wilcox wrote: > > > On Wed, Nov 23, 2022 at 02:59:00PM +0100, Maximilian Luz wrote: > > > > On 11/23/22 14:34, Andy Shevchenko wrote: > > > > > On Wed, Nov 23, 2022 at 02:14:31PM +0100, Maximilian Luz wrote: > > > > > > On 11/23/22 13:25, Greg Kroah-Hartman wrote: > > > > > > > The uevent() callback in struct device_type should not be modifying the > > > > > > > device that is passed into it, so mark it as a const * and propagate the > > > > > > > function signature changes out into all relevant subsystems that use > > > > > > > this callback. > > > > > > > > > > [...] > > > > > > > > > > > > -static inline struct ssam_device *to_ssam_device(struct device *d) > > > > > > > +static inline struct ssam_device *to_ssam_device(const struct device *d) > > > > > > > { > > > > > > > return container_of(d, struct ssam_device, dev); > > > > > > > } > > > > > > > > > > > > I am slightly conflicted about this change as that now more or less > > > > > > implicitly drops the const. So I'm wondering if it wouldn't be better to > > > > > > either create a function specifically for const pointers or to just > > > > > > open-code it in the instance above. > > > > > > > > > > > > I guess we could also convert this to a macro. Then at least there > > > > > > wouldn't be an explicit and potentially misleading const-conversion > > > > > > indicated in the function signature. > > > > > > > > > > This is an intermediate step as far as I know since moving container_of to > > > > > recognize const is a bit noisy right now. I guess you can find a discussion > > > > > on the topic between Greg and Sakari. > > > > > > > > Thanks! I assume you are referring to the following? > > > > > > > > https://lore.kernel.org/lkml/4218173bd72b4f1899d4c41a8e251f0d@AcuMS.aculab.com/T/ > > > > > > > > As far as I can tell this is only a warning in documentation, not > > > > compile time (which would probably be impossible?). > > > > > > > > As I've said I'd be fine with converting the function to a macro (and > > > > preferably adding a similar warning like the one proposed in that > > > > thread). The point that irks me up is just that, as proposed, the > > > > function signature would now advertise a conversion that should never be > > > > happening. > > > > > > > > Having two separate functions would create a compile-time guarantee, so > > > > I'd prefer that, but I can understand if that might be considered too > > > > noisy in code. Or if there is a push to make container_of() emit a > > > > compile-time warning I'd also be perfectly happy with converting it to a > > > > macro now as that'd alleviate the need for functions in the future. > > > > > > Can't we do: > > > > > > static inline const struct ssam_device *to_ssam_device(const struct device *d) > > > { > > > return container_of(d, const struct ssam_device, dev); > > > } > > > > > > > You could, if you can always handle a const pointer coming out of this > > function, but I don't think you can. > > > > What you might want to do instead, and I'll be glad to do it for all of > > the functions like this I change, is to do what we have for struct > > device now: > > > > static inline struct device *__kobj_to_dev(struct kobject *kobj) > > { > > return container_of(kobj, struct device, kobj); > > } > > > > static inline const struct device *__kobj_to_dev_const(const struct kobject *kobj) > > { > > return container_of(kobj, const struct device, kobj); > > } > > > > /* > > * container_of() will happily take a const * and spit back a non-const * as it > > * is just doing pointer math. But we want to be a bit more careful in the > > * driver code, so manually force any const * of a kobject to also be a const * > > * to a device. > > */ > > #define kobj_to_dev(kobj) \ > > _Generic((kobj), \ > > const struct kobject *: __kobj_to_dev_const, \ > > struct kobject *: __kobj_to_dev)(kobj) > > > > > > Want me to do the same thing here as well? > > That looks great! Thanks! > > I would very much prefer that. Ok, will respin this patch as at least 2 individual patches, one that does the change to to_ssam_device() and the next that does the bus-wide changes. I'll review the other container_of() users in this patch as well to see if they can be converted as well. thanks, greg k-h