From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2CEAC4332F for ; Wed, 23 Nov 2022 17:55:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238866AbiKWRzs (ORCPT ); Wed, 23 Nov 2022 12:55:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236859AbiKWRzq (ORCPT ); Wed, 23 Nov 2022 12:55:46 -0500 Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7EFEC4C3F for ; Wed, 23 Nov 2022 09:55:44 -0800 (PST) Received: by mail-qv1-xf34.google.com with SMTP id cz18so6313199qvb.13 for ; Wed, 23 Nov 2022 09:55:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mZGGAbQVRBkDZyExP7ffjlyLb6N0sV9F4cgg4l8gSxE=; b=My/je7B5AkyQl5fsdxgrcU4MlCIO0r7BQ5Ticu0quoimRFyd1QFWg1CIRYo2hSlhCk gVjIJJSUMGBCSbu4UDXzbQPaiJloUApBWvaqFNa76nYHQxGNxzJWcDLEm0qltzXuuN/Z gO+uDnAR3m7NYXWzCuDuYM8LFnvN0Xu6vLCMlAClrlBYpN6lXcqxJLcrsGyjBmH/Sv12 +4Tfy+Id6dykaHW4e8It4+0URa6BTBpgvGETfgKsz3tVQND5afP3nmgNdrdjI227ASXm vr1NQmNHtxvof8mhDMYhIaXb4hON7jWdw6w75cCEJBe1LxtxXk3bYjl3v+s4zDC4Zj8c gKuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mZGGAbQVRBkDZyExP7ffjlyLb6N0sV9F4cgg4l8gSxE=; b=kAkC4ib/GpqJ9TOEgO9mD3Q710PRfQ7Zc8DZ6eZ5JzhvAZaA8MzzBpy5/+nCZAIWFU /0Tnq7HAEYIyUnlbPg58qZ/BjL8jHZxrbWsYsy3iEjv9DLlDZtWHiZ+HUE0sVa3h6U0y MdL3ZhZ0PnmidSHSUIZriU5z967GaBTYASVdQK2Eoeczrp5EmhhSBAldZpERsNdO0ULy xDmRQJI5DHK6y2/u2tonORRAgM5FruyKLOMN82e/EH0DtzoGSNspdyjuB+W2yDtpAbw5 aViaNvwRT1DV0VolCaQnD3z40sfn2rpURz7AjhKojc1MJCWqOA7OevA6TkX0pichTZwv 2dbQ== X-Gm-Message-State: ANoB5pmIqksVOM+nUW1keUVI1cmsPrBLJOmBmZN9numqQaddJOkpuW1+ D3J1lHIxzC7/QrZnRN1VcZpQmQ== X-Google-Smtp-Source: AA0mqf6wKiTjKYxvtjsF4TJ4YPeSr0mdEUQ+pw8A+HZdflt1p0dm9sIfWC/e+svu0siqN7xcA8Vb/g== X-Received: by 2002:a05:6214:209:b0:4bb:6bbd:8c1b with SMTP id i9-20020a056214020900b004bb6bbd8c1bmr9012796qvt.111.1669226143925; Wed, 23 Nov 2022 09:55:43 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-122-23.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.122.23]) by smtp.gmail.com with ESMTPSA id o18-20020a05620a111200b006faaf6dc55asm11988986qkk.22.2022.11.23.09.55.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 09:55:43 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1oxtyI-00Afdu-Dk; Wed, 23 Nov 2022 13:55:42 -0400 Date: Wed, 23 Nov 2022 13:55:42 -0400 From: Jason Gunthorpe To: Matthew Wilcox Cc: Greg Kroah-Hartman , Maximilian Luz , Andy Shevchenko , linux-kernel@vger.kernel.org, Jens Axboe , "Rafael J. Wysocki" , Len Brown , Stefan Richter , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Sean Young , Mauro Carvalho Chehab , Rob Herring , Frank Rowand , Hans de Goede , Mark Gross , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Jiri Slaby , Heikki Krogerus , "Martin K. Petersen" , Chaitanya Kulkarni , Ming Lei , Jilin Yuan , Alan Stern , Sakari Ailus , Thomas Gleixner , Ira Weiny , Dan Williams , Won Chung , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-block@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux1394-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * Message-ID: References: <20221123122523.1332370-3-gregkh@linuxfoundation.org> <711d5275-7e80-c00d-0cdc-0f3d52175361@gmail.com> <97be39ed-3cea-d55a-caa6-c2652baef399@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Nov 23, 2022 at 05:49:36PM +0000, Matthew Wilcox wrote: > On Wed, Nov 23, 2022 at 01:29:56PM -0400, Jason Gunthorpe wrote: > > #define generic_container_of(in_type, in, out_type, out_member) \ > > _Generic(in, \ > > const in_type *: ((const out_type *)container_of(in, out_type, out_member)), \ > > in_type *: ((out_type *)container_of(in, out_type, out_member)) \ > > ) > > There's a neat trick I found in seqlock.h: > > #define generic_container_of(in_t, in, out_t, m) \ > _Generic(*(in), \ > const in_t: ((const out_t *)container_of(in, out_t, m)), \ > in_t: ((out_t *)container_of(in, out_type, m)) \ > ) > > and now it fits in 80 columns ;-) Aside from less letters, is their another benifit to using *(in) ? Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE6F9C63705 for ; Fri, 25 Nov 2022 21:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zJ0vK+gEDvpVro4fr1nmT3LpMnEjrO7OBMdbZc4jlPo=; b=AnQhF/6Xqgg7dS p/AVc5ISLuhFg7WD82PUINNWL7NAxgycgRsD+qSHjGPhvDpWPboAg/Sfru74ZqKaQ0kV6PzFylVyh jvORv7ANq0nkoDJDt5vAKPotVBZQkIWrci01zCB/gLfLAD4j6l2G7gBG+D0q/Uxr0gCFJaVA4eEXp SoKZp9NngfYAlZPK4AoR/K7AIa41E292+1FDaIX8LSQROdtwc8OcWilLy5Q5ZSS9Xrwx2L61ZFJ6s S0h/WCYvdLaLAbPGPBDdVLOG9/Hqj7JIHGvfPfyihfpKsQiTM8MqwA3EYZLWQY97W0Vc/a4QKT5M1 EgUO5WSlhnHZsIYOaUYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyg8J-002E5e-8U; Fri, 25 Nov 2022 21:21:15 +0000 Received: from mail-qv1-xf31.google.com ([2607:f8b0:4864:20::f31]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxtyL-001Lfw-Af for linux-i3c@lists.infradead.org; Wed, 23 Nov 2022 17:55:46 +0000 Received: by mail-qv1-xf31.google.com with SMTP id d18so9116408qvs.6 for ; Wed, 23 Nov 2022 09:55:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mZGGAbQVRBkDZyExP7ffjlyLb6N0sV9F4cgg4l8gSxE=; b=My/je7B5AkyQl5fsdxgrcU4MlCIO0r7BQ5Ticu0quoimRFyd1QFWg1CIRYo2hSlhCk gVjIJJSUMGBCSbu4UDXzbQPaiJloUApBWvaqFNa76nYHQxGNxzJWcDLEm0qltzXuuN/Z gO+uDnAR3m7NYXWzCuDuYM8LFnvN0Xu6vLCMlAClrlBYpN6lXcqxJLcrsGyjBmH/Sv12 +4Tfy+Id6dykaHW4e8It4+0URa6BTBpgvGETfgKsz3tVQND5afP3nmgNdrdjI227ASXm vr1NQmNHtxvof8mhDMYhIaXb4hON7jWdw6w75cCEJBe1LxtxXk3bYjl3v+s4zDC4Zj8c gKuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mZGGAbQVRBkDZyExP7ffjlyLb6N0sV9F4cgg4l8gSxE=; b=t1I9jgCwMZKg6fDi8ANtKLjh8wZy43ve3Ua1QxVLSNviZQEJopHEXUVqq6vHwgCQpg JNJP6z/XsSAGXpp0cG4preA/okV8vGvANR/cmi25wTrz9kgPZvaO+pSsvWmX3kRakC31 JVZT0i7Z5uZjjchgqBB9NSGas8OumJrqD/UMgh6qIbk/PXJyKXPe8J/a7SSxA5BKHqZ7 LWbmMKZp0masqsNha72TDBisEX+UfvP/F5L+mlQdVyf4jprxGTN/R9cWG5EmWnOwg2yg pTaaCTMXcvvobmKoHxOWZgKSK2Ei8b5H+iCGhJ1mjT3lIq3cpaLbCy1EXFYG6FL9RaJh oFkQ== X-Gm-Message-State: ANoB5pl8h4wc/x7e0Dwuf6DOgoy/BDl5/FpZk0348Sh8ZjlSeLo9Rf3G yumjgxdd33hCZdzsPG96hT8dzQ== X-Google-Smtp-Source: AA0mqf6wKiTjKYxvtjsF4TJ4YPeSr0mdEUQ+pw8A+HZdflt1p0dm9sIfWC/e+svu0siqN7xcA8Vb/g== X-Received: by 2002:a05:6214:209:b0:4bb:6bbd:8c1b with SMTP id i9-20020a056214020900b004bb6bbd8c1bmr9012796qvt.111.1669226143925; Wed, 23 Nov 2022 09:55:43 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-122-23.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.122.23]) by smtp.gmail.com with ESMTPSA id o18-20020a05620a111200b006faaf6dc55asm11988986qkk.22.2022.11.23.09.55.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 09:55:43 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1oxtyI-00Afdu-Dk; Wed, 23 Nov 2022 13:55:42 -0400 Date: Wed, 23 Nov 2022 13:55:42 -0400 From: Jason Gunthorpe To: Matthew Wilcox Cc: Greg Kroah-Hartman , Maximilian Luz , Andy Shevchenko , linux-kernel@vger.kernel.org, Jens Axboe , "Rafael J. Wysocki" , Len Brown , Stefan Richter , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Sean Young , Mauro Carvalho Chehab , Rob Herring , Frank Rowand , Hans de Goede , Mark Gross , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Jiri Slaby , Heikki Krogerus , "Martin K. Petersen" , Chaitanya Kulkarni , Ming Lei , Jilin Yuan , Alan Stern , Sakari Ailus , Thomas Gleixner , Ira Weiny , Dan Williams , Won Chung , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-block@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux1394-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * Message-ID: References: <20221123122523.1332370-3-gregkh@linuxfoundation.org> <711d5275-7e80-c00d-0cdc-0f3d52175361@gmail.com> <97be39ed-3cea-d55a-caa6-c2652baef399@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221123_095545_384764_A653B69A X-CRM114-Status: GOOD ( 11.60 ) X-Mailman-Approved-At: Fri, 25 Nov 2022 13:21:10 -0800 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org On Wed, Nov 23, 2022 at 05:49:36PM +0000, Matthew Wilcox wrote: > On Wed, Nov 23, 2022 at 01:29:56PM -0400, Jason Gunthorpe wrote: > > #define generic_container_of(in_type, in, out_type, out_member) \ > > _Generic(in, \ > > const in_type *: ((const out_type *)container_of(in, out_type, out_member)), \ > > in_type *: ((out_type *)container_of(in, out_type, out_member)) \ > > ) > > There's a neat trick I found in seqlock.h: > > #define generic_container_of(in_t, in, out_t, m) \ > _Generic(*(in), \ > const in_t: ((const out_t *)container_of(in, out_t, m)), \ > in_t: ((out_t *)container_of(in, out_type, m)) \ > ) > > and now it fits in 80 columns ;-) Aside from less letters, is their another benifit to using *(in) ? Jason -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F689C43217 for ; Sat, 26 Nov 2022 08:00:58 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3849017F0; Sat, 26 Nov 2022 09:00:06 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3849017F0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1669449656; bh=EfiX2/IiNE/Gp7XY++Xx28h8Fsj9GFlNLbGeLo5T8/k=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZsgOvlnAp57dGsWC14zbDm/TbEmNDLfDV6p7n6nQNsZeBot9afb9Zd/avJacRbZ2M Z9uTnGqGDC/y27gu7+ceuB/EMUVW2WVNI4+THvmz1/ExkSoIIu7ogd/JKBagtO6lGi NVD7qCD9ACkpLHQ/BVPMXaK+QRfQ+EZrzxd28APk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D03DDF80564; Sat, 26 Nov 2022 08:58:57 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8D8B6F8025D; Wed, 23 Nov 2022 18:55:52 +0100 (CET) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2E0F7F80149 for ; Wed, 23 Nov 2022 18:55:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2E0F7F80149 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="My/je7B5" Received: by mail-qv1-xf34.google.com with SMTP id cz18so6313206qvb.13 for ; Wed, 23 Nov 2022 09:55:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mZGGAbQVRBkDZyExP7ffjlyLb6N0sV9F4cgg4l8gSxE=; b=My/je7B5AkyQl5fsdxgrcU4MlCIO0r7BQ5Ticu0quoimRFyd1QFWg1CIRYo2hSlhCk gVjIJJSUMGBCSbu4UDXzbQPaiJloUApBWvaqFNa76nYHQxGNxzJWcDLEm0qltzXuuN/Z gO+uDnAR3m7NYXWzCuDuYM8LFnvN0Xu6vLCMlAClrlBYpN6lXcqxJLcrsGyjBmH/Sv12 +4Tfy+Id6dykaHW4e8It4+0URa6BTBpgvGETfgKsz3tVQND5afP3nmgNdrdjI227ASXm vr1NQmNHtxvof8mhDMYhIaXb4hON7jWdw6w75cCEJBe1LxtxXk3bYjl3v+s4zDC4Zj8c gKuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mZGGAbQVRBkDZyExP7ffjlyLb6N0sV9F4cgg4l8gSxE=; b=iPiqziisv70XTVoJqhMRowLvXIt4fLqvkRhrQqmP/eZrU7IeZKJAPpB5FTepK4AgBZ wN+Rcj9FwLWluUFdq0tpghJ//XiphSmdk746Gb379hPwqLp+jHQoCQV2J3Z2aVpNauZp iz+Uns1j1Ns6MbQoA3QMsHXSBdlFjSPa+kdfvnkstKV3yV7IT8hPxosCQV/mpzh30Lts Cmbzfi31oNbh8KRKfdu1hrUnE0Fho++pmjOzOn7EckkwcbF42HAh5y9HL5582eNUiMvp fBFy83AWOWepLt9VlgU03ItB2ZsSD93wZ+SzO96HdojL+kq9Zy3KJY+G34sBLmUVDvgJ dCNA== X-Gm-Message-State: ANoB5pmNf495MHFV10GeQDpxHQi3SUuuGXHRMeRIVawv43s2dUjzpDZq 6NSPUfBZQuU5yT1YjuFAnEamdw== X-Google-Smtp-Source: AA0mqf6wKiTjKYxvtjsF4TJ4YPeSr0mdEUQ+pw8A+HZdflt1p0dm9sIfWC/e+svu0siqN7xcA8Vb/g== X-Received: by 2002:a05:6214:209:b0:4bb:6bbd:8c1b with SMTP id i9-20020a056214020900b004bb6bbd8c1bmr9012796qvt.111.1669226143925; Wed, 23 Nov 2022 09:55:43 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-122-23.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.122.23]) by smtp.gmail.com with ESMTPSA id o18-20020a05620a111200b006faaf6dc55asm11988986qkk.22.2022.11.23.09.55.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 09:55:43 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1oxtyI-00Afdu-Dk; Wed, 23 Nov 2022 13:55:42 -0400 Date: Wed, 23 Nov 2022 13:55:42 -0400 From: Jason Gunthorpe To: Matthew Wilcox Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * Message-ID: References: <20221123122523.1332370-3-gregkh@linuxfoundation.org> <711d5275-7e80-c00d-0cdc-0f3d52175361@gmail.com> <97be39ed-3cea-d55a-caa6-c2652baef399@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Sat, 26 Nov 2022 08:58:52 +0100 Cc: Alexandre Belloni , Heikki Krogerus , Sean Young , "Rafael J. Wysocki" , alsa-devel@alsa-project.org, platform-driver-x86@vger.kernel.org, linux-i2c@vger.kernel.org, Andreas Noever , linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, Bard Liao , Dan Williams , Andy Shevchenko , Frank Rowand , Pierre-Louis Bossart , linux-acpi@vger.kernel.org, Alan Stern , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Won Chung , Len Brown , devicetree@vger.kernel.org, Chaitanya Kulkarni , Ira Weiny , Michael Jamet , Ming Lei , Mark Gross , Hans de Goede , Rob Herring , Jiri Slaby , Thomas Gleixner , Mauro Carvalho Chehab , Mika Westerberg , Jens Axboe , linux-block@vger.kernel.org, Jilin Yuan , "Martin K. Petersen" , Greg Kroah-Hartman , Dmitry Torokhov , linux-kernel@vger.kernel.org, Wolfram Sang , Vinod Koul , Stefan Richter , Sakari Ailus , Yehezkel Bernat , Sanyog Kale , linux-media@vger.kernel.org, Maximilian Luz , linux-usb@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Nov 23, 2022 at 05:49:36PM +0000, Matthew Wilcox wrote: > On Wed, Nov 23, 2022 at 01:29:56PM -0400, Jason Gunthorpe wrote: > > #define generic_container_of(in_type, in, out_type, out_member) \ > > _Generic(in, \ > > const in_type *: ((const out_type *)container_of(in, out_type, out_member)), \ > > in_type *: ((out_type *)container_of(in, out_type, out_member)) \ > > ) > > There's a neat trick I found in seqlock.h: > > #define generic_container_of(in_t, in, out_t, m) \ > _Generic(*(in), \ > const in_t: ((const out_t *)container_of(in, out_t, m)), \ > in_t: ((out_t *)container_of(in, out_type, m)) \ > ) > > and now it fits in 80 columns ;-) Aside from less letters, is their another benifit to using *(in) ? Jason