All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mm-commits@vger.kernel.org, zokeefe@google.com, shy828301@gmail.com
Subject: Re: + mm-replace-vm_warn_on-to-pr_warn-if-the-node-is-offline-with-__gfp_thisnode-v4.patch added to mm-hotfixes-unstable branch
Date: Thu, 24 Nov 2022 08:17:10 +0100	[thread overview]
Message-ID: <Y38adlO8/Gky/3Z5@dhcp22.suse.cz> (raw)
In-Reply-To: <20221123195755.F2521C433C1@smtp.kernel.org>

On Wed 23-11-22 11:57:55, Andrew Morton wrote:
[...]
> -static inline void warn_if_node_offline(int nid, gfp_t gfp_mask)
> +static inline void warn_if_node_offline(int this_node, gfp_t gfp_mask)
>  {
> -	gfp_t gfp = gfp_mask & (__GFP_THISNODE|__GFP_NOWARN);
> +	gfp_t warn_gfp = gfp_mask & (__GFP_THISNODE|__GFP_NOWARN);
>  
> -	if ((gfp == (__GFP_THISNODE|__GFP_NOWARN)) && !node_online(nid)) {
> -		pr_warn("%pGg allocation from offline node %d\n", &gfp, nid);
> -		dump_stack();
> -	}
> +	if (warn_gfp != (__GFP_THISNODE|__GFP_NOWARN))
> +		return;
> +
> +	if(node_online(this_node))
> +		return;
> +
> +	pr_warn("%pGg allocation from offline node %d\n", &warn_gfp, this_node);

This should be gfp_mask printed, not the filtered part of it.

> +	dump_stack();
>  }
>  
>  /*
> _
> 
> Patches currently in -mm which might be from shy828301@gmail.com are
> 
> mm-replace-vm_warn_on-to-pr_warn-if-the-node-is-offline-with-__gfp_thisnode.patch
> mm-replace-vm_warn_on-to-pr_warn-if-the-node-is-offline-with-__gfp_thisnode-v4.patch

-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2022-11-24  7:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23 19:57 + mm-replace-vm_warn_on-to-pr_warn-if-the-node-is-offline-with-__gfp_thisnode-v4.patch added to mm-hotfixes-unstable branch Andrew Morton
2022-11-24  7:17 ` Michal Hocko [this message]
2022-11-28 19:23   ` Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y38adlO8/Gky/3Z5@dhcp22.suse.cz \
    --to=mhocko@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=shy828301@gmail.com \
    --cc=zokeefe@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.