From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E867C43217 for ; Mon, 14 Nov 2022 20:49:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236807AbiKNUtS (ORCPT ); Mon, 14 Nov 2022 15:49:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235591AbiKNUtP (ORCPT ); Mon, 14 Nov 2022 15:49:15 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCD781277E for ; Mon, 14 Nov 2022 12:49:14 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id b21so11188945plc.9 for ; Mon, 14 Nov 2022 12:49:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gkgjefB1+6KbyMu0uuZ086tg7a8inwZvw55s87p+Sl8=; b=R2VcHAQWKWoSy4Ex1PFK4F3oamdO5rj1n4O638YozO3My7kwm1gCGnmnzN36/1/33q M748CRiXx4GbKbhsi2m9V54akbITPAKUw8XuAx/JCyOtHTOels+9fKThsDYLCslHkNwa +ehxiQOJ8RAnW9A1nb3Bk+FBnAfTcEmje3wFwqXwuflaSsZegBhb0+ChHR9qo+mweJO0 TTwJDB6JySiBnton9O55nP66yKkloLmeGdStBtpmHt5kXS3ueRP/K3gVxDTt/g6y7nuh kMT/csMSQObsM5p7RXAVAUet3euhxmUZslozcZVpOJPoCHCkmpa5y3v+jFZswfXHOq21 oVQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gkgjefB1+6KbyMu0uuZ086tg7a8inwZvw55s87p+Sl8=; b=cwgRysF20hQHtJPDtcmY2IEDkS8mIsLNTnWncYExXZosCIO64IjafJDwtzTXul1ElS S/dc9A2UwYrXOQP/nOjR2bCl04KazX8zwrDBHCg0EDkW5bLGbf3fBaqVAM3IjzhfsJKC LZR8ZTuiCNpr07jN2WC4zfmzueNdyLv2EYIZcH0XrapUOubx5ruon3Cn2EIJ3dgktZQm WxGINoODs6xXgao3CDtIXenheeRNjVWPlMYdt0a8cXCAoDP6Y2BmUTM/zkNSysOo82m2 blBzAndpnuu7xBD/Ln1mU2Y4jH9YRsPYGPAAbqcRVUYcBqAVpN2Gd7WTAlynaexKSdK/ bDiQ== X-Gm-Message-State: ANoB5plNnn+eJ2lLQa81G8DYAPvN8P0BEueNm9ARKiRQTtro7h8U78ij zTBXTLbDpS7l5GvH7vkqexSnsS1Yq20dqQ== X-Google-Smtp-Source: AA0mqf4QfkDuhsj6MXKqI+aIdHahZZ03Y/CtArwCpMRQUe+J2W/5u2HBqoHFVITNxUGEwp/FQbRjow== X-Received: by 2002:a17:90a:617:b0:213:cb87:8cd4 with SMTP id j23-20020a17090a061700b00213cb878cd4mr15433263pjj.78.1668458954145; Mon, 14 Nov 2022 12:49:14 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id i24-20020aa796f8000000b00562784609fbsm7129596pfq.209.2022.11.14.12.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Nov 2022 12:49:13 -0800 (PST) Date: Mon, 14 Nov 2022 20:49:09 +0000 From: Sean Christopherson To: Mathieu Desnoyers Cc: Andy Lutomirski , Peter Zijlstra , linux-kernel@vger.kernel.org, Thomas Gleixner , "Paul E . McKenney" , Boqun Feng , "H . Peter Anvin" , Paul Turner , linux-api@vger.kernel.org, Christian Brauner , Florian Weimer , David.Laight@aculab.com, carlos@redhat.com, Peter Oskolkov , Alexander Mikhalitsyn , Chris Kennelly Subject: Re: [PATCH v5 08/24] sched: Introduce per memory space current virtual cpu id Message-ID: References: <20221103200359.328736-1-mathieu.desnoyers@efficios.com> <20221103200359.328736-9-mathieu.desnoyers@efficios.com> <2f191ddb-de89-52c0-e7da-26ac0239b8fe@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f191ddb-de89-52c0-e7da-26ac0239b8fe@efficios.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 11, 2022, Mathieu Desnoyers wrote: > On 2022-11-10 23:41, Andy Lutomirski wrote: > > On Thu, Nov 3, 2022 at 1:05 PM Mathieu Desnoyers > > wrote: > > Also, in my mind "virtual cpu" is vCPU, which this isn't. Maybe > > "compacted cpu" or something? It's a strange sort of concept. > > I've kept the same wording that has been introduced in 2011 by Paul Turner > and used internally at Google since then, although it may be confusing if > people expect kvm-vCPU and rseq-vcpu to mean the same thing. Both really end > up providing the semantic of a virtually assigned cpu id (in opposition to > the logical cpu id on the system), but this is much more involved in the > case of KVM. I had the same reaction as Andy. The rseq concepts don't worry me so much as the existence of "vcpu" in mm_struct/task_struct, e.g. switch_mm_vcpu() when switching between KVM vCPU tasks is going to be super confusing. Ditto for mm_vcpu_get() and mm_vcpu_put() in the few cases where KVM currently does mmget()/mmput().