From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8353C4321E for ; Wed, 16 Nov 2022 18:12:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234352AbiKPSL7 (ORCPT ); Wed, 16 Nov 2022 13:11:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234613AbiKPSLy (ORCPT ); Wed, 16 Nov 2022 13:11:54 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBAF06175A; Wed, 16 Nov 2022 10:11:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9BF40B81E4F; Wed, 16 Nov 2022 18:11:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AEE4C433D6; Wed, 16 Nov 2022 18:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668622311; bh=w0UO98liO5fLCNnlMHd5BQufutT9Of+UoFv/uKbaByY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lAKPE3PSimsi0+eDiHvPD0qlee7GY738+lb4Z/kt+iyzopEL4vDLZBi2713YTl0LP Kg1W0TOqgwruvLtNRIAZeZdf+tOwkqFXGYuZTkjeF8kYL4U+1HUrwiD9Z8zcdGm76R 4zwKh9CeSj8QWrYOZ7ll+7j7kTij7cCB7ulC/B/LXk1QAXeSP+tLmI1FHZRGW+jhY9 E0bNNr7YN82FOI/HOt/wUjgBmdSgcQxsTlc8wz8mijzDTZZbR9RAX9FVNzdimGvy8n zD65CrnJ4UCifwzRNdMuOhc/yqHSdSW9A/RqKevSBiy5GSJZ2kleyAtIPxdW7Nz04i mJo1QaKw6/5Sw== Date: Wed, 16 Nov 2022 18:11:43 +0000 From: Lee Jones To: Jerome Neanne Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, tony@atomide.com, vigneshr@ti.com, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com, afd@ti.com, khilman@baylibre.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v7 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC Message-ID: References: <20221104152311.1098603-1-jneanne@baylibre.com> <20221104152311.1098603-5-jneanne@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221104152311.1098603-5-jneanne@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 04 Nov 2022, Jerome Neanne wrote: > The TPS65219 is a power management IC PMIC designed to supply a wide > range of SoCs in both portable and stationary applications. Any SoC can > control TPS65219 over a standard I2C interface. > > It contains the following components: > - Regulators. > - Over Temperature warning and Shut down. > - GPIOs > - Multi Function Pins (MFP) > - power-button > > This patch adds support for tps65219 PMIC. At this time only > the functionalities listed below are made available: > > - Regulators probe and functionalities > - warm and cold reset support > - SW shutdown support > - Regulator warnings via IRQs > - Power-button via IRQ > > Signed-off-by: Jerome Neanne > Signed-off-by: Markus Schneider-Pargmann > Acked-for-mfd-by: Lee Jones > --- > > Notes: > Changes in v7: > Lee Jones review > - Kconfig nit: button that is > - tps65219.c, nits: '\n' x2 > - tps65219.c, nit: { .name = "tps65219-gpios", }, > - tps65219.h, nit: Power Management IC > - tps65219.h, rework header: struct tps65219 > - tps65219.h, remove Superflous " " /* MFD_TPS65219_H */ > - remove unused tps65219_soft_shutdown further to make W=1 check > Biju Das review: > - Remove all includes that are not mandatory > - Remove container_of err check > > MAINTAINERS | 1 + > drivers/mfd/Kconfig | 14 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/tps65219.c | 299 ++++++++++++++++++++++++++++++ > include/linux/mfd/tps65219.h | 345 +++++++++++++++++++++++++++++++++++ > 5 files changed, 660 insertions(+) > create mode 100644 drivers/mfd/tps65219.c > create mode 100644 include/linux/mfd/tps65219.h Applied, thanks. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08731C43217 for ; Wed, 16 Nov 2022 18:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y+27aLjA5fHmmtRUGeP7y76ynVRV+g3MSkkZN+jdP70=; b=yMrgHno5Z25O1e cVWAM+pi57F9oTiGjtgOUBvtAF7Mikijd8dBkUlax84A9/ss2Xze3odcpGQqi8uAU5KghsQkPpiH3 CjFye9s/vAkoe+98plKNAZ2ZYkBjOQ4NXMRmFNQlHYQv/8nyLsLPHt/uCp3EajLGVkCihw4iKVFPJ 0aYcUXPAQd3s0mbNAQ1XCLTi/3NPiaKKQ27nUkJmTjgWrHeASIyx6RO3VJO+dnZ+0ORobQLHPmWBH Rk/NSK5K6TpjtW45J5K0SRE6vwArJ0TUGmWynscXsA599/xrPa7vhyuJUCNjG7piiSCZApgamAV38 zDXcfjS+meXqbHrjcrbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovMtA-006ptJ-NK; Wed, 16 Nov 2022 18:11:56 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovMt8-006psK-BH for linux-arm-kernel@lists.infradead.org; Wed, 16 Nov 2022 18:11:55 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8C293B81DA8; Wed, 16 Nov 2022 18:11:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AEE4C433D6; Wed, 16 Nov 2022 18:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668622311; bh=w0UO98liO5fLCNnlMHd5BQufutT9Of+UoFv/uKbaByY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lAKPE3PSimsi0+eDiHvPD0qlee7GY738+lb4Z/kt+iyzopEL4vDLZBi2713YTl0LP Kg1W0TOqgwruvLtNRIAZeZdf+tOwkqFXGYuZTkjeF8kYL4U+1HUrwiD9Z8zcdGm76R 4zwKh9CeSj8QWrYOZ7ll+7j7kTij7cCB7ulC/B/LXk1QAXeSP+tLmI1FHZRGW+jhY9 E0bNNr7YN82FOI/HOt/wUjgBmdSgcQxsTlc8wz8mijzDTZZbR9RAX9FVNzdimGvy8n zD65CrnJ4UCifwzRNdMuOhc/yqHSdSW9A/RqKevSBiy5GSJZ2kleyAtIPxdW7Nz04i mJo1QaKw6/5Sw== Date: Wed, 16 Nov 2022 18:11:43 +0000 From: Lee Jones To: Jerome Neanne Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, tony@atomide.com, vigneshr@ti.com, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com, afd@ti.com, khilman@baylibre.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v7 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC Message-ID: References: <20221104152311.1098603-1-jneanne@baylibre.com> <20221104152311.1098603-5-jneanne@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221104152311.1098603-5-jneanne@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221116_101154_559848_0E9DBB11 X-CRM114-Status: GOOD ( 17.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAwNCBOb3YgMjAyMiwgSmVyb21lIE5lYW5uZSB3cm90ZToKCj4gVGhlIFRQUzY1MjE5 IGlzIGEgcG93ZXIgbWFuYWdlbWVudCBJQyBQTUlDIGRlc2lnbmVkIHRvIHN1cHBseSBhIHdpZGUK PiByYW5nZSBvZiBTb0NzIGluIGJvdGggcG9ydGFibGUgYW5kIHN0YXRpb25hcnkgYXBwbGljYXRp b25zLiBBbnkgU29DIGNhbgo+IGNvbnRyb2wgVFBTNjUyMTkgb3ZlciBhIHN0YW5kYXJkIEkyQyBp bnRlcmZhY2UuCj4gCj4gSXQgY29udGFpbnMgdGhlIGZvbGxvd2luZyBjb21wb25lbnRzOgo+IC0g UmVndWxhdG9ycy4KPiAtIE92ZXIgVGVtcGVyYXR1cmUgd2FybmluZyBhbmQgU2h1dCBkb3duLgo+ IC0gR1BJT3MKPiAtIE11bHRpIEZ1bmN0aW9uIFBpbnMgKE1GUCkKPiAtIHBvd2VyLWJ1dHRvbgo+ IAo+IFRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0IGZvciB0cHM2NTIxOSBQTUlDLiBBdCB0aGlzIHRp bWUgb25seQo+IHRoZSBmdW5jdGlvbmFsaXRpZXMgbGlzdGVkIGJlbG93IGFyZSBtYWRlIGF2YWls YWJsZToKPiAKPiAtIFJlZ3VsYXRvcnMgcHJvYmUgYW5kIGZ1bmN0aW9uYWxpdGllcwo+IC0gd2Fy bSBhbmQgY29sZCByZXNldCBzdXBwb3J0Cj4gLSBTVyBzaHV0ZG93biBzdXBwb3J0Cj4gLSBSZWd1 bGF0b3Igd2FybmluZ3MgdmlhIElSUXMKPiAtIFBvd2VyLWJ1dHRvbiB2aWEgSVJRCj4gCj4gU2ln bmVkLW9mZi1ieTogSmVyb21lIE5lYW5uZSA8am5lYW5uZUBiYXlsaWJyZS5jb20+Cj4gU2lnbmVk LW9mZi1ieTogTWFya3VzIFNjaG5laWRlci1QYXJnbWFubiA8bXNwQGJheWxpYnJlLmNvbT4KPiBB Y2tlZC1mb3ItbWZkLWJ5OiBMZWUgSm9uZXMgPGxlZUBrZXJuZWwub3JnPgo+IC0tLQo+IAo+IE5v dGVzOgo+ICAgICBDaGFuZ2VzIGluIHY3Ogo+ICAgICBMZWUgSm9uZXMgcmV2aWV3Cj4gICAgIC0g S2NvbmZpZyBuaXQ6IGJ1dHRvbiB0aGF0IGlzCj4gICAgIC0gdHBzNjUyMTkuYywgbml0czogJ1xu JyB4Mgo+ICAgICAtIHRwczY1MjE5LmMsIG5pdDogeyAubmFtZSA9ICJ0cHM2NTIxOS1ncGlvcyIs IH0sCj4gICAgIC0gdHBzNjUyMTkuaCwgbml0OiBQb3dlciBNYW5hZ2VtZW50IElDCj4gICAgIC0g dHBzNjUyMTkuaCwgcmV3b3JrIGhlYWRlcjogc3RydWN0IHRwczY1MjE5Cj4gICAgIC0gdHBzNjUy MTkuaCwgcmVtb3ZlIFN1cGVyZmxvdXMgIiAiIC8qIE1GRF9UUFM2NTIxOV9IICovCj4gICAgIC0g cmVtb3ZlIHVudXNlZCB0cHM2NTIxOV9zb2Z0X3NodXRkb3duIGZ1cnRoZXIgdG8gbWFrZSBXPTEg Y2hlY2sKPiAgICAgQmlqdSBEYXMgcmV2aWV3Ogo+ICAgICAtIFJlbW92ZSBhbGwgaW5jbHVkZXMg dGhhdCBhcmUgbm90IG1hbmRhdG9yeQo+ICAgICAtIFJlbW92ZSBjb250YWluZXJfb2YgZXJyIGNo ZWNrCj4gCj4gIE1BSU5UQUlORVJTICAgICAgICAgICAgICAgICAgfCAgIDEgKwo+ICBkcml2ZXJz L21mZC9LY29uZmlnICAgICAgICAgIHwgIDE0ICsrCj4gIGRyaXZlcnMvbWZkL01ha2VmaWxlICAg ICAgICAgfCAgIDEgKwo+ICBkcml2ZXJzL21mZC90cHM2NTIxOS5jICAgICAgIHwgMjk5ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBpbmNsdWRlL2xpbnV4L21mZC90cHM2NTIxOS5o IHwgMzQ1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIDUgZmlsZXMgY2hh bmdlZCwgNjYwIGluc2VydGlvbnMoKykKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvbWZk L3RwczY1MjE5LmMKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvbGludXgvbWZkL3RwczY1 MjE5LmgKCkFwcGxpZWQsIHRoYW5rcy4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK