From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C91A3C433FE for ; Thu, 17 Nov 2022 15:50:31 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 412993CCFD4 for ; Thu, 17 Nov 2022 16:50:29 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id E561E3C62D3 for ; Thu, 17 Nov 2022 16:50:18 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id A7B2B1022030 for ; Thu, 17 Nov 2022 16:50:16 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0C082226F0; Thu, 17 Nov 2022 15:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1668700216; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HpvzdNG5Qahy5YrsgzG7D4YvYXoIi0pJzJ2IlNnN0ow=; b=dEqhff8Mgtunyjh6SCGpwnlD31OrURSASg/TZ6fZfagRPbnMviuJT1wDErhl1nn1NK1ha/ FVSOFs9gm6SnZzLCSs1mXdHBz0sk2I/PxQI6rP8ugphNkm9/HN91xjbXkPTnj+iFO+LGn7 i7rrqFNKe0QEdNRUv7fE8eYJ9fOiH0k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1668700216; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HpvzdNG5Qahy5YrsgzG7D4YvYXoIi0pJzJ2IlNnN0ow=; b=WL+XNUAT5h4hxYgJgqWsuGvB2bS2hHHYBRbgPgqLtstspY/QqvhYkYGC3s+Nu+EcvYxg9/ Qgp345Iw+QNWL6AQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C9ECE13A12; Thu, 17 Nov 2022 15:50:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KH3ZLzdYdmNaLQAAMHmgww (envelope-from ); Thu, 17 Nov 2022 15:50:15 +0000 Date: Thu, 17 Nov 2022 16:50:13 +0100 From: Petr Vorel To: Amir Goldstein Message-ID: References: <20221115123721.12176-1-jack@suse.cz> <20221115124741.14400-3-jack@suse.cz> <20221116105814.ozfankn5qkizj2zr@quack3> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 3/3] fanotify10: Make evictable marks tests more reliable X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: Jan Kara , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Jan, Amir, > On Wed, Nov 16, 2022 at 12:58 PM Jan Kara wrote: > > On Wed 16-11-22 10:17:14, Pengfei Xu wrote: > > > Hi Jan Kara, > > > On 2022-11-15 at 13:47:38 +0100, Jan Kara wrote: > > > > Tests verifying that evictable inode marks don't pin inodes in memory > > > > are unreliable because slab shrinking (triggered by drop_caches) does > > > > not reliably evict inodes - dentries have to take round through the LRU > > > > list and only then get reclaimed and inodes get unpinned and then inodes > > > > have to be rotated through their LRU list to get reclaimed. If there are > > > > not enough freed entries while shrinking other slab caches, drop_caches > > > > will abort attempts to reclaim slab before inodes get evicted. > > > > Tweak evictable marks tests to use more files and marks in parallel and > > > > just verify that some (at least half) of the marks got evicted. This > > > > should be more tolerant to random fluctuation in slab reclaim > > > > efficiency. > > > If possible, could you add the Tested-by tag: > > > Tested-by: Pengfei Xu > > Sure, will do. I'll just wait whether there will be some other review > > comments. > I would want to say Reviewed-by, but I could only say Eyeballed-by. > I like the change and thanks for figuring this out, but the review > was very hard, so I did not have time to do it thoroughly. > Good luck, Petr ;-) Thanks :). I'm ill, hoping to be back working next week, I'll have look soon. Kind regards, Petr > Thanks, > Amir. -- Mailing list info: https://lists.linux.it/listinfo/ltp