From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1CC2C433FE for ; Sat, 19 Nov 2022 17:33:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234962AbiKSRdW (ORCPT ); Sat, 19 Nov 2022 12:33:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234755AbiKSRc4 (ORCPT ); Sat, 19 Nov 2022 12:32:56 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D27017068; Sat, 19 Nov 2022 09:32:55 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CA941997; Sat, 19 Nov 2022 18:32:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668879174; bh=vCSnsXti52M8cQmWHjjQRkKkW0Zzm1RY+fm63qKhsco=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vxTHDQNK+bnLKLtYTIk4nm5wW22of5CElmcUf5+bXlq+TQmruBW2WcyHVQwgQdUMU Q1iazqftnVCfEVUUJUo3UIYjYku5LxmgVk5+padIPwXsjjc5CcxIj8gK7gKfA29SZY z0pkR1j8obNwCABYL7e5fPusefvDmAvsgkz1Wado= Date: Sat, 19 Nov 2022 19:32:38 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter , linux-i2c@vger.kernel.org, kernel@pengutronix.de, Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 027/606] drm/bridge: nxp-ptn3460: Convert to i2c's .probe_new() Message-ID: References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-28-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221118224540.619276-28-uwe@kleine-koenig.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2022 at 11:36:01PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/nxp-ptn3460.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c > index 0851101a8c72..cd292a2f894c 100644 > --- a/drivers/gpu/drm/bridge/nxp-ptn3460.c > +++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c > @@ -257,8 +257,7 @@ static const struct drm_bridge_funcs ptn3460_bridge_funcs = { > .get_edid = ptn3460_get_edid, > }; > > -static int ptn3460_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int ptn3460_probe(struct i2c_client *client) > { > struct device *dev = &client->dev; > struct ptn3460_bridge *ptn_bridge; > @@ -336,7 +335,7 @@ MODULE_DEVICE_TABLE(of, ptn3460_match); > > static struct i2c_driver ptn3460_driver = { > .id_table = ptn3460_i2c_table, > - .probe = ptn3460_probe, > + .probe_new = ptn3460_probe, > .remove = ptn3460_remove, > .driver = { > .name = "nxp,ptn3460", > -- > 2.38.1 > -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94645C4332F for ; Sat, 19 Nov 2022 17:32:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1EB2B10E27D; Sat, 19 Nov 2022 17:32:58 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4891E10E27D for ; Sat, 19 Nov 2022 17:32:55 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CA941997; Sat, 19 Nov 2022 18:32:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668879174; bh=vCSnsXti52M8cQmWHjjQRkKkW0Zzm1RY+fm63qKhsco=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vxTHDQNK+bnLKLtYTIk4nm5wW22of5CElmcUf5+bXlq+TQmruBW2WcyHVQwgQdUMU Q1iazqftnVCfEVUUJUo3UIYjYku5LxmgVk5+padIPwXsjjc5CcxIj8gK7gKfA29SZY z0pkR1j8obNwCABYL7e5fPusefvDmAvsgkz1Wado= Date: Sat, 19 Nov 2022 19:32:38 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH 027/606] drm/bridge: nxp-ptn3460: Convert to i2c's .probe_new() Message-ID: References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-28-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221118224540.619276-28-uwe@kleine-koenig.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Jernej Skrabec , Jonas Karlman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Robert Foss , Wolfram Sang , Angel Iglesias , linux-i2c@vger.kernel.org, Andrzej Hajda , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Grant Likely , Lee Jones , kernel@pengutronix.de Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Nov 18, 2022 at 11:36:01PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/nxp-ptn3460.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c > index 0851101a8c72..cd292a2f894c 100644 > --- a/drivers/gpu/drm/bridge/nxp-ptn3460.c > +++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c > @@ -257,8 +257,7 @@ static const struct drm_bridge_funcs ptn3460_bridge_funcs = { > .get_edid = ptn3460_get_edid, > }; > > -static int ptn3460_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int ptn3460_probe(struct i2c_client *client) > { > struct device *dev = &client->dev; > struct ptn3460_bridge *ptn_bridge; > @@ -336,7 +335,7 @@ MODULE_DEVICE_TABLE(of, ptn3460_match); > > static struct i2c_driver ptn3460_driver = { > .id_table = ptn3460_i2c_table, > - .probe = ptn3460_probe, > + .probe_new = ptn3460_probe, > .remove = ptn3460_remove, > .driver = { > .name = "nxp,ptn3460", > -- > 2.38.1 > -- Regards, Laurent Pinchart