From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73669C4332F for ; Sat, 19 Nov 2022 17:42:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235128AbiKSRlu (ORCPT ); Sat, 19 Nov 2022 12:41:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235090AbiKSRlr (ORCPT ); Sat, 19 Nov 2022 12:41:47 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEDBE19039; Sat, 19 Nov 2022 09:41:46 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A464D749; Sat, 19 Nov 2022 18:41:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668879704; bh=tmILVvcrsIp++jwRB0Fo8wY9/8Iov6cSsmrYrOa125E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZI5TFASwFUYMBxhTEnFCTZxDq65nFajKo7w2NoQ/Ko6ZC6J7AZvMikOeaw/PaqWOM /guSY/9x96ni0s7Ht5mYTGA822xtuvGcoksvcbjN4xXY9W5fPgt5yF210cXkkBHh8Q tl3rtu5cMvgME3/TQ25BygQqsA7682hQCmzurIMg= Date: Sat, 19 Nov 2022 19:41:29 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter , Xin Ji , Hsin-Yi Wang , AngeloGioacchino Del Regno , Javier Martinez Canillas , Thomas Zimmermann , Marek Vasut , linux-i2c@vger.kernel.org, kernel@pengutronix.de, Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 017/606] drm/bridge: anx7625: Convert to i2c's .probe_new() Message-ID: References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-18-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221118224540.619276-18-uwe@kleine-koenig.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2022 at 11:35:51PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index b0ff1ecb80a5..86a52c5f4fbc 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -2562,8 +2562,7 @@ static void anx7625_runtime_disable(void *data) > pm_runtime_disable(data); > } > > -static int anx7625_i2c_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int anx7625_i2c_probe(struct i2c_client *client) > { > struct anx7625_data *platform; > struct anx7625_platform_data *pdata; > @@ -2756,7 +2755,7 @@ static struct i2c_driver anx7625_driver = { > .of_match_table = anx_match_table, > .pm = &anx7625_pm_ops, > }, > - .probe = anx7625_i2c_probe, > + .probe_new = anx7625_i2c_probe, > .remove = anx7625_i2c_remove, > > .id_table = anx7625_id, > -- > 2.38.1 > -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AB7DC4332F for ; Sat, 19 Nov 2022 17:41:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3079D10E295; Sat, 19 Nov 2022 17:41:50 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 43EDD10E28E for ; Sat, 19 Nov 2022 17:41:46 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A464D749; Sat, 19 Nov 2022 18:41:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668879704; bh=tmILVvcrsIp++jwRB0Fo8wY9/8Iov6cSsmrYrOa125E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZI5TFASwFUYMBxhTEnFCTZxDq65nFajKo7w2NoQ/Ko6ZC6J7AZvMikOeaw/PaqWOM /guSY/9x96ni0s7Ht5mYTGA822xtuvGcoksvcbjN4xXY9W5fPgt5yF210cXkkBHh8Q tl3rtu5cMvgME3/TQ25BygQqsA7682hQCmzurIMg= Date: Sat, 19 Nov 2022 19:41:29 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH 017/606] drm/bridge: anx7625: Convert to i2c's .probe_new() Message-ID: References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-18-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221118224540.619276-18-uwe@kleine-koenig.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Andrzej Hajda , Marek Vasut , Lee Jones , Javier Martinez Canillas , Jernej Skrabec , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Grant Likely , Jonas Karlman , Angel Iglesias , Hsin-Yi Wang , Xin Ji , AngeloGioacchino Del Regno , Neil Armstrong , Thomas Zimmermann , linux-kernel@vger.kernel.org, Robert Foss , Wolfram Sang , kernel@pengutronix.de Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Nov 18, 2022 at 11:35:51PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index b0ff1ecb80a5..86a52c5f4fbc 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -2562,8 +2562,7 @@ static void anx7625_runtime_disable(void *data) > pm_runtime_disable(data); > } > > -static int anx7625_i2c_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int anx7625_i2c_probe(struct i2c_client *client) > { > struct anx7625_data *platform; > struct anx7625_platform_data *pdata; > @@ -2756,7 +2755,7 @@ static struct i2c_driver anx7625_driver = { > .of_match_table = anx_match_table, > .pm = &anx7625_pm_ops, > }, > - .probe = anx7625_i2c_probe, > + .probe_new = anx7625_i2c_probe, > .remove = anx7625_i2c_remove, > > .id_table = anx7625_id, > -- > 2.38.1 > -- Regards, Laurent Pinchart