From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D80DC433FE for ; Sun, 20 Nov 2022 23:36:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229655AbiKTXgM (ORCPT ); Sun, 20 Nov 2022 18:36:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbiKTXgJ (ORCPT ); Sun, 20 Nov 2022 18:36:09 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBA8C2B613; Sun, 20 Nov 2022 15:36:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=aI2jnEgK19wCHQqoMeLWDiWUB6RdVgk21HiT4Yh9Fak=; b=cYz+hH9JTM6DDVFwQJJxm1/mW+ 4U7d5VyO+Na0o05Z9b75x0D4Kq1odfCa5rESy/6fgNMC7pA2w+B0Ja3R44WyaJy0cVsIE8AALcU0T /t9evWN/T6aj49iIwdKgvun2RCqmF8a1H5zlG/f6i0HBY6YRgZ04wfp2BiQhj/kZBN1s=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1owtqJ-002x8q-Qr; Mon, 21 Nov 2022 00:35:19 +0100 Date: Mon, 21 Nov 2022 00:35:19 +0100 From: Andrew Lunn To: Tim Harvey Cc: Ansuel Smith , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, Heiner Kallweit , Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski Subject: Re: [PATCH 0/3] add dt configuration for dp83867 led modes Message-ID: References: <20221118001548.635752-1-tharvey@gateworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 18, 2022 at 11:57:00AM -0800, Tim Harvey wrote: > On Fri, Nov 18, 2022 at 5:11 AM Andrew Lunn wrote: > > > > > Andrew, > > > > > > I completely agree with you but I haven't seen how that can be done > > > yet. What support exists for a PHY driver to expose their LED > > > configuration to be used that way? Can you point me to an example? > > > > Nobody has actually worked on this long enough to get code merged. e.g. > > https://lore.kernel.org/netdev/20201004095852.GB1104@bug/T/ > > https://lists.archive.carbon60.com/linux/kernel/3396223 > > > > This is probably the last attempt, which was not too far away from getting merged: > > https://patches.linaro.org/project/linux-leds/cover/20220503151633.18760-1-ansuelsmth@gmail.com/ > > > > I seem to NACK a patch like yours every couple of months. If all that > > wasted time was actually spent on a common framework, this would of > > been solved years ago. > > > > How important is it to you to control these LEDs? Enough to finish > > this code and get it merged? > > > > Andrew, > > Thanks for the links - the most recent attempt does look promising. > For whatever reason I don't have that series in my mail history so > it's not clear how I can respond to it. apt-get install b4 > Ansuel, are you planning on posting a v7 of 'Adds support for PHY LEDs > with offload triggers' [1]? > > I'm not all that familiar with netdev led triggers. Is there a way to > configure the default offload blink mode via dt with your series? I > didn't quite follow how the offload function/blink-mode gets set. The idea is that the PHY LEDs are just LEDs in the Linux LED framework. So read Documentation/devicetree/bindings/leds/common.yaml. The PHY should make use of these standard DT properties, including linux,default-trigger. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EC9FC433FE for ; Sun, 20 Nov 2022 23:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r5WWJ2yfY0y9S1XN8jtKOKfoKtL5nScF2k3ZlQ0sYV0=; b=Bp2j5Kzs2dgVHO Bw2mVHyVNTfJyyPn+k1GL7HLletvfAhI0BNSQtBVysqSnuvKqCNIAe1y04QV0/J5zDO0xJpzmxD5M WEhwg10e+I/j4U8O41PmpS7d4Ddn2unGlZ2KXA2M9pNXEc2FMBW2rMDOS3KOjGTifDVBL3O1KZdkQ ssRWO8xY0PoYFpuJz2uAAvDr1Vk62fmV0PYh3USGRyG2icMXSOIpMgYfRQ8k3se5sFqm80qH3mcys O/Az/Y6lwFKnZrpwz8erj9yJYAzimbiDAuqCZ9n1Pm1kPAHCPGQEuJa+cyars3UzELseDgl8BV1FZ hSxslNOxRps0EaYgKOzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1owtqm-007cgX-Jf; Sun, 20 Nov 2022 23:35:48 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1owtqk-007ce6-1C for linux-arm-kernel@lists.infradead.org; Sun, 20 Nov 2022 23:35:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=aI2jnEgK19wCHQqoMeLWDiWUB6RdVgk21HiT4Yh9Fak=; b=cYz+hH9JTM6DDVFwQJJxm1/mW+ 4U7d5VyO+Na0o05Z9b75x0D4Kq1odfCa5rESy/6fgNMC7pA2w+B0Ja3R44WyaJy0cVsIE8AALcU0T /t9evWN/T6aj49iIwdKgvun2RCqmF8a1H5zlG/f6i0HBY6YRgZ04wfp2BiQhj/kZBN1s=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1owtqJ-002x8q-Qr; Mon, 21 Nov 2022 00:35:19 +0100 Date: Mon, 21 Nov 2022 00:35:19 +0100 From: Andrew Lunn To: Tim Harvey Cc: Ansuel Smith , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, Heiner Kallweit , Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski Subject: Re: [PATCH 0/3] add dt configuration for dp83867 led modes Message-ID: References: <20221118001548.635752-1-tharvey@gateworks.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221120_153546_116591_C7B0A028 X-CRM114-Status: GOOD ( 26.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 18, 2022 at 11:57:00AM -0800, Tim Harvey wrote: > On Fri, Nov 18, 2022 at 5:11 AM Andrew Lunn wrote: > > > > > Andrew, > > > > > > I completely agree with you but I haven't seen how that can be done > > > yet. What support exists for a PHY driver to expose their LED > > > configuration to be used that way? Can you point me to an example? > > > > Nobody has actually worked on this long enough to get code merged. e.g. > > https://lore.kernel.org/netdev/20201004095852.GB1104@bug/T/ > > https://lists.archive.carbon60.com/linux/kernel/3396223 > > > > This is probably the last attempt, which was not too far away from getting merged: > > https://patches.linaro.org/project/linux-leds/cover/20220503151633.18760-1-ansuelsmth@gmail.com/ > > > > I seem to NACK a patch like yours every couple of months. If all that > > wasted time was actually spent on a common framework, this would of > > been solved years ago. > > > > How important is it to you to control these LEDs? Enough to finish > > this code and get it merged? > > > > Andrew, > > Thanks for the links - the most recent attempt does look promising. > For whatever reason I don't have that series in my mail history so > it's not clear how I can respond to it. apt-get install b4 > Ansuel, are you planning on posting a v7 of 'Adds support for PHY LEDs > with offload triggers' [1]? > > I'm not all that familiar with netdev led triggers. Is there a way to > configure the default offload blink mode via dt with your series? I > didn't quite follow how the offload function/blink-mode gets set. The idea is that the PHY LEDs are just LEDs in the Linux LED framework. So read Documentation/devicetree/bindings/leds/common.yaml. The PHY should make use of these standard DT properties, including linux,default-trigger. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel