From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B55410786 for ; Mon, 21 Nov 2022 22:16:43 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E896574C; Mon, 21 Nov 2022 23:16:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1669069001; bh=dByGzk5Ixipj8ieHyh9CDx3Ni0F5DSa2dT1//PyYycM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vw9UNv2VcIDDSN0MafAt+SO4xJDrHcMh/7inYbjwf4BAaxWis0br2ehGd8nFh6QxH x/YZAvlZApKVmAFTCtkz8PUx/9viR2nP6jZiLJIkj+XzdJSvru8IdrHLhUm0DErFxB wkZSwnDXcE7IyedRaXGXnhKL24+RU0XWYbqAxUW8= Date: Tue, 22 Nov 2022 00:16:25 +0200 From: Laurent Pinchart To: Umang Jain Cc: linux-media@vger.kernel.org, kernel-list@raspberrypi.com, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, Broadcom internal kernel review list , Dave Stevenson , Florian Fainelli , Naushir Patuck , David Plowman , Kieran Bingham Subject: Re: [PATCH 00/14] staging: vc04_services: bcm2835-isp support Message-ID: References: <20221121214722.22563-1-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221121214722.22563-1-umang.jain@ideasonboard.com> Hi Umang, Nice to see this series on the list ! On Tue, Nov 22, 2022 at 03:17:08AM +0530, Umang Jain wrote: > This series aims to upport bcm2835-isp from the RPi kernel [1] and is a > independent subset of earlier series [2] posted to upport CSI-2/CCP2 > receiver IP core("Unicam) + the ISP driver found in BCM283x and compatible > SoCs (namely BCM2711). Unicam is still under active development to work > with multistream support to get into mainline. Hence only the ISP driver > will remain the primary area of this series. > > Patch (01-02)/14 adds a new driver named vc-sm-cma to handle memory sharing > with the VC4 VPU. > > Patch 03/14 adds a small extension to videobuf2 to allow exporting as a > dma_buf instead of a file-descriptor. > > Patch (04-05)/14 adds a couple of improvements/support for > bcm2835-isp(event callback and zero-copy) to vchiq-mmal. > > Patch (06-09)/14 adds the core bcm2835-isp driver along with headers > and format defintions. > > Patch (10-11)/14 deals with the colorspace support. > Note: This is still WIP since the implementation of colorspace is still > getting ironed out (especially around setting of colorspace flags handling). > > Patch 12/14 allows multiple instances of the ISP. > > Patch 13/14 adds a admin-guide document on bcm2835-isp. > > Patch 14/14 wires all this up with the vchiq-mmal driver. > > Testing: > Tested with RPi Model 4B running linux mainline v6.1-rc6. To test > end-to-end, I choose to cherry-pick the Unicam patches and OV5647 DT > bindings from [1]). Once done, functional testing was conducted with > libcamera[3] and its utility tools. > > Also note: Reviews given on [2] for the relevant ISP driver patches have > been incorporated in this version. > > Known issues: > - Colorspace handling This will require further discussions, I'll try to comment on this topic in the review of the ISP driver patch. > - vc-sm-cma spamming kernel log with > - pr_err("%s: Expecting an uncached alias for dma_addr %pad\n" Do you have any plan to address this ? Is the root cause known ? > [1]: https://github.com/raspberrypi/linux > [2]: https://lore.kernel.org/linux-media/20200504092611.9798-1-laurent.pinchart@ideasonboard.com/ > [3]: https://libcamera.org/getting-started.html > > Dave Stevenson (7): > staging: vc04_services: Add new vc-sm-cma driver > staging: vchiq_arm: Register vcsm-cma as a platform driver > media: videobuf2: Allow exporting of a struct dmabuf > staging: mmal-vchiq: Add support for event callbacks > staging: mmal-vchiq: Use vc-sm-cma to support zero copy > staging: mmal_vchiq: Add image formats to be used by bcm2835-isp > uapi: bcm2835-isp: Add bcm2835-isp uapi header file > > David Plowman (2): > vc04_services: bcm2835-isp: Allow formats with different colour spaces > vc04_services: bcm2835-isp: Permit all sRGB colour spaces on ISP > outputs > > Naushir Patuck (5): > media: uapi: v4l2-core: Add ISP statistics output V4L2 fourcc type > staging: vc04_services: bcm2835-isp: Add a more complex ISP processing > component > staging: vc04_services: bcm2835_isp: Allow multiple users > docs: admin-guide: media: bcm2835-isp: Add documentation for > bcm2835-isp > staging: vc04_services: vchiq: Load bcm2835_isp driver from vchiq > > .../admin-guide/media/bcm2835-isp.rst | 127 ++ > .../userspace-api/media/drivers/index.rst | 1 + > .../userspace-api/media/v4l/meta-formats.rst | 1 + > .../v4l/pixfmt-meta-bcm2835-isp-stats.rst | 41 + > MAINTAINERS | 9 + > .../media/common/videobuf2/videobuf2-core.c | 36 +- > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > drivers/staging/vc04_services/Kconfig | 4 + > drivers/staging/vc04_services/Makefile | 2 + > .../staging/vc04_services/bcm2835-isp/Kconfig | 14 + > .../vc04_services/bcm2835-isp/Makefile | 8 + > .../bcm2835-isp/bcm2835-isp-ctrls.h | 72 + > .../bcm2835-isp/bcm2835-isp-fmts.h | 558 +++++ > .../bcm2835-isp/bcm2835-v4l2-isp.c | 1817 +++++++++++++++++ > .../interface/vchiq_arm/vchiq_arm.c | 6 + > .../staging/vc04_services/vc-sm-cma/Kconfig | 10 + > .../staging/vc04_services/vc-sm-cma/Makefile | 12 + > .../staging/vc04_services/vc-sm-cma/vc_sm.c | 801 ++++++++ > .../staging/vc04_services/vc-sm-cma/vc_sm.h | 54 + > .../vc04_services/vc-sm-cma/vc_sm_cma_vchi.c | 507 +++++ > .../vc04_services/vc-sm-cma/vc_sm_cma_vchi.h | 63 + > .../vc04_services/vc-sm-cma/vc_sm_defs.h | 187 ++ > .../vc04_services/vc-sm-cma/vc_sm_knl.h | 28 + > .../staging/vc04_services/vchiq-mmal/Kconfig | 1 + > .../vc04_services/vchiq-mmal/mmal-common.h | 5 + > .../vc04_services/vchiq-mmal/mmal-encodings.h | 66 + > .../vc04_services/vchiq-mmal/mmal-msg.h | 35 + > .../vchiq-mmal/mmal-parameters.h | 165 +- > .../vc04_services/vchiq-mmal/mmal-vchiq.c | 253 ++- > .../vc04_services/vchiq-mmal/mmal-vchiq.h | 5 + > include/media/videobuf2-core.h | 15 + > include/uapi/linux/bcm2835-isp.h | 347 ++++ > include/uapi/linux/v4l2-controls.h | 6 + > include/uapi/linux/videodev2.h | 1 + > 34 files changed, 5225 insertions(+), 33 deletions(-) > create mode 100644 Documentation/admin-guide/media/bcm2835-isp.rst > create mode 100644 Documentation/userspace-api/media/v4l/pixfmt-meta-bcm2835-isp-stats.rst > create mode 100644 drivers/staging/vc04_services/bcm2835-isp/Kconfig > create mode 100644 drivers/staging/vc04_services/bcm2835-isp/Makefile > create mode 100644 drivers/staging/vc04_services/bcm2835-isp/bcm2835-isp-ctrls.h > create mode 100644 drivers/staging/vc04_services/bcm2835-isp/bcm2835-isp-fmts.h > create mode 100644 drivers/staging/vc04_services/bcm2835-isp/bcm2835-v4l2-isp.c > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/Kconfig > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/Makefile > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm.c > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm.h > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_cma_vchi.c > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_cma_vchi.h > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_defs.h > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_knl.h > create mode 100644 include/uapi/linux/bcm2835-isp.h -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DECBCC4332F for ; Mon, 21 Nov 2022 22:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P2kfnWCvpXLjnn9Ge+bn8L5/wxAKByOSuVoVneRzGeQ=; b=ANVuEPDBGBVd3Y ZVKpCQK5JNlaByJv6dduNniJjKTSJ0PRzTP3p8EGX9VQxqxQIgsXugk7Djot4SU+YssXg1Hk5vRNU 0K0QnRYxNhggo0ZfQZWojHpk9eFlaVM9R60I7xsmwdf4pxtdp3+ijD7tuJDst1HWpF8xP/QP00Gmq s86Wa9MxrNoUFgVWOcbHFT+J8Ryzo1RAOn3roA3F8SSNy24k3Mz9zZN6lMrrcwmvwGcTnr2HxCt9t Nnw55725+syXcosk+eZNHRQrtYckQWivW3BCpTmL8NDQzIQYWtjRSqGvYU2MjoEZ0kYpLo/LM5rX6 GjunZZJU0UsCZcQPQnxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxF5q-000m0O-KT; Mon, 21 Nov 2022 22:16:46 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxF5m-000lzd-SE; Mon, 21 Nov 2022 22:16:44 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E896574C; Mon, 21 Nov 2022 23:16:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1669069001; bh=dByGzk5Ixipj8ieHyh9CDx3Ni0F5DSa2dT1//PyYycM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vw9UNv2VcIDDSN0MafAt+SO4xJDrHcMh/7inYbjwf4BAaxWis0br2ehGd8nFh6QxH x/YZAvlZApKVmAFTCtkz8PUx/9viR2nP6jZiLJIkj+XzdJSvru8IdrHLhUm0DErFxB wkZSwnDXcE7IyedRaXGXnhKL24+RU0XWYbqAxUW8= Date: Tue, 22 Nov 2022 00:16:25 +0200 From: Laurent Pinchart To: Umang Jain Cc: linux-media@vger.kernel.org, kernel-list@raspberrypi.com, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, Broadcom internal kernel review list , Dave Stevenson , Florian Fainelli , Naushir Patuck , David Plowman , Kieran Bingham Subject: Re: [PATCH 00/14] staging: vc04_services: bcm2835-isp support Message-ID: References: <20221121214722.22563-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221121214722.22563-1-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_141643_080139_A8EE0581 X-CRM114-Status: GOOD ( 26.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Umang, Nice to see this series on the list ! On Tue, Nov 22, 2022 at 03:17:08AM +0530, Umang Jain wrote: > This series aims to upport bcm2835-isp from the RPi kernel [1] and is a > independent subset of earlier series [2] posted to upport CSI-2/CCP2 > receiver IP core("Unicam) + the ISP driver found in BCM283x and compatible > SoCs (namely BCM2711). Unicam is still under active development to work > with multistream support to get into mainline. Hence only the ISP driver > will remain the primary area of this series. > > Patch (01-02)/14 adds a new driver named vc-sm-cma to handle memory sharing > with the VC4 VPU. > > Patch 03/14 adds a small extension to videobuf2 to allow exporting as a > dma_buf instead of a file-descriptor. > > Patch (04-05)/14 adds a couple of improvements/support for > bcm2835-isp(event callback and zero-copy) to vchiq-mmal. > > Patch (06-09)/14 adds the core bcm2835-isp driver along with headers > and format defintions. > > Patch (10-11)/14 deals with the colorspace support. > Note: This is still WIP since the implementation of colorspace is still > getting ironed out (especially around setting of colorspace flags handling). > > Patch 12/14 allows multiple instances of the ISP. > > Patch 13/14 adds a admin-guide document on bcm2835-isp. > > Patch 14/14 wires all this up with the vchiq-mmal driver. > > Testing: > Tested with RPi Model 4B running linux mainline v6.1-rc6. To test > end-to-end, I choose to cherry-pick the Unicam patches and OV5647 DT > bindings from [1]). Once done, functional testing was conducted with > libcamera[3] and its utility tools. > > Also note: Reviews given on [2] for the relevant ISP driver patches have > been incorporated in this version. > > Known issues: > - Colorspace handling This will require further discussions, I'll try to comment on this topic in the review of the ISP driver patch. > - vc-sm-cma spamming kernel log with > - pr_err("%s: Expecting an uncached alias for dma_addr %pad\n" Do you have any plan to address this ? Is the root cause known ? > [1]: https://github.com/raspberrypi/linux > [2]: https://lore.kernel.org/linux-media/20200504092611.9798-1-laurent.pinchart@ideasonboard.com/ > [3]: https://libcamera.org/getting-started.html > > Dave Stevenson (7): > staging: vc04_services: Add new vc-sm-cma driver > staging: vchiq_arm: Register vcsm-cma as a platform driver > media: videobuf2: Allow exporting of a struct dmabuf > staging: mmal-vchiq: Add support for event callbacks > staging: mmal-vchiq: Use vc-sm-cma to support zero copy > staging: mmal_vchiq: Add image formats to be used by bcm2835-isp > uapi: bcm2835-isp: Add bcm2835-isp uapi header file > > David Plowman (2): > vc04_services: bcm2835-isp: Allow formats with different colour spaces > vc04_services: bcm2835-isp: Permit all sRGB colour spaces on ISP > outputs > > Naushir Patuck (5): > media: uapi: v4l2-core: Add ISP statistics output V4L2 fourcc type > staging: vc04_services: bcm2835-isp: Add a more complex ISP processing > component > staging: vc04_services: bcm2835_isp: Allow multiple users > docs: admin-guide: media: bcm2835-isp: Add documentation for > bcm2835-isp > staging: vc04_services: vchiq: Load bcm2835_isp driver from vchiq > > .../admin-guide/media/bcm2835-isp.rst | 127 ++ > .../userspace-api/media/drivers/index.rst | 1 + > .../userspace-api/media/v4l/meta-formats.rst | 1 + > .../v4l/pixfmt-meta-bcm2835-isp-stats.rst | 41 + > MAINTAINERS | 9 + > .../media/common/videobuf2/videobuf2-core.c | 36 +- > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > drivers/staging/vc04_services/Kconfig | 4 + > drivers/staging/vc04_services/Makefile | 2 + > .../staging/vc04_services/bcm2835-isp/Kconfig | 14 + > .../vc04_services/bcm2835-isp/Makefile | 8 + > .../bcm2835-isp/bcm2835-isp-ctrls.h | 72 + > .../bcm2835-isp/bcm2835-isp-fmts.h | 558 +++++ > .../bcm2835-isp/bcm2835-v4l2-isp.c | 1817 +++++++++++++++++ > .../interface/vchiq_arm/vchiq_arm.c | 6 + > .../staging/vc04_services/vc-sm-cma/Kconfig | 10 + > .../staging/vc04_services/vc-sm-cma/Makefile | 12 + > .../staging/vc04_services/vc-sm-cma/vc_sm.c | 801 ++++++++ > .../staging/vc04_services/vc-sm-cma/vc_sm.h | 54 + > .../vc04_services/vc-sm-cma/vc_sm_cma_vchi.c | 507 +++++ > .../vc04_services/vc-sm-cma/vc_sm_cma_vchi.h | 63 + > .../vc04_services/vc-sm-cma/vc_sm_defs.h | 187 ++ > .../vc04_services/vc-sm-cma/vc_sm_knl.h | 28 + > .../staging/vc04_services/vchiq-mmal/Kconfig | 1 + > .../vc04_services/vchiq-mmal/mmal-common.h | 5 + > .../vc04_services/vchiq-mmal/mmal-encodings.h | 66 + > .../vc04_services/vchiq-mmal/mmal-msg.h | 35 + > .../vchiq-mmal/mmal-parameters.h | 165 +- > .../vc04_services/vchiq-mmal/mmal-vchiq.c | 253 ++- > .../vc04_services/vchiq-mmal/mmal-vchiq.h | 5 + > include/media/videobuf2-core.h | 15 + > include/uapi/linux/bcm2835-isp.h | 347 ++++ > include/uapi/linux/v4l2-controls.h | 6 + > include/uapi/linux/videodev2.h | 1 + > 34 files changed, 5225 insertions(+), 33 deletions(-) > create mode 100644 Documentation/admin-guide/media/bcm2835-isp.rst > create mode 100644 Documentation/userspace-api/media/v4l/pixfmt-meta-bcm2835-isp-stats.rst > create mode 100644 drivers/staging/vc04_services/bcm2835-isp/Kconfig > create mode 100644 drivers/staging/vc04_services/bcm2835-isp/Makefile > create mode 100644 drivers/staging/vc04_services/bcm2835-isp/bcm2835-isp-ctrls.h > create mode 100644 drivers/staging/vc04_services/bcm2835-isp/bcm2835-isp-fmts.h > create mode 100644 drivers/staging/vc04_services/bcm2835-isp/bcm2835-v4l2-isp.c > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/Kconfig > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/Makefile > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm.c > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm.h > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_cma_vchi.c > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_cma_vchi.h > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_defs.h > create mode 100644 drivers/staging/vc04_services/vc-sm-cma/vc_sm_knl.h > create mode 100644 include/uapi/linux/bcm2835-isp.h -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel