From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A370E7C for ; Mon, 5 Dec 2022 12:50:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27E0AC433D6; Mon, 5 Dec 2022 12:50:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670244647; bh=qf/NfO2N/WqW2ZAtOS02wKfWAQc4h++cVVZ9fzqJa84=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GaeUSIDpPqwpdzLNKCPdj7nuICOGrt1+m6i5rReASNq/bfRSVAVCLQeZfTILJAoTv g20Wu+YlLIym5Uouextf0VdZNsfVYpcpneL1U0pToMEzRNnO0uKfjx3j0VKSZQkEAu F23F6NH+NhYuaJgoGqVdQ0+w3E2TlyRLh66M0CTJSPHt1RRyN0sNqPjwimgKLSAEnC b2otiNYxOxXiIr6MITQVppAKXoTEcqM0D8Wdofys85r90OoS+uuMR5o+8mNxsR3o/2 tT01lZtswgLYsEFGiFWQLLlLnTyEGDHIbyPWH4VSDQadNSYjMbDg466Aybrm+eJFQ4 4qvSbZI3W+8LQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EFCFE40404; Mon, 5 Dec 2022 09:50:44 -0300 (-03) Date: Mon, 5 Dec 2022 09:50:44 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Josh Poimboeuf , Nathan Chancellor , Nick Desaulniers , Tom Rix , Masahiro Yamada , Nicolas Schier , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev, Stephane Eranian Subject: Re: [PATCH 0/5] Improvements to incremental builds Message-ID: References: <20221202045743.2639466-1-irogers@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221202045743.2639466-1-irogers@google.com> X-Url: http://acmel.wordpress.com Em Thu, Dec 01, 2022 at 08:57:38PM -0800, Ian Rogers escreveu: > Switching to using install_headers caused incremental builds to always > rebuild most targets. This was caused by the headers always being > reinstalled and then getting new timestamps causing dependencies to be > rebuilt. Follow the convention in libbpf where the install targets are > separated and trigger when the target isn't present or is out-of-date. > > Further, fix an issue in the perf build with libpython where > python/perf.so was also regenerated as the target name was incorrect. > > Ian Rogers (5): > tools lib api: Add dependency test to install_headers > tools lib perf: Add dependency test to install_headers > tools lib subcmd: Add dependency test to install_headers > tools lib symbol: Add dependency test to install_headers > perf build: Fix python/perf.so library's name The last one isn't applying: Applying: perf build: Fix python/perf.so library's name error: patch failed: tools/perf/Makefile.perf:642 error: tools/perf/Makefile.perf: patch does not apply Patch failed at 0005 perf build: Fix python/perf.so library's name hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". ⬢[acme@toolbox perf]$ I'll have the first 4 applied to make progress, later I'll check what went wrong and to fix it. - Arnaldo